From: Sami Tolvanen <samitolvanen@google.com> To: Masahiro Yamada <masahiroy@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Will Deacon <will@kernel.org> Cc: Josh Poimboeuf <jpoimboe@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Paul E. McKenney" <paulmck@kernel.org>, Kees Cook <keescook@chromium.org>, Nick Desaulniers <ndesaulniers@google.com>, clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Sami Tolvanen <samitolvanen@google.com> Subject: [PATCH v9 09/16] PCI: Fix PREL32 relocations for LTO Date: Fri, 11 Dec 2020 10:46:26 -0800 [thread overview] Message-ID: <20201211184633.3213045-10-samitolvanen@google.com> (raw) In-Reply-To: <20201211184633.3213045-1-samitolvanen@google.com> With Clang's Link Time Optimization (LTO), the compiler can rename static functions to avoid global naming collisions. As PCI fixup functions are typically static, renaming can break references to them in inline assembly. This change adds a global stub to DECLARE_PCI_FIXUP_SECTION to fix the issue when PREL32 relocations are used. Signed-off-by: Sami Tolvanen <samitolvanen@google.com> Acked-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Kees Cook <keescook@chromium.org> --- include/linux/pci.h | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/include/linux/pci.h b/include/linux/pci.h index 22207a79762c..5b8505a5ca5f 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1912,19 +1912,28 @@ enum pci_fixup_pass { }; #ifdef CONFIG_HAVE_ARCH_PREL32_RELOCATIONS -#define __DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ - class_shift, hook) \ - __ADDRESSABLE(hook) \ +#define ___DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ + class_shift, hook, stub) \ + void stub(struct pci_dev *dev); \ + void stub(struct pci_dev *dev) \ + { \ + hook(dev); \ + } \ asm(".section " #sec ", \"a\" \n" \ ".balign 16 \n" \ ".short " #vendor ", " #device " \n" \ ".long " #class ", " #class_shift " \n" \ - ".long " #hook " - . \n" \ + ".long " #stub " - . \n" \ ".previous \n"); + +#define __DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ + class_shift, hook, stub) \ + ___DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ + class_shift, hook, stub) #define DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ class_shift, hook) \ __DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ - class_shift, hook) + class_shift, hook, __UNIQUE_ID(hook)) #else /* Anonymous variables would be nice... */ #define DECLARE_PCI_FIXUP_SECTION(section, name, vendor, device, class, \ -- 2.29.2.576.ga3fc446d84-goog
WARNING: multiple messages have this Message-ID (diff)
From: Sami Tolvanen <samitolvanen@google.com> To: Masahiro Yamada <masahiroy@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Will Deacon <will@kernel.org> Cc: linux-arch@vger.kernel.org, Kees Cook <keescook@chromium.org>, "Paul E. McKenney" <paulmck@kernel.org>, kernel-hardening@lists.openwall.com, Peter Zijlstra <peterz@infradead.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kbuild@vger.kernel.org, Nick Desaulniers <ndesaulniers@google.com>, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, clang-built-linux@googlegroups.com, Sami Tolvanen <samitolvanen@google.com>, Josh Poimboeuf <jpoimboe@redhat.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v9 09/16] PCI: Fix PREL32 relocations for LTO Date: Fri, 11 Dec 2020 10:46:26 -0800 [thread overview] Message-ID: <20201211184633.3213045-10-samitolvanen@google.com> (raw) In-Reply-To: <20201211184633.3213045-1-samitolvanen@google.com> With Clang's Link Time Optimization (LTO), the compiler can rename static functions to avoid global naming collisions. As PCI fixup functions are typically static, renaming can break references to them in inline assembly. This change adds a global stub to DECLARE_PCI_FIXUP_SECTION to fix the issue when PREL32 relocations are used. Signed-off-by: Sami Tolvanen <samitolvanen@google.com> Acked-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Kees Cook <keescook@chromium.org> --- include/linux/pci.h | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/include/linux/pci.h b/include/linux/pci.h index 22207a79762c..5b8505a5ca5f 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1912,19 +1912,28 @@ enum pci_fixup_pass { }; #ifdef CONFIG_HAVE_ARCH_PREL32_RELOCATIONS -#define __DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ - class_shift, hook) \ - __ADDRESSABLE(hook) \ +#define ___DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ + class_shift, hook, stub) \ + void stub(struct pci_dev *dev); \ + void stub(struct pci_dev *dev) \ + { \ + hook(dev); \ + } \ asm(".section " #sec ", \"a\" \n" \ ".balign 16 \n" \ ".short " #vendor ", " #device " \n" \ ".long " #class ", " #class_shift " \n" \ - ".long " #hook " - . \n" \ + ".long " #stub " - . \n" \ ".previous \n"); + +#define __DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ + class_shift, hook, stub) \ + ___DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ + class_shift, hook, stub) #define DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ class_shift, hook) \ __DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \ - class_shift, hook) + class_shift, hook, __UNIQUE_ID(hook)) #else /* Anonymous variables would be nice... */ #define DECLARE_PCI_FIXUP_SECTION(section, name, vendor, device, class, \ -- 2.29.2.576.ga3fc446d84-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-11 20:20 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-11 18:46 [PATCH v9 00/16] Add support for Clang LTO Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` [PATCH v9 01/16] tracing: move function tracer options to Kconfig Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2021-02-24 20:17 ` [PATCH v9 01/16] tracing: move function tracer options to Kconfig (causing parisc build failures) Guenter Roeck 2021-02-24 20:17 ` Guenter Roeck 2021-02-24 20:38 ` Kees Cook 2021-02-24 20:38 ` Kees Cook 2021-02-24 20:54 ` Sami Tolvanen 2021-02-24 20:54 ` Sami Tolvanen 2021-02-24 20:54 ` Sami Tolvanen 2021-02-24 22:29 ` Guenter Roeck 2021-02-24 22:29 ` Guenter Roeck 2021-02-24 22:28 ` Guenter Roeck 2021-02-24 22:28 ` Guenter Roeck 2021-02-24 22:42 ` Kees Cook 2021-02-24 22:42 ` Kees Cook 2020-12-11 18:46 ` [PATCH v9 02/16] kbuild: add support for Clang LTO Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` [PATCH v9 03/16] kbuild: lto: fix module versioning Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` [PATCH v9 04/16] kbuild: lto: limit inlining Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` [PATCH v9 05/16] kbuild: lto: merge module sections Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2021-02-16 21:37 ` Stephen Boyd 2021-02-16 21:37 ` Stephen Boyd 2020-12-11 18:46 ` [PATCH v9 06/16] kbuild: lto: add a default list of used symbols Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 19:32 ` Kees Cook 2020-12-11 19:32 ` Kees Cook 2020-12-11 19:40 ` Sami Tolvanen 2020-12-11 19:40 ` Sami Tolvanen 2020-12-11 19:40 ` Sami Tolvanen 2020-12-11 19:45 ` Nick Desaulniers 2020-12-11 19:45 ` Nick Desaulniers 2020-12-11 19:45 ` Nick Desaulniers 2020-12-11 18:46 ` [PATCH v9 07/16] init: lto: ensure initcall ordering Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` [PATCH v9 08/16] init: lto: fix PREL32 relocations Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen [this message] 2020-12-11 18:46 ` [PATCH v9 09/16] PCI: Fix PREL32 relocations for LTO Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` [PATCH v9 10/16] modpost: lto: strip .lto from module names Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` [PATCH v9 11/16] scripts/mod: disable LTO for empty.c Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` [PATCH v9 12/16] efi/libstub: disable LTO Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` [PATCH v9 13/16] drivers/misc/lkdtm: disable LTO for rodata.o Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` [PATCH v9 14/16] arm64: vdso: disable LTO Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` [PATCH v9 15/16] arm64: disable recordmcount with DYNAMIC_FTRACE_WITH_REGS Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` [PATCH v9 16/16] arm64: allow LTO to be selected Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 18:46 ` Sami Tolvanen 2020-12-11 19:38 ` [PATCH v9 00/16] Add support for Clang LTO Kees Cook 2020-12-11 19:38 ` Kees Cook 2021-01-09 0:27 ` Kees Cook 2021-01-09 0:27 ` Kees Cook 2021-01-09 14:54 ` Sedat Dilek 2021-01-09 14:54 ` Sedat Dilek 2021-01-09 14:54 ` Sedat Dilek 2021-01-09 15:36 ` Josh Poimboeuf 2021-01-09 15:36 ` Josh Poimboeuf 2021-01-09 15:46 ` Sedat Dilek 2021-01-09 15:46 ` Sedat Dilek 2021-01-09 15:46 ` Sedat Dilek 2021-01-09 16:07 ` Josh Poimboeuf 2021-01-09 16:07 ` Josh Poimboeuf 2021-01-09 16:21 ` Sedat Dilek 2021-01-09 16:21 ` Sedat Dilek 2021-01-09 16:21 ` Sedat Dilek 2021-01-09 16:32 ` Josh Poimboeuf 2021-01-09 16:32 ` Josh Poimboeuf 2021-01-09 16:45 ` Sedat Dilek 2021-01-09 16:45 ` Sedat Dilek 2021-01-09 16:45 ` Sedat Dilek 2021-01-09 17:03 ` Josh Poimboeuf 2021-01-09 17:03 ` Josh Poimboeuf 2021-01-09 17:05 ` Josh Poimboeuf 2021-01-09 17:05 ` Josh Poimboeuf 2021-01-09 17:33 ` Sedat Dilek 2021-01-09 17:33 ` Sedat Dilek 2021-01-09 17:33 ` Sedat Dilek 2021-01-09 23:44 ` Sedat Dilek 2021-01-09 23:44 ` Sedat Dilek 2021-01-09 23:44 ` Sedat Dilek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201211184633.3213045-10-samitolvanen@google.com \ --to=samitolvanen@google.com \ --cc=clang-built-linux@googlegroups.com \ --cc=gregkh@linuxfoundation.org \ --cc=jpoimboe@redhat.com \ --cc=keescook@chromium.org \ --cc=kernel-hardening@lists.openwall.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=masahiroy@kernel.org \ --cc=ndesaulniers@google.com \ --cc=paulmck@kernel.org \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.