All of lore.kernel.org
 help / color / mirror / Atom feed
* [cifs:for-next 9/15] fs/cifs/fs_context.c:238:5-7: Unneeded variable: "rc". Return "0" on line 261
@ 2020-12-12  0:47 kernel test robot
  2020-12-12  0:47 ` [PATCH] cifs: fix returnvar.cocci warnings kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2020-12-12  0:47 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-cifs(a)vger.kernel.org
CC: samba-technical(a)lists.samba.org
TO: Ronnie Sahlberg <lsahlber@redhat.com>
CC: Steve French <stfrench@microsoft.com>

tree:   git://git.samba.org/sfrench/cifs-2.6.git for-next
head:   2dc7338d009dd9e5986121b2eae0178082eed5a1
commit: 8dd343e732466a0dd040898bddefd4e1c556dd10 [9/15] cifs: rename dup_vol to smb3_fs_context_dup and move it into fs_context.c
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
config: i386-randconfig-c001-20201209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> fs/cifs/fs_context.c:238:5-7: Unneeded variable: "rc". Return "0" on line 261

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39075 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] cifs: fix returnvar.cocci warnings
  2020-12-12  0:47 [cifs:for-next 9/15] fs/cifs/fs_context.c:238:5-7: Unneeded variable: "rc". Return "0" on line 261 kernel test robot
@ 2020-12-12  0:47 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-12-12  0:47 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-cifs(a)vger.kernel.org
CC: samba-technical(a)lists.samba.org
TO: Ronnie Sahlberg <lsahlber@redhat.com>
CC: Steve French <stfrench@microsoft.com>
CC: linux-cifs(a)vger.kernel.org
CC: samba-technical(a)lists.samba.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

fs/cifs/fs_context.c:238:5-7: Unneeded variable: "rc". Return "0" on line 261


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 8dd343e73246 ("cifs: rename dup_vol to smb3_fs_context_dup and move it into fs_context.c")
CC: Ronnie Sahlberg <lsahlber@redhat.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   git://git.samba.org/sfrench/cifs-2.6.git for-next
head:   2dc7338d009dd9e5986121b2eae0178082eed5a1
commit: 8dd343e732466a0dd040898bddefd4e1c556dd10 [9/15] cifs: rename dup_vol to smb3_fs_context_dup and move it into fs_context.c
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

Please take the patch only if it's a positive warning. Thanks!

 fs_context.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/fs/cifs/fs_context.c
+++ b/fs/cifs/fs_context.c
@@ -235,8 +235,6 @@ do {									\
 int
 smb3_fs_context_dup(struct smb3_fs_context *new_ctx, struct smb3_fs_context *ctx)
 {
-	int rc = 0;
-
 	memcpy(new_ctx, ctx, sizeof(*ctx));
 	new_ctx->prepath = NULL;
 	new_ctx->local_nls = NULL;
@@ -258,5 +256,5 @@ smb3_fs_context_dup(struct smb3_fs_conte
 	DUP_CTX_STR(nodename);
 	DUP_CTX_STR(iocharset);
 
-	return rc;
+	return 0;
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-12  0:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-12  0:47 [cifs:for-next 9/15] fs/cifs/fs_context.c:238:5-7: Unneeded variable: "rc". Return "0" on line 261 kernel test robot
2020-12-12  0:47 ` [PATCH] cifs: fix returnvar.cocci warnings kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.