* [PATCH] igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr
@ 2020-12-11 14:34 Kevin Lo
2020-12-12 22:00 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Lo @ 2020-12-11 14:34 UTC (permalink / raw)
To: Sasha Neftin, Jeff Kirsher; +Cc: David S . Miller, netdev
This patch sets the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr.
Without this change it wouldn't lead to a shadow RAM write EEWR timeout.
Signed-off-by: Kevin Lo <kevlo@kevlo.org>
---
diff --git a/drivers/net/ethernet/intel/igc/igc_i225.c b/drivers/net/ethernet/intel/igc/igc_i225.c
index 8b67d9b49a83..b0a5cd31683e 100644
--- a/drivers/net/ethernet/intel/igc/igc_i225.c
+++ b/drivers/net/ethernet/intel/igc/igc_i225.c
@@ -221,7 +221,7 @@ static s32 igc_write_nvm_srwr(struct igc_hw *hw, u16 offset, u16 words,
struct igc_nvm_info *nvm = &hw->nvm;
u32 attempts = 100000;
u32 i, k, eewr = 0;
- s32 ret_val = 0;
+ s32 ret_val = -IGC_ERR_NVM;
/* A check for invalid values: offset too large, too many words,
* too many words for the offset, and not enough words.
@@ -229,7 +229,6 @@ static s32 igc_write_nvm_srwr(struct igc_hw *hw, u16 offset, u16 words,
if (offset >= nvm->word_size || (words > (nvm->word_size - offset)) ||
words == 0) {
hw_dbg("nvm parameter(s) out of bounds\n");
- ret_val = -IGC_ERR_NVM;
goto out;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr
2020-12-11 14:34 [PATCH] igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr Kevin Lo
@ 2020-12-12 22:00 ` Jakub Kicinski
2020-12-14 1:21 ` Kevin Lo
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2020-12-12 22:00 UTC (permalink / raw)
To: Kevin Lo; +Cc: Sasha Neftin, Jeff Kirsher, David S . Miller, netdev
On Fri, 11 Dec 2020 22:34:56 +0800 Kevin Lo wrote:
> This patch sets the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr.
> Without this change it wouldn't lead to a shadow RAM write EEWR timeout.
>
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>
This is a fix, please add a Fixes tag.
Please CC the maintainers:
M: Jesse Brandeburg <jesse.brandeburg@intel.com>
M: Tony Nguyen <anthony.l.nguyen@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr
2020-12-12 22:00 ` Jakub Kicinski
@ 2020-12-14 1:21 ` Kevin Lo
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Lo @ 2020-12-14 1:21 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: Sasha Neftin, Jeff Kirsher, David S . Miller, netdev
On Sat, Dec 12, 2020 at 02:00:10PM -0800, Jakub Kicinski wrote:
>
> On Fri, 11 Dec 2020 22:34:56 +0800 Kevin Lo wrote:
> > This patch sets the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr.
> > Without this change it wouldn't lead to a shadow RAM write EEWR timeout.
> >
> > Signed-off-by: Kevin Lo <kevlo@kevlo.org>
>
> This is a fix, please add a Fixes tag.
>
> Please CC the maintainers:
>
> M: Jesse Brandeburg <jesse.brandeburg@intel.com>
> M: Tony Nguyen <anthony.l.nguyen@intel.com>
I will update the Fixes tag and send V2, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-14 1:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-11 14:34 [PATCH] igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr Kevin Lo
2020-12-12 22:00 ` Jakub Kicinski
2020-12-14 1:21 ` Kevin Lo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.