[dlech-linux:bone-counter 3/21] drivers/counter/counter-chrdev.c:307:8-24: WARNING: counter_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.

[dlech-linux:bone-counter 3/21] drivers/counter/counter-chrdev.c:307:8-24: WARNING: counter_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

CC: kbuild-all(a)lists.01.org
TO: William Breathitt Gray <vilhelm.gray@gmail.com>
CC: David Lechner <david@lechnology.com>

tree:   https://github.com/dlech/linux bone-counter
head:   dc99d06b0f101cff0b3157b1cb49e28e95387c46
commit: d698926a635b0cf342b9b18e04b5f15701834158 [3/21] counter: Add character device interface
:::::: branch date: 2 hours ago
:::::: commit date: 6 hours ago
config: parisc-randconfig-c003-20201213 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/counter/counter-chrdev.c:307:8-24: WARNING: counter_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 21860 bytes --]

[PATCH] counter: fix stream_open.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]

CC: kbuild-all(a)lists.01.org
TO: William Breathitt Gray <vilhelm.gray@gmail.com>
CC: David Lechner <david@lechnology.com>
CC: linux-iio(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/counter/counter-chrdev.c:307:8-24: WARNING: counter_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.

Generated by: scripts/coccinelle/api/stream_open.cocci

Fixes: d698926a635b ("counter: Add character device interface")
CC: William Breathitt Gray <vilhelm.gray@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/dlech/linux bone-counter
head:   dc99d06b0f101cff0b3157b1cb49e28e95387c46
commit: d698926a635b0cf342b9b18e04b5f15701834158 [3/21] counter: Add character device interface
:::::: branch date: 2 hours ago
:::::: commit date: 6 hours ago

Please take the patch only if it's a positive warning. Thanks!

 counter-chrdev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/counter/counter-chrdev.c
+++ b/drivers/counter/counter-chrdev.c
@@ -304,7 +304,7 @@ static int counter_chrdev_open(struct in
 	get_device(&counter->dev);
 	filp->private_data = counter;
 
-	return nonseekable_open(inode, filp);
+	return stream_open(inode, filp);
 }
 
 static int counter_chrdev_release(struct inode *inode, struct file *filp)