* [PATCH v3 0/1] Add delay after the addressed reset command in mlx90632.c
@ 2020-12-14 20:42 Slaveyko Slaveykov
2020-12-14 20:42 ` [PATCH v3 1/1] drivers: iio: temperature: " Slaveyko Slaveykov
0 siblings, 1 reply; 2+ messages in thread
From: Slaveyko Slaveykov @ 2020-12-14 20:42 UTC (permalink / raw)
To: Jonathan.Cameron, cmo; +Cc: linux-iio, Slaveyko Slaveykov
Changed comment style for the delay line so that it matches the preferred
style for multi-line comments.
Slaveyko Slaveykov (1):
drivers: iio: temperature: Add delay after the addressed reset command
in mlx90632.c
drivers/iio/temperature/mlx90632.c | 6 ++++++
1 file changed, 6 insertions(+)
--
2.16.2.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v3 1/1] drivers: iio: temperature: Add delay after the addressed reset command in mlx90632.c
2020-12-14 20:42 [PATCH v3 0/1] Add delay after the addressed reset command in mlx90632.c Slaveyko Slaveykov
@ 2020-12-14 20:42 ` Slaveyko Slaveykov
0 siblings, 0 replies; 2+ messages in thread
From: Slaveyko Slaveykov @ 2020-12-14 20:42 UTC (permalink / raw)
To: Jonathan.Cameron, cmo; +Cc: linux-iio, Slaveyko Slaveykov
After an I2C reset command, the mlx90632 needs some time before
responding to other I2C commands. Without that delay, there is a chance
that the I2C command(s) after the reset will not be accepted
Signed-off-by: Slaveyko Slaveykov <sis@melexis.com>
---
drivers/iio/temperature/mlx90632.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c
index 503fe54a0bb9..872092c2fc61 100644
--- a/drivers/iio/temperature/mlx90632.c
+++ b/drivers/iio/temperature/mlx90632.c
@@ -248,6 +248,12 @@ static int mlx90632_set_meas_type(struct regmap *regmap, u8 type)
if (ret < 0)
return ret;
+/**
+ * give the mlx90632 some time to reset properly before sending a new I2C command
+ * if this is not done, the following I2C command(s) will not be accepted
+ */
+ usleep(150, 200);
+
ret = regmap_write_bits(regmap, MLX90632_REG_CONTROL,
(MLX90632_CFG_MTYP_MASK | MLX90632_CFG_PWR_MASK),
(MLX90632_MTYP_STATUS(type) | MLX90632_PWR_STATUS_HALT));
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-14 20:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-14 20:42 [PATCH v3 0/1] Add delay after the addressed reset command in mlx90632.c Slaveyko Slaveykov
2020-12-14 20:42 ` [PATCH v3 1/1] drivers: iio: temperature: " Slaveyko Slaveykov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.