[PATCH v4 0/1] Add delay after the addressed reset command in mlx90632.c

[PATCH v4 0/1] Add delay after the addressed reset command in mlx90632.c

[Slaveyko Slaveykov]

Using the appropriate usleep_range() and stylefixing based on the 
remarks made by Lars-Peter Clausen <lars@metafoo.de>

Slaveyko Slaveykov (1):
  drivers: iio: temperature: Add delay after the addressed reset command
    in mlx90632.c

 drivers/iio/temperature/mlx90632.c | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.16.2.windows.1

[PATCH v4 1/1] drivers: iio: temperature: Add delay after the addressed reset command in mlx90632.c

[Slaveyko Slaveykov]

After an I2C reset command, the mlx90632 needs some time before
responding to other I2C commands. Without that delay, there is a chance
that the I2C command(s) after the reset will not be accepted

Signed-off-by: Slaveyko Slaveykov <sis@melexis.com>
---
 drivers/iio/temperature/mlx90632.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c
index 503fe54a0bb9..474e6cd5b534 100644
--- a/drivers/iio/temperature/mlx90632.c
+++ b/drivers/iio/temperature/mlx90632.c
@@ -248,6 +248,12 @@ static int mlx90632_set_meas_type(struct regmap *regmap, u8 type)
 	if (ret < 0)
 		return ret;
 
+	/*
+	 * give the mlx90632 some time to reset properly before sending a new I2C command
+	 * if this is not done, the following I2C command(s) will not be accepted
+	 */
+	usleep_range(150, 200);
+
 	ret = regmap_write_bits(regmap, MLX90632_REG_CONTROL,
 				 (MLX90632_CFG_MTYP_MASK | MLX90632_CFG_PWR_MASK),
 				 (MLX90632_MTYP_STATUS(type) | MLX90632_PWR_STATUS_HALT));
-- 
2.16.2.windows.1

Re: [PATCH v4 1/1] drivers: iio: temperature: Add delay after the addressed reset command in mlx90632.c

[Andy Shevchenko]

On Tue, Dec 15, 2020 at 12:05 AM Slaveyko Slaveykov <sis@melexis.com> wrote:
>
> After an I2C reset command, the mlx90632 needs some time before
> responding to other I2C commands. Without that delay, there is a chance
> that the I2C command(s) after the reset will not be accepted

accepted -> accepted.

...

> +       /*
> +        * give the mlx90632 some time to reset properly before sending a new I2C command

give -> Give

> +        * if this is not done, the following I2C command(s) will not be accepted

accepted -> accepted.

> +        */
> +       usleep_range(150, 200);

After addressing above you can take my
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

-- 
With Best Regards,
Andy Shevchenko