* [PATCH] net: phy: fix kernel-doc for .config_intr()
@ 2020-12-15 8:37 Ioana Ciornei
2020-12-15 8:42 ` Ioana Ciornei
0 siblings, 1 reply; 3+ messages in thread
From: Ioana Ciornei @ 2020-12-15 8:37 UTC (permalink / raw)
To: davem, kuba, netdev; +Cc: sfr, linux-next, Ioana Ciornei
From: Ioana Ciornei <ioana.ciornei@nxp.com>
Fix the kernel-doc for .config_intr() so that we do not trigger a
warning like below.
include/linux/phy.h:869: warning: Function parameter or member 'config_intr' not described in 'phy_driver'
Fixes: 6527b938426f ("net: phy: remove the .did_interrupt() and .ack_interrupt() callback")
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
include/linux/phy.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 381a95732b6a..9effb511acde 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -743,7 +743,8 @@ struct phy_driver {
/** @read_status: Determines the negotiated speed and duplex */
int (*read_status)(struct phy_device *phydev);
- /** @config_intr: Enables or disables interrupts.
+ /**
+ * @config_intr: Enables or disables interrupts.
* It should also clear any pending interrupts prior to enabling the
* IRQs and after disabling them.
*/
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: fix kernel-doc for .config_intr()
2020-12-15 8:37 [PATCH] net: phy: fix kernel-doc for .config_intr() Ioana Ciornei
@ 2020-12-15 8:42 ` Ioana Ciornei
2020-12-15 18:09 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Ioana Ciornei @ 2020-12-15 8:42 UTC (permalink / raw)
To: Ioana Ciornei; +Cc: davem, kuba, netdev, sfr, linux-next, Ioana Ciornei
On Tue, Dec 15, 2020 at 10:37:51AM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei <ioana.ciornei@nxp.com>
>
> Fix the kernel-doc for .config_intr() so that we do not trigger a
> warning like below.
>
> include/linux/phy.h:869: warning: Function parameter or member 'config_intr' not described in 'phy_driver'
>
> Fixes: 6527b938426f ("net: phy: remove the .did_interrupt() and .ack_interrupt() callback")
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Sorry, I just realized that Jakub already sent a fix for this:
https://lore.kernel.org/netdev/20201215063750.3120976-1-kuba@kernel.org/
Ioana
> ---
> include/linux/phy.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 381a95732b6a..9effb511acde 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -743,7 +743,8 @@ struct phy_driver {
> /** @read_status: Determines the negotiated speed and duplex */
> int (*read_status)(struct phy_device *phydev);
>
> - /** @config_intr: Enables or disables interrupts.
> + /**
> + * @config_intr: Enables or disables interrupts.
> * It should also clear any pending interrupts prior to enabling the
> * IRQs and after disabling them.
> */
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: fix kernel-doc for .config_intr()
2020-12-15 8:42 ` Ioana Ciornei
@ 2020-12-15 18:09 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-12-15 18:09 UTC (permalink / raw)
To: Ioana Ciornei; +Cc: davem, netdev, sfr, linux-next, Ioana Ciornei
On Tue, 15 Dec 2020 10:42:40 +0200 Ioana Ciornei wrote:
> On Tue, Dec 15, 2020 at 10:37:51AM +0200, Ioana Ciornei wrote:
> > From: Ioana Ciornei <ioana.ciornei@nxp.com>
> >
> > Fix the kernel-doc for .config_intr() so that we do not trigger a
> > warning like below.
> >
> > include/linux/phy.h:869: warning: Function parameter or member 'config_intr' not described in 'phy_driver'
> >
> > Fixes: 6527b938426f ("net: phy: remove the .did_interrupt() and .ack_interrupt() callback")
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
>
> Sorry, I just realized that Jakub already sent a fix for this:
>
> https://lore.kernel.org/netdev/20201215063750.3120976-1-kuba@kernel.org/
Bad timing :) Sorry for not CCing you
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-15 18:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-15 8:37 [PATCH] net: phy: fix kernel-doc for .config_intr() Ioana Ciornei
2020-12-15 8:42 ` Ioana Ciornei
2020-12-15 18:09 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.