[dunfell/master PATCH] trusted-firmware-a: Update SRCREV to pick latest

[dunfell/master PATCH] trusted-firmware-a: Update SRCREV to pick latest

[praneeth]

From: Praneeth Bajjuri <praneeth@ti.com>

Update SRCREV to pick latest that includes AM64 support

Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
---
 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
index 3ca4a204..7821ed3a 100644
--- a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
+++ b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
@@ -2,7 +2,7 @@ PV_k3 = "2.4"
 LIC_FILES_CHKSUM_k3 = "file://license.rst;md5=1dd070c98a281d18d9eefd938729b031"
 BRANCH_k3 = "ti-atf"
 SRC_URI_k3 = "git://git.ti.com/atf/arm-trusted-firmware.git;branch=${BRANCH};name=tfa"
-SRCREV_tfa_k3 = "f0a310d000fd6e8a1ed0ccc365b5931390393db1"
+SRCREV_tfa_k3 = "65dd16b4ea5032752af62e94ca64cff41733a123"
 COMPATIBLE_MACHINE_k3 = "k3"
 TFA_BUILD_TARGET_k3 = "all"
 TFA_INSTALL_TARGET_k3 = "bl31"
-- 
2.17.1

Re: [dunfell/master PATCH] trusted-firmware-a: Update SRCREV to pick latest

[Suman Anna]

Hi Praneeth,

On 12/12/20 3:23 PM, praneeth@ti.com wrote:
> From: Praneeth Bajjuri <praneeth@ti.com>
> 
> Update SRCREV to pick latest that includes AM64 support

This by itself will not be enough for AM64, but that can be an add-on patch.
Need to account for TARGET_BOARD=lite for AM64x.

regards
Suman

> 
> Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
> ---
>  recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
> index 3ca4a204..7821ed3a 100644
> --- a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
> +++ b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
> @@ -2,7 +2,7 @@ PV_k3 = "2.4"
>  LIC_FILES_CHKSUM_k3 = "file://license.rst;md5=1dd070c98a281d18d9eefd938729b031"
>  BRANCH_k3 = "ti-atf"
>  SRC_URI_k3 = "git://git.ti.com/atf/arm-trusted-firmware.git;branch=${BRANCH};name=tfa"
> -SRCREV_tfa_k3 = "f0a310d000fd6e8a1ed0ccc365b5931390393db1"
> +SRCREV_tfa_k3 = "65dd16b4ea5032752af62e94ca64cff41733a123"
>  COMPATIBLE_MACHINE_k3 = "k3"
>  TFA_BUILD_TARGET_k3 = "all"
>  TFA_INSTALL_TARGET_k3 = "bl31"
> 

Re: [dunfell/master PATCH] trusted-firmware-a: Update SRCREV to pick latest

[Dan Murphy]

Hello

On 12/12/20 4:09 PM, Suman Anna wrote:
> Hi Praneeth,
>
> On 12/12/20 3:23 PM, praneeth@ti.com wrote:
>> From: Praneeth Bajjuri <praneeth@ti.com>
>>
>> Update SRCREV to pick latest that includes AM64 support
> This by itself will not be enough for AM64, but that can be an add-on patch.
> Need to account for TARGET_BOARD=lite for AM64x.

Is this something that needs to be added to the recipe.  To be honest I 
have not yet reviewed the ATF patches to know

Dan

[dunfell/master PATCH V2] trusted-firmware-a: Update SRCREV to pick latest

[praneeth]

From: Praneeth Bajjuri <praneeth@ti.com>

Update SRCREV to pick latest that includes AM64 support

Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
---
 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
index 4942bf46..39ef1171 100644
--- a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
+++ b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
@@ -2,11 +2,12 @@ PV_k3 = "2.4"
 LIC_FILES_CHKSUM_k3 = "file://license.rst;md5=1dd070c98a281d18d9eefd938729b031"
 BRANCH_k3 = "ti-atf"
 SRC_URI_k3 = "git://git.ti.com/atf/arm-trusted-firmware.git;branch=${BRANCH};name=tfa"
-SRCREV_tfa_k3 = "f0a310d000fd6e8a1ed0ccc365b5931390393db1"
+SRCREV_tfa_k3 = "65dd16b4ea5032752af62e94ca64cff41733a123"
 COMPATIBLE_MACHINE_k3 = "k3"
 TFA_BUILD_TARGET_k3 = "all"
 TFA_INSTALL_TARGET_k3 = "bl31"
 TFA_SPD_k3 = "opteed"
+TFA_BOARD_am64xx-evm = "lite"
 
 do_compile_append_am65xx-hs-evm() {
 	export TI_SECURE_DEV_PKG=${TI_SECURE_DEV_PKG}
-- 
2.17.1

Re: [dunfell/master PATCH V2] trusted-firmware-a: Update SRCREV to pick latest

[Dan Murphy]

Praneeth

On 12/15/20 2:51 PM, praneeth@ti.com wrote:
> From: Praneeth Bajjuri <praneeth@ti.com>
>
> Update SRCREV to pick latest that includes AM64 support

You are doing just a bit more then this.  What is the "lite" for now?

Dan

Re: [dunfell/master PATCH V2] trusted-firmware-a: Update SRCREV to pick latest

[praneeth]

On 12/15/2020 2:53 PM, Dan Murphy wrote:
> Praneeth
> 
> On 12/15/20 2:51 PM, praneeth@ti.com wrote:
>> From: Praneeth Bajjuri <praneeth@ti.com>
>>
>> Update SRCREV to pick latest that includes AM64 support
> 
> You are doing just a bit more then this.  What is the "lite" for now?

Thats the new target name for AM64

Ref: 
https://git.ti.com/cgit/atf/arm-trusted-firmware/commit/?h=ti-atf&id=65dd16b4ea5032752af62e94ca64cff41733a123 


TARGET_BOARD=lite for AM64
TARGET_BOARD=generic (default for other devices)
defined at conf/machine/include/k3.inc


> 
> Dan
> 

Re: [dunfell/master PATCH V2] trusted-firmware-a: Update SRCREV to pick latest

[Dan Murphy]

Praneeth

On 12/15/20 2:59 PM, Bajjuri, Praneeth wrote:
>
>
> On 12/15/2020 2:53 PM, Dan Murphy wrote:
>> Praneeth
>>
>> On 12/15/20 2:51 PM, praneeth@ti.com wrote:
>>> From: Praneeth Bajjuri <praneeth@ti.com>
>>>
>>> Update SRCREV to pick latest that includes AM64 support
>>
>> You are doing just a bit more then this.  What is the "lite" for now?
>
> Thats the new target name for AM64
>
> Ref: 
> https://git.ti.com/cgit/atf/arm-trusted-firmware/commit/?h=ti-atf&id=65dd16b4ea5032752af62e94ca64cff41733a123 
>
>
> TARGET_BOARD=lite for AM64
> TARGET_BOARD=generic (default for other devices)
> defined at conf/machine/include/k3.inc
>
Thanks.  Now if we can just get that in the commit message except for 
the URL target

Dan

[dunfell/master PATCH V3] trusted-firmware-a: Update SRCREV for AM64X support

[praneeth]

From: Praneeth Bajjuri <praneeth@ti.com>

Update SRCREV to pick latest that includes AM64X support

commit 65dd16b4e ("ti: k3: Introduce lite device board support")
adds support of AM64X platform in ti-atf branch.

This patch updates the SRCREV and also updates the BOARD to "lite" to
build for the mentioned platform.

Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
---
Changes since V2:
- Update commit message adding more details on new platform

Changes since V1:
- Update TFA_BOARD target name for AM64 as "lite"

 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
index 3ca4a204..a7ca43c3 100644
--- a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
+++ b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
@@ -2,11 +2,12 @@ PV_k3 = "2.4"
 LIC_FILES_CHKSUM_k3 = "file://license.rst;md5=1dd070c98a281d18d9eefd938729b031"
 BRANCH_k3 = "ti-atf"
 SRC_URI_k3 = "git://git.ti.com/atf/arm-trusted-firmware.git;branch=${BRANCH};name=tfa"
-SRCREV_tfa_k3 = "f0a310d000fd6e8a1ed0ccc365b5931390393db1"
+SRCREV_tfa_k3 = "65dd16b4ea5032752af62e94ca64cff41733a123"
 COMPATIBLE_MACHINE_k3 = "k3"
 TFA_BUILD_TARGET_k3 = "all"
 TFA_INSTALL_TARGET_k3 = "bl31"
 TFA_SPD_k3 = "opteed"
+TFA_BOARD_am64xx-evm = "lite"
 
 do_compile_append_am65xx-hs-evm() {
 	export TI_SECURE_DEV_PKG=${TI_SECURE_DEV_PKG}
-- 
2.17.1

Re: [meta-ti] [dunfell/master PATCH V2] trusted-firmware-a: Update SRCREV to pick latest

[Denys Dmytriyenko]

On Tue, Dec 15, 2020 at 03:04:16PM -0600, Dan Murphy via lists.yoctoproject.org wrote:
> Praneeth
> 
> On 12/15/20 2:59 PM, Bajjuri, Praneeth wrote:
> >
> >
> >On 12/15/2020 2:53 PM, Dan Murphy wrote:
> >>Praneeth
> >>
> >>On 12/15/20 2:51 PM, praneeth@ti.com wrote:
> >>>From: Praneeth Bajjuri <praneeth@ti.com>
> >>>
> >>>Update SRCREV to pick latest that includes AM64 support
> >>
> >>You are doing just a bit more then this.  What is the "lite" for now?
> >
> >Thats the new target name for AM64
> >
> >Ref: https://git.ti.com/cgit/atf/arm-trusted-firmware/commit/?h=ti-atf&id=65dd16b4ea5032752af62e94ca64cff41733a123
> >
> >
> >TARGET_BOARD=lite for AM64
> >TARGET_BOARD=generic (default for other devices)
> >defined at conf/machine/include/k3.inc
> >
> Thanks.  Now if we can just get that in the commit message except
> for the URL target

Probably better to set TFA_BOARD = "lite" in the corresponding am64xx-evm.conf 
machine config...

-- 
Denys

Re: [meta-ti] [dunfell/master PATCH V2] trusted-firmware-a: Update SRCREV to pick latest

[praneeth]

On 12/15/2020 3:29 PM, Denys Dmytriyenko wrote:
> On Tue, Dec 15, 2020 at 03:04:16PM -0600, Dan Murphy via lists.yoctoproject.org wrote:
>> Praneeth
>>
>> On 12/15/20 2:59 PM, Bajjuri, Praneeth wrote:
>>>
>>>
>>> On 12/15/2020 2:53 PM, Dan Murphy wrote:
>>>> Praneeth
>>>>
>>>> On 12/15/20 2:51 PM, praneeth@ti.com wrote:
>>>>> From: Praneeth Bajjuri <praneeth@ti.com>
>>>>>
>>>>> Update SRCREV to pick latest that includes AM64 support
>>>>
>>>> You are doing just a bit more then this.  What is the "lite" for now?
>>>
>>> Thats the new target name for AM64
>>>
>>> Ref: https://git.ti.com/cgit/atf/arm-trusted-firmware/commit/?h=ti-atf&id=65dd16b4ea5032752af62e94ca64cff41733a123
>>>
>>>
>>> TARGET_BOARD=lite for AM64
>>> TARGET_BOARD=generic (default for other devices)
>>> defined at conf/machine/include/k3.inc
>>>
>> Thanks.  Now if we can just get that in the commit message except
>> for the URL target
> 
> Probably better to set TFA_BOARD = "lite" in the corresponding am64xx-evm.conf
> machine config...

Can i move it to conf/machine/include/am64xx.inc instead ? please advise.

Will submit v4 accordingly


> 

Re: [meta-ti] [dunfell/master PATCH V2] trusted-firmware-a: Update SRCREV to pick latest

[Dan Murphy]

Praneeth

On 12/15/20 4:07 PM, Bajjuri, Praneeth wrote:
>
>
> On 12/15/2020 3:29 PM, Denys Dmytriyenko wrote:
>> On Tue, Dec 15, 2020 at 03:04:16PM -0600, Dan Murphy via 
>> lists.yoctoproject.org wrote:
>>> Praneeth
>>>
>>> On 12/15/20 2:59 PM, Bajjuri, Praneeth wrote:
>>>>
>>>>
>>>> On 12/15/2020 2:53 PM, Dan Murphy wrote:
>>>>> Praneeth
>>>>>
>>>>> On 12/15/20 2:51 PM, praneeth@ti.com wrote:
>>>>>> From: Praneeth Bajjuri <praneeth@ti.com>
>>>>>>
>>>>>> Update SRCREV to pick latest that includes AM64 support
>>>>>
>>>>> You are doing just a bit more then this.  What is the "lite" for now?
>>>>
>>>> Thats the new target name for AM64
>>>>
>>>> Ref: 
>>>> https://git.ti.com/cgit/atf/arm-trusted-firmware/commit/?h=ti-atf&id=65dd16b4ea5032752af62e94ca64cff41733a123
>>>>
>>>>
>>>> TARGET_BOARD=lite for AM64
>>>> TARGET_BOARD=generic (default for other devices)
>>>> defined at conf/machine/include/k3.inc
>>>>
>>> Thanks.  Now if we can just get that in the commit message except
>>> for the URL target
>>
>> Probably better to set TFA_BOARD = "lite" in the corresponding 
>> am64xx-evm.conf
>> machine config...
>
> Can i move it to conf/machine/include/am64xx.inc instead ? please advise.
>
> Will submit v4 accordingly
>
If it is common for all/any am64 processors then it belong in that 
include file

Dan

Re: [meta-ti] [dunfell/master PATCH V2] trusted-firmware-a: Update SRCREV to pick latest

[Denys Dmytriyenko]

On Tue, Dec 15, 2020 at 04:07:47PM -0600, Bajjuri, Praneeth wrote:
> 
> 
> On 12/15/2020 3:29 PM, Denys Dmytriyenko wrote:
> >On Tue, Dec 15, 2020 at 03:04:16PM -0600, Dan Murphy via lists.yoctoproject.org wrote:
> >>Praneeth
> >>
> >>On 12/15/20 2:59 PM, Bajjuri, Praneeth wrote:
> >>>
> >>>
> >>>On 12/15/2020 2:53 PM, Dan Murphy wrote:
> >>>>Praneeth
> >>>>
> >>>>On 12/15/20 2:51 PM, praneeth@ti.com wrote:
> >>>>>From: Praneeth Bajjuri <praneeth@ti.com>
> >>>>>
> >>>>>Update SRCREV to pick latest that includes AM64 support
> >>>>
> >>>>You are doing just a bit more then this.  What is the "lite" for now?
> >>>
> >>>Thats the new target name for AM64
> >>>
> >>>Ref: https://git.ti.com/cgit/atf/arm-trusted-firmware/commit/?h=ti-atf&id=65dd16b4ea5032752af62e94ca64cff41733a123
> >>>
> >>>
> >>>TARGET_BOARD=lite for AM64
> >>>TARGET_BOARD=generic (default for other devices)
> >>>defined at conf/machine/include/k3.inc
> >>>
> >>Thanks.  Now if we can just get that in the commit message except
> >>for the URL target
> >
> >Probably better to set TFA_BOARD = "lite" in the corresponding am64xx-evm.conf
> >machine config...
> 
> Can i move it to conf/machine/include/am64xx.inc instead ? please advise.
> 
> Will submit v4 accordingly

Sure, am64xx.inc should be fine, even better for when/if possible HS or any 
other variants in the same SoC family come out.

-- 
Denys

[dunfell/master PATCH V4] trusted-firmware-a: Update SRCREV for AM64X support

[praneeth]

From: Praneeth Bajjuri <praneeth@ti.com>

Update SRCREV to pick latest that includes AM64X support

commit 65dd16b4e ("ti: k3: Introduce lite device board support")
adds support of AM64X platform in ti-atf branch.

This patch updates the SRCREV and also updates the BOARD to "lite" to
build for the mentioned platform.

Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
---
Changes since V3:
- moved TFA_BOARD definition to am64xx.inc
 
Changes since V2:
- Update commit message adding more details on new platform

Changes since V1:
- Update TFA_BOARD target name for AM64 as "lite"

 conf/machine/include/am64xx.inc                              | 1 +
 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/conf/machine/include/am64xx.inc b/conf/machine/include/am64xx.inc
index 79a403a9..99d573e8 100644
--- a/conf/machine/include/am64xx.inc
+++ b/conf/machine/include/am64xx.inc
@@ -12,6 +12,7 @@ KERNEL_DEVICETREE = " \
 
 #IMAGE_BOOT_FILES += "sysfw-am64x-evm.itb"
 
+TFA_BOARD_am64xx-evm = "lite"
 OPTEEMACHINE = "k3-am65x"
 OPTEEOUTPUTMACHINE = "k3"
 
diff --git a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
index 4942bf46..4852c560 100644
--- a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
+++ b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
@@ -2,7 +2,7 @@ PV_k3 = "2.4"
 LIC_FILES_CHKSUM_k3 = "file://license.rst;md5=1dd070c98a281d18d9eefd938729b031"
 BRANCH_k3 = "ti-atf"
 SRC_URI_k3 = "git://git.ti.com/atf/arm-trusted-firmware.git;branch=${BRANCH};name=tfa"
-SRCREV_tfa_k3 = "f0a310d000fd6e8a1ed0ccc365b5931390393db1"
+SRCREV_tfa_k3 = "65dd16b4ea5032752af62e94ca64cff41733a123"
 COMPATIBLE_MACHINE_k3 = "k3"
 TFA_BUILD_TARGET_k3 = "all"
 TFA_INSTALL_TARGET_k3 = "bl31"
-- 
2.17.1

Re: [dunfell/master PATCH V4] trusted-firmware-a: Update SRCREV for AM64X support

[Denys Dmytriyenko]

On Tue, Dec 15, 2020 at 04:20:29PM -0600, praneeth@ti.com wrote:
> From: Praneeth Bajjuri <praneeth@ti.com>
> 
> Update SRCREV to pick latest that includes AM64X support
> 
> commit 65dd16b4e ("ti: k3: Introduce lite device board support")
> adds support of AM64X platform in ti-atf branch.
> 
> This patch updates the SRCREV and also updates the BOARD to "lite" to
> build for the mentioned platform.
> 
> Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
> ---
> Changes since V3:
> - moved TFA_BOARD definition to am64xx.inc
>  
> Changes since V2:
> - Update commit message adding more details on new platform
> 
> Changes since V1:
> - Update TFA_BOARD target name for AM64 as "lite"
> 
>  conf/machine/include/am64xx.inc                              | 1 +
>  recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/conf/machine/include/am64xx.inc b/conf/machine/include/am64xx.inc
> index 79a403a9..99d573e8 100644
> --- a/conf/machine/include/am64xx.inc
> +++ b/conf/machine/include/am64xx.inc
> @@ -12,6 +12,7 @@ KERNEL_DEVICETREE = " \
>  
>  #IMAGE_BOOT_FILES += "sysfw-am64x-evm.itb"
>  
> +TFA_BOARD_am64xx-evm = "lite"

Copy/paste error - doesn't need a machine override here:

TFA_BOARD = "lite"


>  OPTEEMACHINE = "k3-am65x"
>  OPTEEOUTPUTMACHINE = "k3"
>  
> diff --git a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
> index 4942bf46..4852c560 100644
> --- a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
> +++ b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
> @@ -2,7 +2,7 @@ PV_k3 = "2.4"
>  LIC_FILES_CHKSUM_k3 = "file://license.rst;md5=1dd070c98a281d18d9eefd938729b031"
>  BRANCH_k3 = "ti-atf"
>  SRC_URI_k3 = "git://git.ti.com/atf/arm-trusted-firmware.git;branch=${BRANCH};name=tfa"
> -SRCREV_tfa_k3 = "f0a310d000fd6e8a1ed0ccc365b5931390393db1"
> +SRCREV_tfa_k3 = "65dd16b4ea5032752af62e94ca64cff41733a123"
>  COMPATIBLE_MACHINE_k3 = "k3"
>  TFA_BUILD_TARGET_k3 = "all"
>  TFA_INSTALL_TARGET_k3 = "bl31"
> -- 
> 2.17.1
> 

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964