* [PATCH] rt-tests: determine_maximum_mpps.sh: Change the -c option to -a
@ 2020-12-16 7:16 John Kacur
2020-12-16 8:14 ` Daniel Wagner
0 siblings, 1 reply; 2+ messages in thread
From: John Kacur @ 2020-12-16 7:16 UTC (permalink / raw)
To: Daniel Wagner; +Cc: Clark Williams, Marcelo Tosatti, RT, John Kacur
Change -c to -a so that the options in this program match the options
of the other programs in the rt-tests suite as much as possible
Signed-off-by: John Kacur <jkacur@redhat.com>
---
src/queuelat/determine_maximum_mpps.8 | 8 +++++---
src/queuelat/determine_maximum_mpps.sh | 4 ++--
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/queuelat/determine_maximum_mpps.8 b/src/queuelat/determine_maximum_mpps.8
index 4a28f1a4e34a..c48a651160d3 100644
--- a/src/queuelat/determine_maximum_mpps.8
+++ b/src/queuelat/determine_maximum_mpps.8
@@ -16,7 +16,7 @@
determine_maximum_mpps \- Determine the maximum mpps the machine can handle
.SH SYNOPSIS
.LP
-determine_maximum_mpps [-c cpulist] [-m maxlat] [-n cycles] [-f | -r] [-p priority] [-h]
+determine_maximum_mpps [-a cpulist] [-m maxlat] [-n cycles] [-f | -r] [-p priority] [-h]
.SH DESCRIPTION
determine_maximum_mpps will find the maximum mpps parameter which can sustain
.PP
@@ -33,11 +33,13 @@ mpps : million-packets-per-second
.br
.SH OPTIONS
.TP
-.B \-c cpulist
+.B \-a cpulist
List of processors to run on. The default is processor 0
+.br
+Numbers are separated by commas and may include ranges. Eg. 0,3,7\-11
.TP
.B \-m maxlat
-Maximum latency in nanoseconds. The default is 20000. if the maximum is exceeded, that run of queuelat quits.
+Maximum latency in nanoseconds. The default is 20000. If the maximum is exceeded, that run of queuelat quits.
.TP
.B \-n cycles
Extimated number of cycles it takes to process one packet. The default is 300
diff --git a/src/queuelat/determine_maximum_mpps.sh b/src/queuelat/determine_maximum_mpps.sh
index fdede472728c..86fffd8bb617 100755
--- a/src/queuelat/determine_maximum_mpps.sh
+++ b/src/queuelat/determine_maximum_mpps.sh
@@ -56,9 +56,9 @@ check_sched()
}
# Process command line options
-while getopts ":c:frp:m:n:h" opt; do
+while getopts ":a:frp:m:n:h" opt; do
case ${opt} in
- c ) CPULIST="${OPTARG}" ;;
+ a ) CPULIST="${OPTARG}" ;;
m ) MAXLAT="${OPTARG}" ;;
n ) CYCLES_PER_PACKET="${OPTARG}" ;;
f ) check_sched; SCHED="-f" ;;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rt-tests: determine_maximum_mpps.sh: Change the -c option to -a
2020-12-16 7:16 [PATCH] rt-tests: determine_maximum_mpps.sh: Change the -c option to -a John Kacur
@ 2020-12-16 8:14 ` Daniel Wagner
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Wagner @ 2020-12-16 8:14 UTC (permalink / raw)
To: John Kacur; +Cc: Clark Williams, Marcelo Tosatti, RT
On Wed, Dec 16, 2020 at 02:16:42AM -0500, John Kacur wrote:
> Change -c to -a so that the options in this program match the options
> of the other programs in the rt-tests suite as much as possible
>
> Signed-off-by: John Kacur <jkacur@redhat.com>
Thanks
Reviewed-by: Daniel Wagner <dwagner@suse.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-16 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16 7:16 [PATCH] rt-tests: determine_maximum_mpps.sh: Change the -c option to -a John Kacur
2020-12-16 8:14 ` Daniel Wagner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.