[PATCH rdma-core] librdmacm: Make rdma_create_qp_ex() report proper errno

[PATCH rdma-core] librdmacm: Make rdma_create_qp_ex() report proper errno

[Xiao Yang]

Current rdma_create_qp_ex() reports fixed ENOMEM when calling
ibv_create_qp_ex() fails, so it's hard for user to know which
actual error happens on ibv_create_qp_ex().

Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
 librdmacm/cma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/librdmacm/cma.c b/librdmacm/cma.c
index 8c820ccf..20ee1e00 100644
--- a/librdmacm/cma.c
+++ b/librdmacm/cma.c
@@ -1662,7 +1662,7 @@ int rdma_create_qp_ex(struct rdma_cm_id *id,
 		attr->srq = id->srq;
 	qp = ibv_create_qp_ex(id->verbs, attr);
 	if (!qp) {
-		ret = ERR(ENOMEM);
+		ret = -1;
 		goto err1;
 	}
 
-- 
2.25.1

Re: [PATCH rdma-core] librdmacm: Make rdma_create_qp_ex() report proper errno

[Leon Romanovsky]

On Wed, Dec 16, 2020 at 09:54:59AM +0800, Xiao Yang wrote:
> Current rdma_create_qp_ex() reports fixed ENOMEM when calling
> ibv_create_qp_ex() fails, so it's hard for user to know which
> actual error happens on ibv_create_qp_ex().
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
>  librdmacm/cma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The same change should be done for the ibv_alloc_pd() call.

   635         if (!cma_dev->pd)
   636                 cma_dev->pd = ibv_alloc_pd(cma_dev->verbs);
   637         if (!cma_dev->pd) {
   638                 ret = ERR(ENOMEM);
   639                 goto out;
   640         }


And please add Fixes line.

Thanks