[PATCH v5 0/1] Add delay after the addressed reset command in mlx90632.c

[PATCH v5 0/1] Add delay after the addressed reset command in mlx90632.c

[Slaveyko Slaveykov]

The MLX90632 needs some time to reset properly after an I2C addressed reset
command. Thus a delay is added in the mlx90632.c.

v2 adds comments as advised by Andy Shevchenko.

v3 changes the comments style so that it matches the preferred style
for multi-line comments as suggested by Lars-Peter Clausen.

v4 fixes the comments style and it uses the appropriate usleep_range() 
as suggested by Lars-Peter Clausen.

v5 Commit message and comments stylefixing as suggested by 
Andy Shevchenko.

Slaveyko Slaveykov (1):
  drivers: iio: temperature: Add delay after the addressed reset command
    in mlx90632.c

 drivers/iio/temperature/mlx90632.c | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.16.2.windows.1

[PATCH v5 1/1] drivers: iio: temperature: Add delay after the addressed reset command in mlx90632.c

[Slaveyko Slaveykov]

After an I2C reset command, the mlx90632 needs some time before
responding to other I2C commands. Without that delay, there is a chance
that the I2C command(s) after the reset will not be accepted.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Crt Mori <cmo@melexis.com>
Signed-off-by: Slaveyko Slaveykov <sis@melexis.com>
---
 drivers/iio/temperature/mlx90632.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c
index 503fe54a0bb9..608ccb1d8bc8 100644
--- a/drivers/iio/temperature/mlx90632.c
+++ b/drivers/iio/temperature/mlx90632.c
@@ -248,6 +248,12 @@ static int mlx90632_set_meas_type(struct regmap *regmap, u8 type)
 	if (ret < 0)
 		return ret;
 
+	/*
+	 * Give the mlx90632 some time to reset properly before sending a new I2C command
+	 * if this is not done, the following I2C command(s) will not be accepted.
+	 */
+	usleep_range(150, 200);
+
 	ret = regmap_write_bits(regmap, MLX90632_REG_CONTROL,
 				 (MLX90632_CFG_MTYP_MASK | MLX90632_CFG_PWR_MASK),
 				 (MLX90632_MTYP_STATUS(type) | MLX90632_PWR_STATUS_HALT));
-- 
2.16.2.windows.1

Re: [PATCH v5 0/1] Add delay after the addressed reset command in mlx90632.c

[Andy Shevchenko]

On Wed, Dec 16, 2020 at 1:58 PM Slaveyko Slaveykov <sis@melexis.com> wrote:
>
> The MLX90632 needs some time to reset properly after an I2C addressed reset
> command. Thus a delay is added in the mlx90632.c.
>
> v2 adds comments as advised by Andy Shevchenko.
>
> v3 changes the comments style so that it matches the preferred style
> for multi-line comments as suggested by Lars-Peter Clausen.
>
> v4 fixes the comments style and it uses the appropriate usleep_range()
> as suggested by Lars-Peter Clausen.
>
> v5 Commit message and comments stylefixing as suggested by
> Andy Shevchenko.

LGTM, thanks!
For the future it's not necessary to have a cover letter for a single patch.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v5 1/1] drivers: iio: temperature: Add delay after the addressed reset command in mlx90632.c

[Jonathan Cameron]

On Wed, 16 Dec 2020 13:57:20 +0200
Slaveyko Slaveykov <sis@melexis.com> wrote:

> After an I2C reset command, the mlx90632 needs some time before
> responding to other I2C commands. Without that delay, there is a chance
> that the I2C command(s) after the reset will not be accepted.
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Reviewed-by: Crt Mori <cmo@melexis.com>
> Signed-off-by: Slaveyko Slaveykov <sis@melexis.com>

Note that this should have had a fixes tag so we know where to apply it whilst
backporting.  I took a look and ended up adding:
Fixes: e02472f74a81 ("iio:temperature:mlx90632: Adding extended calibration option")

Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

> ---
>  drivers/iio/temperature/mlx90632.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c
> index 503fe54a0bb9..608ccb1d8bc8 100644
> --- a/drivers/iio/temperature/mlx90632.c
> +++ b/drivers/iio/temperature/mlx90632.c
> @@ -248,6 +248,12 @@ static int mlx90632_set_meas_type(struct regmap *regmap, u8 type)
>  	if (ret < 0)
>  		return ret;
>  
> +	/*
> +	 * Give the mlx90632 some time to reset properly before sending a new I2C command
> +	 * if this is not done, the following I2C command(s) will not be accepted.
> +	 */
> +	usleep_range(150, 200);
> +
>  	ret = regmap_write_bits(regmap, MLX90632_REG_CONTROL,
>  				 (MLX90632_CFG_MTYP_MASK | MLX90632_CFG_PWR_MASK),
>  				 (MLX90632_MTYP_STATUS(type) | MLX90632_PWR_STATUS_HALT));