* [PATCH v1 2/4] Bluetooth: btqca: Enable MSFT extension for Qualcomm WCN399x
2020-12-17 7:17 [PATCH v1 1/4] Bluetooth: Keep MSFT extension info throughout a hci_dev's life cycle Miao-chen Chou
@ 2020-12-17 7:17 ` Miao-chen Chou
2020-12-17 7:17 ` [PATCH v1 3/4] Bluetooth: btusb: Enable MSFT extension for Intel controllers Miao-chen Chou
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Miao-chen Chou @ 2020-12-17 7:17 UTC (permalink / raw)
To: Bluetooth Kernel Mailing List
Cc: Alain Michaud, Archie Pusaka, Marcel Holtmann,
Luiz Augusto von Dentz, Miao-chen Chou, Abhishek Pandit-Subedi,
Johan Hedberg, Luiz Augusto von Dentz, linux-kernel
The following Qualcomm WCN399x Bluetooth controllers support the
Microsoft vendor extension and they are using 0xFD70 for VsMsftOpCode.
-WCN3990
-WCN3991
-WCN3998
< HCI Command: ogf 0x3f, ocf 0x0170, plen 1
00
> HCI Event: 0x0e plen 18
01 70 FD 00 00 1F 00 00 00 00 00 00 00 04 4D 53 46 54
The following test step was performed.
- Boot the device with WCN3991 and verify INFO print in dmesg.
Signed-off-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Reviewed-by: Archie Pusaka <apusaka@chromium.org>
---
drivers/bluetooth/btqca.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index f85a55add9be5..ab19963c83616 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -517,6 +517,19 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate,
return err;
}
+ /* WCN399x supports the Microsoft vendor extension with 0xFD70 as the
+ * VsMsftOpCode.
+ */
+ switch (soc_type) {
+ case QCA_WCN3990:
+ case QCA_WCN3991:
+ case QCA_WCN3998:
+ hci_set_msft_opcode(hdev, 0xFD70);
+ break;
+ default:
+ break;
+ }
+
/* Perform HCI reset */
err = qca_send_reset(hdev);
if (err < 0) {
--
2.29.2.684.gfbc64c5ab5-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v1 3/4] Bluetooth: btusb: Enable MSFT extension for Intel controllers
2020-12-17 7:17 [PATCH v1 1/4] Bluetooth: Keep MSFT extension info throughout a hci_dev's life cycle Miao-chen Chou
2020-12-17 7:17 ` [PATCH v1 2/4] Bluetooth: btqca: Enable MSFT extension for Qualcomm WCN399x Miao-chen Chou
@ 2020-12-17 7:17 ` Miao-chen Chou
2020-12-17 7:17 ` [PATCH v1 4/4] Bluetooth: btrtl: Enable MSFT extension for RTL8822CE controller Miao-chen Chou
2020-12-17 8:12 ` [v1,1/4] Bluetooth: Keep MSFT extension info throughout a hci_dev's life cycle bluez.test.bot
3 siblings, 0 replies; 5+ messages in thread
From: Miao-chen Chou @ 2020-12-17 7:17 UTC (permalink / raw)
To: Bluetooth Kernel Mailing List
Cc: Alain Michaud, Archie Pusaka, Marcel Holtmann,
Luiz Augusto von Dentz, Miao-chen Chou, Abhishek Pandit-Subedi,
Johan Hedberg, Luiz Augusto von Dentz, linux-kernel
The Intel JeffersonPeak, HarrisonPeak and CyclonePeak Bluetooth
controllers support the Microsoft vendor extension and they are using
0xFC1E for VsMsftOpCode.
< HCI Command: Vendor (0x3f|0x001e) plen 1
00
> HCI Event: Command Complete (0x0e) plen 15
Vendor (0x3f|0x001e) ncmd 1
Status: Success (0x00)
00 3f 00 00 00 00 00 00 00 01 50
The following test step was performed.
- Boot the test devices with HarrisonPeak and verify INFO print in
dmesg.
Signed-off-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Reviewed-by: Archie Pusaka <apusaka@chromium.org>
---
drivers/bluetooth/btusb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 03b83aa912779..25cfa47995a8a 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2924,7 +2924,10 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
* extension are using 0xFC1E for VsMsftOpCode.
*/
switch (ver.hw_variant) {
+ case 0x11: /* JfP */
case 0x12: /* ThP */
+ case 0x13: /* HrP */
+ case 0x14: /* CcP */
hci_set_msft_opcode(hdev, 0xFC1E);
break;
}
--
2.29.2.684.gfbc64c5ab5-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v1 4/4] Bluetooth: btrtl: Enable MSFT extension for RTL8822CE controller
2020-12-17 7:17 [PATCH v1 1/4] Bluetooth: Keep MSFT extension info throughout a hci_dev's life cycle Miao-chen Chou
2020-12-17 7:17 ` [PATCH v1 2/4] Bluetooth: btqca: Enable MSFT extension for Qualcomm WCN399x Miao-chen Chou
2020-12-17 7:17 ` [PATCH v1 3/4] Bluetooth: btusb: Enable MSFT extension for Intel controllers Miao-chen Chou
@ 2020-12-17 7:17 ` Miao-chen Chou
2020-12-17 8:12 ` [v1,1/4] Bluetooth: Keep MSFT extension info throughout a hci_dev's life cycle bluez.test.bot
3 siblings, 0 replies; 5+ messages in thread
From: Miao-chen Chou @ 2020-12-17 7:17 UTC (permalink / raw)
To: Bluetooth Kernel Mailing List
Cc: Alain Michaud, Archie Pusaka, Marcel Holtmann,
Luiz Augusto von Dentz, Miao-chen Chou, Abhishek Pandit-Subedi,
Johan Hedberg, Luiz Augusto von Dentz, linux-kernel
The Realtek RTL8822CE Bluetooth controller support Microsoft vendor
extension and it uses 0xFCF0 for VsMsftOpCode.
The following test step was performed.
- Boot the test device with RTL8822CE and verify the INFO print in
dmesg.
Signed-off-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Reviewed-by: Archie Pusaka <apusaka@chromium.org>
---
drivers/bluetooth/btrtl.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index a4f7cace66b06..94df4e94999d5 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -658,6 +658,12 @@ struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev,
}
}
+ /* RTL8822CE supports the Microsoft vendor extension and uses 0xFCF0
+ * for VsMsftOpCode.
+ */
+ if (lmp_subver == RTL_ROM_LMP_8822B)
+ hci_set_msft_opcode(hdev, 0xFCF0);
+
return btrtl_dev;
err_free:
--
2.29.2.684.gfbc64c5ab5-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [v1,1/4] Bluetooth: Keep MSFT extension info throughout a hci_dev's life cycle
2020-12-17 7:17 [PATCH v1 1/4] Bluetooth: Keep MSFT extension info throughout a hci_dev's life cycle Miao-chen Chou
` (2 preceding siblings ...)
2020-12-17 7:17 ` [PATCH v1 4/4] Bluetooth: btrtl: Enable MSFT extension for RTL8822CE controller Miao-chen Chou
@ 2020-12-17 8:12 ` bluez.test.bot
3 siblings, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2020-12-17 8:12 UTC (permalink / raw)
To: linux-bluetooth, mcchou
[-- Attachment #1: Type: text/plain, Size: 2722 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=403409
---Test result---
##############################
Test: CheckPatch - PASS
##############################
Test: CheckGitLint - FAIL
workflow: Add workflow files for ci
1: T1 Title exceeds max length (92>72): "Merge 4f717a84dceaeea9f22efc590ad1b1e23f7fb108 into a8db91a9984ac432df442c4312e9459052e498f2"
3: B6 Body message is missing
Bluetooth: Keep MSFT extension info throughout a hci_dev's life cycle
1: T1 Title exceeds max length (92>72): "Merge 4f717a84dceaeea9f22efc590ad1b1e23f7fb108 into a8db91a9984ac432df442c4312e9459052e498f2"
3: B6 Body message is missing
Bluetooth: btqca: Enable MSFT extension for Qualcomm WCN399x
1: T1 Title exceeds max length (92>72): "Merge 4f717a84dceaeea9f22efc590ad1b1e23f7fb108 into a8db91a9984ac432df442c4312e9459052e498f2"
3: B6 Body message is missing
Bluetooth: btusb: Enable MSFT extension for Intel controllers
1: T1 Title exceeds max length (92>72): "Merge 4f717a84dceaeea9f22efc590ad1b1e23f7fb108 into a8db91a9984ac432df442c4312e9459052e498f2"
3: B6 Body message is missing
Bluetooth: btrtl: Enable MSFT extension for RTL8822CE controller
1: T1 Title exceeds max length (92>72): "Merge 4f717a84dceaeea9f22efc590ad1b1e23f7fb108 into a8db91a9984ac432df442c4312e9459052e498f2"
3: B6 Body message is missing
##############################
Test: CheckBuildK - PASS
##############################
Test: CheckTestRunner: Setup - PASS
##############################
Test: CheckTestRunner: l2cap-tester - PASS
Total: 40, Passed: 34 (85.0%), Failed: 0, Not Run: 6
##############################
Test: CheckTestRunner: bnep-tester - PASS
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
##############################
Test: CheckTestRunner: mgmt-tester - FAIL
Total: 416, Passed: 394 (94.7%), Failed: 8, Not Run: 14
##############################
Test: CheckTestRunner: rfcomm-tester - PASS
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0
##############################
Test: CheckTestRunner: sco-tester - PASS
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: CheckTestRunner: smp-tester - PASS
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: CheckTestRunner: userchan-tester - PASS
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0
---
Regards,
Linux Bluetooth
[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 43338 bytes --]
[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3531 bytes --]
[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 548205 bytes --]
[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 11649 bytes --]
[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 9886 bytes --]
[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11797 bytes --]
[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 5427 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread