All of lore.kernel.org
 help / color / mirror / Atom feed
* [f2fs-dev] [PATCH] mkfs.f2fs.8: Better document the -g argument.
@ 2020-12-17  7:57 John A. Leuenhagen via Linux-f2fs-devel
  2020-12-17 16:21 ` Jaegeuk Kim
  0 siblings, 1 reply; 2+ messages in thread
From: John A. Leuenhagen via Linux-f2fs-devel @ 2020-12-17  7:57 UTC (permalink / raw)
  To: linux-f2fs-devel

To use Android defaults, you must use `-g android`. However, the man
page previously implied that you need only use `-g`.

Since you must specify `android`, I figured it would be appropriate
to name that field `default-options` in the man page. If there was ever
a reason to have a different set of default options, the `-g` option
could be used with a new `default-options` value, i.e. `-g example`.

Signed-off-by: John A. Leuenhagen <john@zlima12.com>
---
 man/mkfs.f2fs.8 | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/man/mkfs.f2fs.8 b/man/mkfs.f2fs.8
index 0aca4dc..c90ebcc 100644
--- a/man/mkfs.f2fs.8
+++ b/man/mkfs.f2fs.8
@@ -32,6 +32,7 @@ mkfs.f2fs \- create an F2FS file system
 ]
 [
 .B \-g
+.I default-options
 ]
 [
 .B \-i
@@ -136,8 +137,14 @@ Force overwrite when an existing filesystem is detected on the device.
 By default, mkfs.f2fs will not write to the device if it suspects that
 there is a filesystem or partition table on the device already.
 .TP
-.BI \-g
-Add default Android options.
+.BI \-g " default-options"
+Use a default set of options.
+The following values are supported:
+.RS 1.2i
+.TP 1.2i
+.B android
+Use default options for Android.
+.RE
 .TP
 .BI \-i
 Enable extended node bitmap.
-- 
2.26.2



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [f2fs-dev] [PATCH] mkfs.f2fs.8: Better document the -g argument.
  2020-12-17  7:57 [f2fs-dev] [PATCH] mkfs.f2fs.8: Better document the -g argument John A. Leuenhagen via Linux-f2fs-devel
@ 2020-12-17 16:21 ` Jaegeuk Kim
  0 siblings, 0 replies; 2+ messages in thread
From: Jaegeuk Kim @ 2020-12-17 16:21 UTC (permalink / raw)
  To: John A. Leuenhagen; +Cc: linux-f2fs-devel

On 12/17, John A. Leuenhagen via Linux-f2fs-devel wrote:
> To use Android defaults, you must use `-g android`. However, the man
> page previously implied that you need only use `-g`.
> 
> Since you must specify `android`, I figured it would be appropriate
> to name that field `default-options` in the man page. If there was ever
> a reason to have a different set of default options, the `-g` option
> could be used with a new `default-options` value, i.e. `-g example`.

Applied, thanks~

> 
> Signed-off-by: John A. Leuenhagen <john@zlima12.com>
> ---
>  man/mkfs.f2fs.8 | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/man/mkfs.f2fs.8 b/man/mkfs.f2fs.8
> index 0aca4dc..c90ebcc 100644
> --- a/man/mkfs.f2fs.8
> +++ b/man/mkfs.f2fs.8
> @@ -32,6 +32,7 @@ mkfs.f2fs \- create an F2FS file system
>  ]
>  [
>  .B \-g
> +.I default-options
>  ]
>  [
>  .B \-i
> @@ -136,8 +137,14 @@ Force overwrite when an existing filesystem is detected on the device.
>  By default, mkfs.f2fs will not write to the device if it suspects that
>  there is a filesystem or partition table on the device already.
>  .TP
> -.BI \-g
> -Add default Android options.
> +.BI \-g " default-options"
> +Use a default set of options.
> +The following values are supported:
> +.RS 1.2i
> +.TP 1.2i
> +.B android
> +Use default options for Android.
> +.RE
>  .TP
>  .BI \-i
>  Enable extended node bitmap.
> -- 
> 2.26.2
> 
> 
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-17 16:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-17  7:57 [f2fs-dev] [PATCH] mkfs.f2fs.8: Better document the -g argument John A. Leuenhagen via Linux-f2fs-devel
2020-12-17 16:21 ` Jaegeuk Kim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.