[chrome-os:chromeos-5.10 114/1031] drivers/tty/sysrq.c:456:40: sparse: sparse: incorrect type in argument 1 (different address spaces)

[chrome-os:chromeos-5.10 114/1031] drivers/tty/sysrq.c:456:40: sparse: sparse: incorrect type in argument 1 (different address spaces)

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2559 bytes --]

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.10
head:   73dbeef4571d1037d5e03374fad31195f60956cf
commit: 264a61835373f3600e2eed6966ca6240a98af38f [114/1031] CHROMIUM: sysrq: Added Chrome OS specific 'x' key
config: i386-randconfig-s001-20201217 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-184-g1b896707-dirty
        git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel
        git fetch --no-tags chrome-os chromeos-5.10
        git checkout 264a61835373f3600e2eed6966ca6240a98af38f
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> drivers/tty/sysrq.c:456:40: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected char const *cs @@     got char [noderef] __rcu * @@
   drivers/tty/sysrq.c:456:40: sparse:     expected char const *cs
   drivers/tty/sysrq.c:456:40: sparse:     got char [noderef] __rcu *
   drivers/tty/sysrq.c: note: in included file (through include/linux/rculist.h, include/linux/sched/signal.h):
   include/linux/rcupdate.h:693:9: sparse: sparse: context imbalance in 'sysrq_handle_crash' - unexpected unlock

vim +456 drivers/tty/sysrq.c

   441	
   442	/* send a signal to a process named comm if it has a certain parent */
   443	/* if parent is NULL, send to the first matching process */
   444	static void sysrq_x_cros_signal_process(char *comm, char *parent, int sig)
   445	{
   446		struct task_struct *p;
   447	
   448		read_lock(&tasklist_lock);
   449		for_each_process(p) {
   450			if (p->flags & (PF_KTHREAD | PF_EXITING))
   451				continue;
   452			if (is_global_init(p))
   453				continue;
   454			if (strncmp(p->comm, comm, TASK_COMM_LEN))
   455				continue;
 > 456			if (parent && strncmp(p->parent->comm, parent, TASK_COMM_LEN))
   457				continue;
   458	
   459			printk(KERN_INFO "%s: signal %d %s pid %u tgid %u\n",
   460			       __func__, sig, comm, p->pid, p->tgid);
   461			do_send_sig_info(sig, SEND_SIG_PRIV, p, true);
   462		}
   463		read_unlock(&tasklist_lock);
   464	}
   465	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34449 bytes --]

[chrome-os:chromeos-5.10 114/1031] drivers/tty/sysrq.c:456:40: sparse: sparse: incorrect type in argument 1 (different address spaces)

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2631 bytes --]

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.10
head:   73dbeef4571d1037d5e03374fad31195f60956cf
commit: 264a61835373f3600e2eed6966ca6240a98af38f [114/1031] CHROMIUM: sysrq: Added Chrome OS specific 'x' key
config: ia64-randconfig-s032-20201217 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-184-g1b896707-dirty
        git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel
        git fetch --no-tags chrome-os chromeos-5.10
        git checkout 264a61835373f3600e2eed6966ca6240a98af38f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> drivers/tty/sysrq.c:456:40: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected char const * @@     got char [noderef] __rcu * @@
   drivers/tty/sysrq.c:456:40: sparse:     expected char const *
   drivers/tty/sysrq.c:456:40: sparse:     got char [noderef] __rcu *
   drivers/tty/sysrq.c:150:13: sparse: sparse: context imbalance in 'sysrq_handle_crash' - unexpected unlock

vim +456 drivers/tty/sysrq.c

   441	
   442	/* send a signal to a process named comm if it has a certain parent */
   443	/* if parent is NULL, send to the first matching process */
   444	static void sysrq_x_cros_signal_process(char *comm, char *parent, int sig)
   445	{
   446		struct task_struct *p;
   447	
   448		read_lock(&tasklist_lock);
   449		for_each_process(p) {
   450			if (p->flags & (PF_KTHREAD | PF_EXITING))
   451				continue;
   452			if (is_global_init(p))
   453				continue;
   454			if (strncmp(p->comm, comm, TASK_COMM_LEN))
   455				continue;
 > 456			if (parent && strncmp(p->parent->comm, parent, TASK_COMM_LEN))
   457				continue;
   458	
   459			printk(KERN_INFO "%s: signal %d %s pid %u tgid %u\n",
   460			       __func__, sig, comm, p->pid, p->tgid);
   461			do_send_sig_info(sig, SEND_SIG_PRIV, p, true);
   462		}
   463		read_unlock(&tasklist_lock);
   464	}
   465	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33814 bytes --]