All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Ben Greear <greearb@candelatech.com>,
	Luca Coelho <luciano.coelho@intel.com>
Cc: Eric Dumazet <edumazet@google.com>,
	netdev <netdev@vger.kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: net: tso: add UDP segmentation support: adds regression for ax200 upload
Date: Fri, 18 Dec 2020 12:16:27 -0800	[thread overview]
Message-ID: <20201218121627.603329b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <5d89fd24-f00a-7e70-00ce-83529f13b05e@candelatech.com>

On Thu, 17 Dec 2020 12:40:26 -0800 Ben Greear wrote:
> On 12/17/20 10:20 AM, Eric Dumazet wrote:
> > On Thu, Dec 17, 2020 at 7:13 PM Ben Greear <greearb@candelatech.com> wrote:  
> >> It is the iwlwifi/mvm logic that supports ax200.  
> > 
> > Let me ask again :
> > 
> > I see two different potential call points :
> > 
> > drivers/net/wireless/intel/iwlwifi/pcie/tx.c:1529:
> > tso_build_hdr(skb, hdr_page->pos, &tso, data_left, !total_len);
> > drivers/net/wireless/intel/iwlwifi/queue/tx.c:427:
> > tso_build_hdr(skb, hdr_page->pos, &tso, data_left, !total_len);
> > 
> > To the best of your knowledge, which one would be used in your case ?
> > 
> > Both are horribly complex, I do not want to spend time studying two
> > implementations.  
> 
> It is the queue/tx.c code that executes on my system, verified with
> printk.

Not sure why Intel's not on CC here. 

Luca, is the ax200 TSO performance regression with recent kernel on your
radar?

  reply	other threads:[~2020-12-18 20:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 23:09 net: tso: add UDP segmentation support: adds regression for ax200 upload Ben Greear
2020-12-16 23:59 ` Ben Greear
2020-12-17 10:11   ` Eric Dumazet
2020-12-17 17:56     ` Ben Greear
2020-12-17 18:07       ` Eric Dumazet
2020-12-17 18:13         ` Ben Greear
2020-12-17 18:20           ` Eric Dumazet
2020-12-17 20:40             ` Ben Greear
2020-12-18 20:16               ` Jakub Kicinski [this message]
2020-12-19 15:18                 ` Johannes Berg
2020-12-19 16:55                   ` Ben Greear
2020-12-21 18:46                     ` Eric Dumazet
2020-12-21 18:54                       ` Jakub Kicinski
2020-12-21 19:04                       ` Eric Dumazet
2020-12-21 19:14                         ` Eric Dumazet
2020-12-21 20:01                           ` Rainer Suhm
2020-12-24 17:48                             ` Ben Greear
2021-01-19  8:53                           ` Johannes Berg
2021-01-19 10:02                             ` Eric Dumazet
2021-01-25 14:57                               ` Johannes Berg
2021-01-25 14:58                                 ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201218121627.603329b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=edumazet@google.com \
    --cc=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=luciano.coelho@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.