From: Nishanth Menon <nm@ti.com>
To: Gowtham Tammana <g-tammana@ti.com>
Cc: <robh+dt@kernel.org>, Tero Kristo <t-kristo@ti.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-main: Add main domain watchdog entries
Date: Fri, 18 Dec 2020 08:07:25 -0600 [thread overview]
Message-ID: <20201218140725.6ierioowdufl52bv@unfilled> (raw)
In-Reply-To: <20201217000716.11091-3-g-tammana@ti.com>
On 18:07-20201216, Gowtham Tammana wrote:
> Add DT entries for main domain watchdog instances.
Please add a note to indicate that these are the only watchdogs that
are visible to Linux and ARMv8 systems.
You may need to repost the dts patch once you have the
>
> Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> index 72d6496e88dd..de430d44c2a6 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> @@ -303,6 +303,24 @@ main_uart9: serial@2890000 {
> clock-names = "fclk";
> };
>
> + watchdog0: watchdog@2200000 {
If you are going to strengthen the node-names up (recommend we
do that), you might want to use a regex and lock things down.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation//devicetree/bindings/watchdog/ti,rti-wdt.yaml#n26
That is much better option that expecting people to read the example and
follow the convention.
> + compatible = "ti,j7-rti-wdt";
> + reg = <0x0 0x2200000 0x0 0x100>;
we try and keep 0x00 instead of 0x0 -> see other places in the dtsi
> + clocks = <&k3_clks 252 1>;
> + power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
> + assigned-clocks = <&k3_clks 252 1>;
> + assigned-clock-parents = <&k3_clks 252 5>;
> + };
> +
> + watchdog1: watchdog@2210000 {
> + compatible = "ti,j7-rti-wdt";
> + reg = <0x0 0x2210000 0x0 0x100>;
> + clocks = <&k3_clks 253 1>;
> + power-domains = <&k3_pds 253 TI_SCI_PD_EXCLUSIVE>;
> + assigned-clocks = <&k3_clks 253 1>;
> + assigned-clock-parents = <&k3_clks 253 5>;
> + };
> +
> main_i2c0: i2c@2000000 {
> compatible = "ti,j721e-i2c", "ti,omap4-i2c";
> reg = <0x00 0x2000000 0x00 0x100>;
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Gowtham Tammana <g-tammana@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-main: Add main domain watchdog entries
Date: Fri, 18 Dec 2020 08:07:25 -0600 [thread overview]
Message-ID: <20201218140725.6ierioowdufl52bv@unfilled> (raw)
In-Reply-To: <20201217000716.11091-3-g-tammana@ti.com>
On 18:07-20201216, Gowtham Tammana wrote:
> Add DT entries for main domain watchdog instances.
Please add a note to indicate that these are the only watchdogs that
are visible to Linux and ARMv8 systems.
You may need to repost the dts patch once you have the
>
> Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> index 72d6496e88dd..de430d44c2a6 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> @@ -303,6 +303,24 @@ main_uart9: serial@2890000 {
> clock-names = "fclk";
> };
>
> + watchdog0: watchdog@2200000 {
If you are going to strengthen the node-names up (recommend we
do that), you might want to use a regex and lock things down.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation//devicetree/bindings/watchdog/ti,rti-wdt.yaml#n26
That is much better option that expecting people to read the example and
follow the convention.
> + compatible = "ti,j7-rti-wdt";
> + reg = <0x0 0x2200000 0x0 0x100>;
we try and keep 0x00 instead of 0x0 -> see other places in the dtsi
> + clocks = <&k3_clks 252 1>;
> + power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
> + assigned-clocks = <&k3_clks 252 1>;
> + assigned-clock-parents = <&k3_clks 252 5>;
> + };
> +
> + watchdog1: watchdog@2210000 {
> + compatible = "ti,j7-rti-wdt";
> + reg = <0x0 0x2210000 0x0 0x100>;
> + clocks = <&k3_clks 253 1>;
> + power-domains = <&k3_pds 253 TI_SCI_PD_EXCLUSIVE>;
> + assigned-clocks = <&k3_clks 253 1>;
> + assigned-clock-parents = <&k3_clks 253 5>;
> + };
> +
> main_i2c0: i2c@2000000 {
> compatible = "ti,j721e-i2c", "ti,omap4-i2c";
> reg = <0x00 0x2000000 0x00 0x100>;
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-18 14:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 0:07 [PATCH 0/2] Add watchdog dt nodes for TI's J7200 SoC Gowtham Tammana
2020-12-17 0:07 ` Gowtham Tammana
2020-12-17 0:07 ` [PATCH 1/2] dt-bindings: watchdog: change node name to generic Gowtham Tammana
2020-12-17 0:07 ` Gowtham Tammana
2020-12-18 14:02 ` Nishanth Menon
2020-12-18 14:02 ` Nishanth Menon
2021-01-07 1:46 ` Gowtham A Tammana
2021-01-07 1:46 ` Gowtham A Tammana
2020-12-17 0:07 ` [PATCH 2/2] arm64: dts: ti: k3-j7200-main: Add main domain watchdog entries Gowtham Tammana
2020-12-17 0:07 ` Gowtham Tammana
2020-12-18 14:07 ` Nishanth Menon [this message]
2020-12-18 14:07 ` Nishanth Menon
2021-01-07 1:34 ` Gowtham A Tammana
2021-01-07 1:34 ` Gowtham A Tammana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201218140725.6ierioowdufl52bv@unfilled \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=g-tammana@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.