* [PATCH] i2c: mxc_i2c: improve error message readability
@ 2020-12-18 19:43 ferlandm at amotus.ca
2020-12-19 14:49 ` Fabio Estevam
2020-12-21 14:50 ` [PATCH v2] " ferlandm at amotus.ca
0 siblings, 2 replies; 5+ messages in thread
From: ferlandm at amotus.ca @ 2020-12-18 19:43 UTC (permalink / raw)
To: u-boot
From: Marc Ferland <ferlandm@amotus.ca>
Signed-off-by: Marc Ferland <ferlandm@amotus.ca>
---
drivers/i2c/mxc_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
index 7609594bd0..d486dab043 100644
--- a/drivers/i2c/mxc_i2c.c
+++ b/drivers/i2c/mxc_i2c.c
@@ -954,7 +954,7 @@ static int mxc_i2c_probe(struct udevice *bus)
!dm_gpio_is_valid(&i2c_bus->scl_gpio) ||
ret || ret2) {
dev_err(bus,
- "i2c bus %d at %lu, fail to request scl/sda gpio\n",
+ "i2c bus %d at 0x%2lx, fail to request scl/sda gpio\n",
bus->seq, i2c_bus->base);
return -EINVAL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] i2c: mxc_i2c: improve error message readability
2020-12-18 19:43 [PATCH] i2c: mxc_i2c: improve error message readability ferlandm at amotus.ca
@ 2020-12-19 14:49 ` Fabio Estevam
2020-12-21 14:50 ` [PATCH v2] " ferlandm at amotus.ca
1 sibling, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2020-12-19 14:49 UTC (permalink / raw)
To: u-boot
Hi Marc,
On Sat, Dec 19, 2020 at 11:27 AM <ferlandm@amotus.ca> wrote:
>
> From: Marc Ferland <ferlandm@amotus.ca>
>
> Signed-off-by: Marc Ferland <ferlandm@amotus.ca>
> ---
> drivers/i2c/mxc_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
> index 7609594bd0..d486dab043 100644
> --- a/drivers/i2c/mxc_i2c.c
> +++ b/drivers/i2c/mxc_i2c.c
> @@ -954,7 +954,7 @@ static int mxc_i2c_probe(struct udevice *bus)
> !dm_gpio_is_valid(&i2c_bus->scl_gpio) ||
> ret || ret2) {
> dev_err(bus,
> - "i2c bus %d at %lu, fail to request scl/sda gpio\n",
> + "i2c bus %d at 0x%2lx, fail to request scl/sda gpio\n",
The change looks good.
I would suggest adding a commit message though.
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] i2c: mxc_i2c: improve error message readability
2020-12-18 19:43 [PATCH] i2c: mxc_i2c: improve error message readability ferlandm at amotus.ca
2020-12-19 14:49 ` Fabio Estevam
@ 2020-12-21 14:50 ` ferlandm at amotus.ca
2020-12-21 20:21 ` Fabio Estevam
2020-12-26 15:54 ` sbabic at denx.de
1 sibling, 2 replies; 5+ messages in thread
From: ferlandm at amotus.ca @ 2020-12-21 14:50 UTC (permalink / raw)
To: u-boot
From: Marc Ferland <ferlandm@amotus.ca>
Use 0x%2lx to print the i2c bus base address in hexadecimal format
instead of printing as an integer.
Signed-off-by: Marc Ferland <ferlandm@amotus.ca>
---
Changes for v2:
- Add commit message
drivers/i2c/mxc_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
index 7609594bd0..d486dab043 100644
--- a/drivers/i2c/mxc_i2c.c
+++ b/drivers/i2c/mxc_i2c.c
@@ -954,7 +954,7 @@ static int mxc_i2c_probe(struct udevice *bus)
!dm_gpio_is_valid(&i2c_bus->scl_gpio) ||
ret || ret2) {
dev_err(bus,
- "i2c bus %d at %lu, fail to request scl/sda gpio\n",
+ "i2c bus %d at 0x%2lx, fail to request scl/sda gpio\n",
bus->seq, i2c_bus->base);
return -EINVAL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2] i2c: mxc_i2c: improve error message readability
2020-12-21 14:50 ` [PATCH v2] " ferlandm at amotus.ca
@ 2020-12-21 20:21 ` Fabio Estevam
2020-12-26 15:54 ` sbabic at denx.de
1 sibling, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2020-12-21 20:21 UTC (permalink / raw)
To: u-boot
On Mon, Dec 21, 2020 at 5:19 PM <ferlandm@amotus.ca> wrote:
>
> From: Marc Ferland <ferlandm@amotus.ca>
>
> Use 0x%2lx to print the i2c bus base address in hexadecimal format
> instead of printing as an integer.
>
> Signed-off-by: Marc Ferland <ferlandm@amotus.ca>
> ---
> Changes for v2:
> - Add commit message
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] i2c: mxc_i2c: improve error message readability
2020-12-21 14:50 ` [PATCH v2] " ferlandm at amotus.ca
2020-12-21 20:21 ` Fabio Estevam
@ 2020-12-26 15:54 ` sbabic at denx.de
1 sibling, 0 replies; 5+ messages in thread
From: sbabic at denx.de @ 2020-12-26 15:54 UTC (permalink / raw)
To: u-boot
> From: Marc Ferland <ferlandm@amotus.ca>
> Use 0x%2lx to print the i2c bus base address in hexadecimal format
> instead of printing as an integer.
> Signed-off-by: Marc Ferland <ferlandm@amotus.ca>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-26 15:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-18 19:43 [PATCH] i2c: mxc_i2c: improve error message readability ferlandm at amotus.ca
2020-12-19 14:49 ` Fabio Estevam
2020-12-21 14:50 ` [PATCH v2] " ferlandm at amotus.ca
2020-12-21 20:21 ` Fabio Estevam
2020-12-26 15:54 ` sbabic at denx.de
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.