All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kconfig: config script: add a little user help
@ 2020-12-19  5:59 Randy Dunlap
  2020-12-19 15:47 ` Masahiro Yamada
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-12-19  5:59 UTC (permalink / raw)
  To: linux-kernel; +Cc: Randy Dunlap, Andi Kleen, Masahiro Yamada, linux-kbuild

Give the user a clue about the problem along with the 35 lines of
usage/help text.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org
---
 scripts/config |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20201218.orig/scripts/config
+++ linux-next-20201218/scripts/config
@@ -223,6 +223,7 @@ while [ "$1" != "" ] ; do
 		;;
 
 	*)
+		echo "bad cmd: $CMD"
 		usage
 		;;
 	esac

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kconfig: config script: add a little user help
  2020-12-19  5:59 [PATCH] kconfig: config script: add a little user help Randy Dunlap
@ 2020-12-19 15:47 ` Masahiro Yamada
  2020-12-19 15:57   ` Masahiro Yamada
  0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2020-12-19 15:47 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Linux Kernel Mailing List, Andi Kleen, Linux Kbuild mailing list

On Sat, Dec 19, 2020 at 3:00 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Give the user a clue about the problem along with the 35 lines of
> usage/help text.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andi Kleen <ak@linux.intel.com>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: linux-kbuild@vger.kernel.org
> ---
>  scripts/config |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20201218.orig/scripts/config
> +++ linux-next-20201218/scripts/config
> @@ -223,6 +223,7 @@ while [ "$1" != "" ] ; do
>                 ;;
>
>         *)
> +               echo "bad cmd: $CMD"

Please send this to stderr.



>                 usage
>                 ;;
>         esac



-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kconfig: config script: add a little user help
  2020-12-19 15:47 ` Masahiro Yamada
@ 2020-12-19 15:57   ` Masahiro Yamada
  0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2020-12-19 15:57 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Linux Kernel Mailing List, Andi Kleen, Linux Kbuild mailing list

On Sun, Dec 20, 2020 at 12:47 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Sat, Dec 19, 2020 at 3:00 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > Give the user a clue about the problem along with the 35 lines of
> > usage/help text.
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Andi Kleen <ak@linux.intel.com>
> > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > Cc: linux-kbuild@vger.kernel.org
> > ---
> >  scripts/config |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > --- linux-next-20201218.orig/scripts/config
> > +++ linux-next-20201218/scripts/config
> > @@ -223,6 +223,7 @@ while [ "$1" != "" ] ; do
> >                 ;;
> >
> >         *)
> > +               echo "bad cmd: $CMD"
>
> Please send this to stderr.


Also, "bad command" instead of "bad cmd"




>
>
>
> >                 usage
> >                 ;;
> >         esac
>
>
>
> --
> Best Regards
> Masahiro Yamada



-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-19 15:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-19  5:59 [PATCH] kconfig: config script: add a little user help Randy Dunlap
2020-12-19 15:47 ` Masahiro Yamada
2020-12-19 15:57   ` Masahiro Yamada

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.