[PATCH] block: aoe: Use seq_putc() if possible

[PATCH] block: aoe: Use seq_putc() if possible

[Amey Narkhede]

This is a single character that is printed out. Use seq_putc() for
it to simplify the code.

Signed-off-by: Amey Narkhede <ameynarkhede03@gmail.com>
---
 drivers/block/aoe/aoeblk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c
index c34e71b0c4a9..742c353aff54 100644
--- a/drivers/block/aoe/aoeblk.c
+++ b/drivers/block/aoe/aoeblk.c
@@ -147,7 +147,7 @@ static int aoedisk_debugfs_show(struct seq_file *s, void *ignored)
 			seq_printf(s, "%c%s", c, ifp->nd->name);
 			c = ',';
 		}
-		seq_puts(s, "\n");
+		seq_putc(s, '\n');
 	}
 	spin_unlock_irqrestore(&d->lock, flags);

@@ -465,4 +465,3 @@ aoeblk_init(void)
 	aoe_debugfs_dir = debugfs_create_dir("aoe", NULL);
 	return 0;
 }
-
--
2.29.2

Re: [PATCH] block: aoe: Use seq_putc() if possible

[Amey Narkhede]

[-- Attachment #1: Type: message/rfc822, Size: 1621 bytes --]

From: Amey Narkhede <ameynarkhede03@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Subject: Re: [PATCH] block: aoe: Use seq_putc() if possible
Date: Mon, 21 Dec 2020 21:30:13 +0530
Message-ID: <20201221160013.pohxcqob35pk44k6@archlinux>

On 20/12/21 04:04PM, Markus Elfring wrote:
> > This is a single character that is printed out. Use seq_putc() for
> > it to simplify the code.
>
> How do you think about to reconsider the integration of a previous update suggestion once more?
>
> [PATCH 1/3] block-aoe: Use seq_putc() in aoedisk_debugfs_show()
> https://lore.kernel.org/lkml/58b532fc-14c5-6e87-75d0-d78703b289dc@users.sourceforge.net/
> https://lore.kernel.org/patchwork/patch/785968/
> https://lkml.org/lkml/2017/5/8/90
>
> Regards,
> Markus
Apologies. I didn't find those patches.
I'm a beginner so I'm submitting style changes mainly
to get familiar with email based workflow of linux
kernel. I'll keep in mind to search previous
patches next time before submitting a patch.

Amey



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]