From: Gao Xiang <hsiangkao@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Huang Jianan <huangjianan@oppo.com>,
guoweichao@oppo.com, linux-erofs@lists.ozlabs.org,
zhangshiming@oppo.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] erofs: support direct IO for uncompressed file
Date: Wed, 23 Dec 2020 17:03:51 +0800 [thread overview]
Message-ID: <20201223090351.GD1831635@xiangao.remote.csb> (raw)
In-Reply-To: <20201223085401.GA336@infradead.org>
On Wed, Dec 23, 2020 at 08:54:01AM +0000, Christoph Hellwig wrote:
> On Wed, Dec 23, 2020 at 04:48:20PM +0800, Huang Jianan wrote:
> > Hi Christoph,
> >
> > The reason we use dio is because we need to deploy the patch on some early
> > kernel versions, and we don't pay much attention to the change of iomap.
>
> No, that is never an excuse for upstream development.
Ok, personally I also agree this, let's go further in this way.
Thanks,
Gao Xiang
>
WARNING: multiple messages have this Message-ID (diff)
From: Gao Xiang <hsiangkao@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, guoweichao@oppo.com,
linux-erofs@lists.ozlabs.org, zhangshiming@oppo.com
Subject: Re: [PATCH] erofs: support direct IO for uncompressed file
Date: Wed, 23 Dec 2020 17:03:51 +0800 [thread overview]
Message-ID: <20201223090351.GD1831635@xiangao.remote.csb> (raw)
In-Reply-To: <20201223085401.GA336@infradead.org>
On Wed, Dec 23, 2020 at 08:54:01AM +0000, Christoph Hellwig wrote:
> On Wed, Dec 23, 2020 at 04:48:20PM +0800, Huang Jianan wrote:
> > Hi Christoph,
> >
> > The reason we use dio is because we need to deploy the patch on some early
> > kernel versions, and we don't pay much attention to the change of iomap.
>
> No, that is never an excuse for upstream development.
Ok, personally I also agree this, let's go further in this way.
Thanks,
Gao Xiang
>
next prev parent reply other threads:[~2020-12-23 9:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 14:04 [PATCH] erofs: support direct IO for uncompressed file Huang Jianan
2020-12-14 14:04 ` Huang Jianan
2020-12-14 14:04 ` [PATCH] fsstress: support direct IO Huang Jianan
2020-12-14 14:04 ` Huang Jianan
2020-12-22 13:21 ` [PATCH] erofs: support direct IO for uncompressed file Gao Xiang
2020-12-22 13:21 ` Gao Xiang
2020-12-22 14:22 ` Christoph Hellwig
2020-12-22 14:22 ` Christoph Hellwig
2020-12-22 19:39 ` Gao Xiang
2020-12-22 19:39 ` Gao Xiang
2020-12-23 7:44 ` Christoph Hellwig
2020-12-23 7:44 ` Christoph Hellwig
2020-12-23 8:48 ` Huang Jianan
2020-12-23 8:54 ` Christoph Hellwig
2020-12-23 8:54 ` Christoph Hellwig
2020-12-23 9:03 ` Gao Xiang [this message]
2020-12-23 9:03 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223090351.GD1831635@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=guoweichao@oppo.com \
--cc=hch@infradead.org \
--cc=huangjianan@oppo.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.