* [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-22 4:06 ` Rob Herring
0 siblings, 0 replies; 29+ messages in thread
From: Rob Herring @ 2020-12-22 4:06 UTC (permalink / raw)
To: devicetree
Cc: linux-kernel, Laurent Pinchart, Vinod Koul, Mark Brown,
Greg Kroah-Hartman, Jassi Brar, dri-devel, dmaengine, alsa-devel,
linux-usb
'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
preferred for a single entry while greater than 1 should have an 'items'
list.
A meta-schema check for this is pending once these existing cases are
fixed.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jassi Brar <jaswinder.singh@linaro.org>
Cc: dri-devel@lists.freedesktop.org
Cc: dmaengine@vger.kernel.org
Cc: alsa-devel@alsa-project.org
Cc: linux-usb@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 -
.../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 --
Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 -
Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 ---
6 files changed, 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
index 7b9d468c3e52..403d57977ee7 100644
--- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
+++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
@@ -98,7 +98,6 @@ properties:
maxItems: 1
dmas:
- maxItems: 4
items:
- description: Video layer, plane 0 (RGB or luma)
- description: Video layer, plane 1 (U/V or U)
diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
index b548e4723936..c07eb6f2fc8d 100644
--- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
@@ -73,7 +73,6 @@ properties:
maxItems: 1
clock-names:
- maxItems: 1
items:
- const: fck
diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
index d43791a2dde7..d07eb00b97c8 100644
--- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
+++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
@@ -61,7 +61,6 @@ properties:
- description: low-priority non-secure
- description: high-priority non-secure
- description: Secure
- maxItems: 3
clocks:
maxItems: 1
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
index e543a6123792..b55775e21de6 100644
--- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
+++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
@@ -44,7 +44,6 @@ properties:
maxItems: 3
clock-names:
- maxItems: 3
items:
- const: hda
- const: hda2hdmi
@@ -54,7 +53,6 @@ properties:
maxItems: 3
reset-names:
- maxItems: 3
items:
- const: hda
- const: hda2hdmi
diff --git a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
index 0f078bd0a3e5..22603256ddf8 100644
--- a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
+++ b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
@@ -51,7 +51,6 @@ properties:
maxItems: 1
phy-names:
- maxItems: 1
items:
- const: usb
diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
index 737c1f47b7de..54c361d4a7af 100644
--- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
+++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
@@ -74,11 +74,8 @@ properties:
phys:
maxItems: 1
- items:
- - description: phandle + phy specifier pair.
phy-names:
- maxItems: 1
items:
- const: usb
--
2.27.0
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-22 4:06 ` Rob Herring
0 siblings, 0 replies; 29+ messages in thread
From: Rob Herring @ 2020-12-22 4:06 UTC (permalink / raw)
To: devicetree
Cc: alsa-devel, Greg Kroah-Hartman, linux-usb, linux-kernel,
dri-devel, Jassi Brar, Vinod Koul, Mark Brown, Laurent Pinchart,
dmaengine
'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
preferred for a single entry while greater than 1 should have an 'items'
list.
A meta-schema check for this is pending once these existing cases are
fixed.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jassi Brar <jaswinder.singh@linaro.org>
Cc: dri-devel@lists.freedesktop.org
Cc: dmaengine@vger.kernel.org
Cc: alsa-devel@alsa-project.org
Cc: linux-usb@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 -
.../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 --
Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 -
Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 ---
6 files changed, 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
index 7b9d468c3e52..403d57977ee7 100644
--- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
+++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
@@ -98,7 +98,6 @@ properties:
maxItems: 1
dmas:
- maxItems: 4
items:
- description: Video layer, plane 0 (RGB or luma)
- description: Video layer, plane 1 (U/V or U)
diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
index b548e4723936..c07eb6f2fc8d 100644
--- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
@@ -73,7 +73,6 @@ properties:
maxItems: 1
clock-names:
- maxItems: 1
items:
- const: fck
diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
index d43791a2dde7..d07eb00b97c8 100644
--- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
+++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
@@ -61,7 +61,6 @@ properties:
- description: low-priority non-secure
- description: high-priority non-secure
- description: Secure
- maxItems: 3
clocks:
maxItems: 1
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
index e543a6123792..b55775e21de6 100644
--- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
+++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
@@ -44,7 +44,6 @@ properties:
maxItems: 3
clock-names:
- maxItems: 3
items:
- const: hda
- const: hda2hdmi
@@ -54,7 +53,6 @@ properties:
maxItems: 3
reset-names:
- maxItems: 3
items:
- const: hda
- const: hda2hdmi
diff --git a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
index 0f078bd0a3e5..22603256ddf8 100644
--- a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
+++ b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
@@ -51,7 +51,6 @@ properties:
maxItems: 1
phy-names:
- maxItems: 1
items:
- const: usb
diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
index 737c1f47b7de..54c361d4a7af 100644
--- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
+++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
@@ -74,11 +74,8 @@ properties:
phys:
maxItems: 1
- items:
- - description: phandle + phy specifier pair.
phy-names:
- maxItems: 1
items:
- const: usb
--
2.27.0
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-22 4:06 ` Rob Herring
0 siblings, 0 replies; 29+ messages in thread
From: Rob Herring @ 2020-12-22 4:06 UTC (permalink / raw)
To: devicetree
Cc: alsa-devel, Greg Kroah-Hartman, linux-usb, linux-kernel,
dri-devel, Jassi Brar, Vinod Koul, Mark Brown, Laurent Pinchart,
dmaengine
'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
preferred for a single entry while greater than 1 should have an 'items'
list.
A meta-schema check for this is pending once these existing cases are
fixed.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jassi Brar <jaswinder.singh@linaro.org>
Cc: dri-devel@lists.freedesktop.org
Cc: dmaengine@vger.kernel.org
Cc: alsa-devel@alsa-project.org
Cc: linux-usb@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 -
.../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 --
Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 -
Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 ---
6 files changed, 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
index 7b9d468c3e52..403d57977ee7 100644
--- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
+++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
@@ -98,7 +98,6 @@ properties:
maxItems: 1
dmas:
- maxItems: 4
items:
- description: Video layer, plane 0 (RGB or luma)
- description: Video layer, plane 1 (U/V or U)
diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
index b548e4723936..c07eb6f2fc8d 100644
--- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
@@ -73,7 +73,6 @@ properties:
maxItems: 1
clock-names:
- maxItems: 1
items:
- const: fck
diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
index d43791a2dde7..d07eb00b97c8 100644
--- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
+++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
@@ -61,7 +61,6 @@ properties:
- description: low-priority non-secure
- description: high-priority non-secure
- description: Secure
- maxItems: 3
clocks:
maxItems: 1
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
index e543a6123792..b55775e21de6 100644
--- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
+++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
@@ -44,7 +44,6 @@ properties:
maxItems: 3
clock-names:
- maxItems: 3
items:
- const: hda
- const: hda2hdmi
@@ -54,7 +53,6 @@ properties:
maxItems: 3
reset-names:
- maxItems: 3
items:
- const: hda
- const: hda2hdmi
diff --git a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
index 0f078bd0a3e5..22603256ddf8 100644
--- a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
+++ b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
@@ -51,7 +51,6 @@ properties:
maxItems: 1
phy-names:
- maxItems: 1
items:
- const: usb
diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
index 737c1f47b7de..54c361d4a7af 100644
--- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
+++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
@@ -74,11 +74,8 @@ properties:
phys:
maxItems: 1
- items:
- - description: phandle + phy specifier pair.
phy-names:
- maxItems: 1
items:
- const: usb
--
2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
2020-12-22 4:06 ` Rob Herring
@ 2020-12-22 6:39 ` Sam Ravnborg
-1 siblings, 0 replies; 29+ messages in thread
From: Sam Ravnborg @ 2020-12-22 6:39 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, alsa-devel, Greg Kroah-Hartman, linux-usb,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul, Mark Brown,
Laurent Pinchart, dmaengine
Hi Rob,
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
With one comment below,
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> index 737c1f47b7de..54c361d4a7af 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> @@ -74,11 +74,8 @@ properties:
>
> phys:
> maxItems: 1
> - items:
> - - description: phandle + phy specifier pair.
The description may help some people, so keeping the
description and deleting maxItems would maybe be better.
Sam
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-22 6:39 ` Sam Ravnborg
0 siblings, 0 replies; 29+ messages in thread
From: Sam Ravnborg @ 2020-12-22 6:39 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, alsa-devel, Greg Kroah-Hartman, linux-usb,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul, Mark Brown,
Laurent Pinchart, dmaengine
Hi Rob,
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
With one comment below,
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> index 737c1f47b7de..54c361d4a7af 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> @@ -74,11 +74,8 @@ properties:
>
> phys:
> maxItems: 1
> - items:
> - - description: phandle + phy specifier pair.
The description may help some people, so keeping the
description and deleting maxItems would maybe be better.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
2020-12-22 4:06 ` Rob Herring
(?)
@ 2020-12-22 7:00 ` Laurent Pinchart
-1 siblings, 0 replies; 29+ messages in thread
From: Laurent Pinchart @ 2020-12-22 7:00 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-kernel, Vinod Koul, Mark Brown,
Greg Kroah-Hartman, Jassi Brar, dri-devel, dmaengine, alsa-devel,
linux-usb
Hi Rob,
Thank you for the patch.
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
> Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 -
> .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 --
> Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 -
> Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 ---
> 6 files changed, 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> index 7b9d468c3e52..403d57977ee7 100644
> --- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> +++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> @@ -98,7 +98,6 @@ properties:
> maxItems: 1
>
> dmas:
> - maxItems: 4
> items:
> - description: Video layer, plane 0 (RGB or luma)
> - description: Video layer, plane 1 (U/V or U)
> diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> index b548e4723936..c07eb6f2fc8d 100644
> --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> @@ -73,7 +73,6 @@ properties:
> maxItems: 1
>
> clock-names:
> - maxItems: 1
> items:
> - const: fck
>
> diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> index d43791a2dde7..d07eb00b97c8 100644
> --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> @@ -61,7 +61,6 @@ properties:
> - description: low-priority non-secure
> - description: high-priority non-secure
> - description: Secure
> - maxItems: 3
>
> clocks:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> index e543a6123792..b55775e21de6 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> @@ -44,7 +44,6 @@ properties:
> maxItems: 3
>
> clock-names:
> - maxItems: 3
> items:
> - const: hda
> - const: hda2hdmi
> @@ -54,7 +53,6 @@ properties:
> maxItems: 3
>
> reset-names:
> - maxItems: 3
> items:
> - const: hda
> - const: hda2hdmi
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> index 0f078bd0a3e5..22603256ddf8 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> @@ -51,7 +51,6 @@ properties:
> maxItems: 1
>
> phy-names:
> - maxItems: 1
> items:
> - const: usb
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> index 737c1f47b7de..54c361d4a7af 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> @@ -74,11 +74,8 @@ properties:
>
> phys:
> maxItems: 1
> - items:
> - - description: phandle + phy specifier pair.
>
> phy-names:
> - maxItems: 1
> items:
> - const: usb
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-22 7:00 ` Laurent Pinchart
0 siblings, 0 replies; 29+ messages in thread
From: Laurent Pinchart @ 2020-12-22 7:00 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, alsa-devel, Greg Kroah-Hartman, linux-usb,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul, Mark Brown,
dmaengine
Hi Rob,
Thank you for the patch.
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
> Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 -
> .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 --
> Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 -
> Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 ---
> 6 files changed, 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> index 7b9d468c3e52..403d57977ee7 100644
> --- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> +++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> @@ -98,7 +98,6 @@ properties:
> maxItems: 1
>
> dmas:
> - maxItems: 4
> items:
> - description: Video layer, plane 0 (RGB or luma)
> - description: Video layer, plane 1 (U/V or U)
> diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> index b548e4723936..c07eb6f2fc8d 100644
> --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> @@ -73,7 +73,6 @@ properties:
> maxItems: 1
>
> clock-names:
> - maxItems: 1
> items:
> - const: fck
>
> diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> index d43791a2dde7..d07eb00b97c8 100644
> --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> @@ -61,7 +61,6 @@ properties:
> - description: low-priority non-secure
> - description: high-priority non-secure
> - description: Secure
> - maxItems: 3
>
> clocks:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> index e543a6123792..b55775e21de6 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> @@ -44,7 +44,6 @@ properties:
> maxItems: 3
>
> clock-names:
> - maxItems: 3
> items:
> - const: hda
> - const: hda2hdmi
> @@ -54,7 +53,6 @@ properties:
> maxItems: 3
>
> reset-names:
> - maxItems: 3
> items:
> - const: hda
> - const: hda2hdmi
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> index 0f078bd0a3e5..22603256ddf8 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> @@ -51,7 +51,6 @@ properties:
> maxItems: 1
>
> phy-names:
> - maxItems: 1
> items:
> - const: usb
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> index 737c1f47b7de..54c361d4a7af 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> @@ -74,11 +74,8 @@ properties:
>
> phys:
> maxItems: 1
> - items:
> - - description: phandle + phy specifier pair.
>
> phy-names:
> - maxItems: 1
> items:
> - const: usb
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-22 7:00 ` Laurent Pinchart
0 siblings, 0 replies; 29+ messages in thread
From: Laurent Pinchart @ 2020-12-22 7:00 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, alsa-devel, Greg Kroah-Hartman, linux-usb,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul, Mark Brown,
dmaengine
Hi Rob,
Thank you for the patch.
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
> Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 -
> .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 --
> Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 -
> Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 ---
> 6 files changed, 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> index 7b9d468c3e52..403d57977ee7 100644
> --- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> +++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> @@ -98,7 +98,6 @@ properties:
> maxItems: 1
>
> dmas:
> - maxItems: 4
> items:
> - description: Video layer, plane 0 (RGB or luma)
> - description: Video layer, plane 1 (U/V or U)
> diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> index b548e4723936..c07eb6f2fc8d 100644
> --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> @@ -73,7 +73,6 @@ properties:
> maxItems: 1
>
> clock-names:
> - maxItems: 1
> items:
> - const: fck
>
> diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> index d43791a2dde7..d07eb00b97c8 100644
> --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> @@ -61,7 +61,6 @@ properties:
> - description: low-priority non-secure
> - description: high-priority non-secure
> - description: Secure
> - maxItems: 3
>
> clocks:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> index e543a6123792..b55775e21de6 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> @@ -44,7 +44,6 @@ properties:
> maxItems: 3
>
> clock-names:
> - maxItems: 3
> items:
> - const: hda
> - const: hda2hdmi
> @@ -54,7 +53,6 @@ properties:
> maxItems: 3
>
> reset-names:
> - maxItems: 3
> items:
> - const: hda
> - const: hda2hdmi
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> index 0f078bd0a3e5..22603256ddf8 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> @@ -51,7 +51,6 @@ properties:
> maxItems: 1
>
> phy-names:
> - maxItems: 1
> items:
> - const: usb
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> index 737c1f47b7de..54c361d4a7af 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> @@ -74,11 +74,8 @@ properties:
>
> phys:
> maxItems: 1
> - items:
> - - description: phandle + phy specifier pair.
>
> phy-names:
> - maxItems: 1
> items:
> - const: usb
>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
2020-12-22 4:06 ` Rob Herring
(?)
@ 2020-12-22 16:27 ` Vinod Koul
-1 siblings, 0 replies; 29+ messages in thread
From: Vinod Koul @ 2020-12-22 16:27 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-kernel, Laurent Pinchart, Mark Brown,
Greg Kroah-Hartman, Jassi Brar, dri-devel, dmaengine, alsa-devel,
linux-usb
On 21-12-20, 21:06, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
Acked-By: Vinod Koul <vkoul@kernel.org>
--
~Vinod
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-22 16:27 ` Vinod Koul
0 siblings, 0 replies; 29+ messages in thread
From: Vinod Koul @ 2020-12-22 16:27 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, alsa-devel, Greg Kroah-Hartman, linux-usb,
linux-kernel, dri-devel, Jassi Brar, Mark Brown,
Laurent Pinchart, dmaengine
On 21-12-20, 21:06, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
Acked-By: Vinod Koul <vkoul@kernel.org>
--
~Vinod
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-22 16:27 ` Vinod Koul
0 siblings, 0 replies; 29+ messages in thread
From: Vinod Koul @ 2020-12-22 16:27 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, alsa-devel, Greg Kroah-Hartman, linux-usb,
linux-kernel, dri-devel, Jassi Brar, Mark Brown,
Laurent Pinchart, dmaengine
On 21-12-20, 21:06, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
Acked-By: Vinod Koul <vkoul@kernel.org>
--
~Vinod
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
2020-12-22 4:06 ` Rob Herring
(?)
@ 2020-12-22 16:39 ` Jassi Brar
-1 siblings, 0 replies; 29+ messages in thread
From: Jassi Brar @ 2020-12-22 16:39 UTC (permalink / raw)
To: Rob Herring
Cc: Devicetree List, Linux Kernel Mailing List, Laurent Pinchart,
Vinod Koul, Mark Brown, Greg Kroah-Hartman, Jassi Brar,
dri-devel, dmaengine, alsa-devel, linux-usb
On Mon, Dec 21, 2020 at 10:10 PM Rob Herring <robh@kernel.org> wrote:
>
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
> Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 -
> .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 --
> Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 -
> Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 ---
> 6 files changed, 9 deletions(-)
Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-22 16:39 ` Jassi Brar
0 siblings, 0 replies; 29+ messages in thread
From: Jassi Brar @ 2020-12-22 16:39 UTC (permalink / raw)
To: Rob Herring
Cc: Devicetree List, alsa-devel, Greg Kroah-Hartman, linux-usb,
Linux Kernel Mailing List, dri-devel, Jassi Brar, Vinod Koul,
Mark Brown, Laurent Pinchart, dmaengine
On Mon, Dec 21, 2020 at 10:10 PM Rob Herring <robh@kernel.org> wrote:
>
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
> Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 -
> .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 --
> Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 -
> Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 ---
> 6 files changed, 9 deletions(-)
Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-22 16:39 ` Jassi Brar
0 siblings, 0 replies; 29+ messages in thread
From: Jassi Brar @ 2020-12-22 16:39 UTC (permalink / raw)
To: Rob Herring
Cc: Devicetree List, alsa-devel, Greg Kroah-Hartman, linux-usb,
Linux Kernel Mailing List, dri-devel, Jassi Brar, Vinod Koul,
Mark Brown, Laurent Pinchart, dmaengine
On Mon, Dec 21, 2020 at 10:10 PM Rob Herring <robh@kernel.org> wrote:
>
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
> Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 -
> .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 --
> Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 -
> Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 ---
> 6 files changed, 9 deletions(-)
Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
2020-12-22 4:06 ` Rob Herring
(?)
@ 2020-12-22 17:12 ` Mark Brown
-1 siblings, 0 replies; 29+ messages in thread
From: Mark Brown @ 2020-12-22 17:12 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-kernel, Laurent Pinchart, Vinod Koul,
Greg Kroah-Hartman, Jassi Brar, dri-devel, dmaengine, alsa-devel,
linux-usb
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-22 17:12 ` Mark Brown
0 siblings, 0 replies; 29+ messages in thread
From: Mark Brown @ 2020-12-22 17:12 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, alsa-devel, Greg Kroah-Hartman, linux-usb,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul,
Laurent Pinchart, dmaengine
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-22 17:12 ` Mark Brown
0 siblings, 0 replies; 29+ messages in thread
From: Mark Brown @ 2020-12-22 17:12 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, alsa-devel, Greg Kroah-Hartman, linux-usb,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul,
Laurent Pinchart, dmaengine
[-- Attachment #1.1: Type: text/plain, Size: 261 bytes --]
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
2020-12-22 6:39 ` Sam Ravnborg
(?)
@ 2020-12-23 17:54 ` Rob Herring
-1 siblings, 0 replies; 29+ messages in thread
From: Rob Herring @ 2020-12-23 17:54 UTC (permalink / raw)
To: Sam Ravnborg
Cc: devicetree, Linux-ALSA, Greg Kroah-Hartman, Linux USB List,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul, Mark Brown,
Laurent Pinchart, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM
On Mon, Dec 21, 2020 at 11:39 PM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Rob,
>
> On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> > preferred for a single entry while greater than 1 should have an 'items'
> > list.
> >
> > A meta-schema check for this is pending once these existing cases are
> > fixed.
> >
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Vinod Koul <vkoul@kernel.org>
> > Cc: Mark Brown <broonie@kernel.org>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Jassi Brar <jaswinder.singh@linaro.org>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: dmaengine@vger.kernel.org
> > Cc: alsa-devel@alsa-project.org
> > Cc: linux-usb@vger.kernel.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> With one comment below,
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> > ---
> > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > index 737c1f47b7de..54c361d4a7af 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > @@ -74,11 +74,8 @@ properties:
> >
> > phys:
> > maxItems: 1
> > - items:
> > - - description: phandle + phy specifier pair.
>
> The description may help some people, so keeping the
> description and deleting maxItems would maybe be better.
Do we really want to describe 'phys' hundreds of times? No. The
question I ask on the descriptions is could it be generated instead.
Rob
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-23 17:54 ` Rob Herring
0 siblings, 0 replies; 29+ messages in thread
From: Rob Herring @ 2020-12-23 17:54 UTC (permalink / raw)
To: Sam Ravnborg
Cc: devicetree, Linux-ALSA, Greg Kroah-Hartman, Linux USB List,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul, Mark Brown,
Laurent Pinchart, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM
On Mon, Dec 21, 2020 at 11:39 PM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Rob,
>
> On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> > preferred for a single entry while greater than 1 should have an 'items'
> > list.
> >
> > A meta-schema check for this is pending once these existing cases are
> > fixed.
> >
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Vinod Koul <vkoul@kernel.org>
> > Cc: Mark Brown <broonie@kernel.org>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Jassi Brar <jaswinder.singh@linaro.org>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: dmaengine@vger.kernel.org
> > Cc: alsa-devel@alsa-project.org
> > Cc: linux-usb@vger.kernel.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> With one comment below,
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> > ---
> > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > index 737c1f47b7de..54c361d4a7af 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > @@ -74,11 +74,8 @@ properties:
> >
> > phys:
> > maxItems: 1
> > - items:
> > - - description: phandle + phy specifier pair.
>
> The description may help some people, so keeping the
> description and deleting maxItems would maybe be better.
Do we really want to describe 'phys' hundreds of times? No. The
question I ask on the descriptions is could it be generated instead.
Rob
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-23 17:54 ` Rob Herring
0 siblings, 0 replies; 29+ messages in thread
From: Rob Herring @ 2020-12-23 17:54 UTC (permalink / raw)
To: Sam Ravnborg
Cc: devicetree, Linux-ALSA, Greg Kroah-Hartman, Linux USB List,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul, Mark Brown,
Laurent Pinchart, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM
On Mon, Dec 21, 2020 at 11:39 PM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Rob,
>
> On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> > preferred for a single entry while greater than 1 should have an 'items'
> > list.
> >
> > A meta-schema check for this is pending once these existing cases are
> > fixed.
> >
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Vinod Koul <vkoul@kernel.org>
> > Cc: Mark Brown <broonie@kernel.org>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Jassi Brar <jaswinder.singh@linaro.org>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: dmaengine@vger.kernel.org
> > Cc: alsa-devel@alsa-project.org
> > Cc: linux-usb@vger.kernel.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> With one comment below,
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> > ---
> > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > index 737c1f47b7de..54c361d4a7af 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > @@ -74,11 +74,8 @@ properties:
> >
> > phys:
> > maxItems: 1
> > - items:
> > - - description: phandle + phy specifier pair.
>
> The description may help some people, so keeping the
> description and deleting maxItems would maybe be better.
Do we really want to describe 'phys' hundreds of times? No. The
question I ask on the descriptions is could it be generated instead.
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
2020-12-23 17:54 ` Rob Herring
(?)
@ 2020-12-23 17:57 ` Laurent Pinchart
-1 siblings, 0 replies; 29+ messages in thread
From: Laurent Pinchart @ 2020-12-23 17:57 UTC (permalink / raw)
To: Rob Herring
Cc: Sam Ravnborg, devicetree, Linux-ALSA, Greg Kroah-Hartman,
Linux USB List, linux-kernel, dri-devel, Jassi Brar, Vinod Koul,
Mark Brown, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM
On Wed, Dec 23, 2020 at 10:54:26AM -0700, Rob Herring wrote:
> On Mon, Dec 21, 2020 at 11:39 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > Hi Rob,
> >
> > On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> > > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> > > preferred for a single entry while greater than 1 should have an 'items'
> > > list.
> > >
> > > A meta-schema check for this is pending once these existing cases are
> > > fixed.
> > >
> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Cc: Vinod Koul <vkoul@kernel.org>
> > > Cc: Mark Brown <broonie@kernel.org>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Jassi Brar <jaswinder.singh@linaro.org>
> > > Cc: dri-devel@lists.freedesktop.org
> > > Cc: dmaengine@vger.kernel.org
> > > Cc: alsa-devel@alsa-project.org
> > > Cc: linux-usb@vger.kernel.org
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > With one comment below,
> > Acked-by: Sam Ravnborg <sam@ravnborg.org>
> >
> > > ---
> > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > index 737c1f47b7de..54c361d4a7af 100644
> > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > @@ -74,11 +74,8 @@ properties:
> > >
> > > phys:
> > > maxItems: 1
> > > - items:
> > > - - description: phandle + phy specifier pair.
> >
> > The description may help some people, so keeping the
> > description and deleting maxItems would maybe be better.
>
> Do we really want to describe 'phys' hundreds of times? No. The
> question I ask on the descriptions is could it be generated instead.
I agree. If the description had mentioned why particular PHY was
referenced, I would have kept that, but "the phy is a phy" is probably
not something we want to duplicate everywhere.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-23 17:57 ` Laurent Pinchart
0 siblings, 0 replies; 29+ messages in thread
From: Laurent Pinchart @ 2020-12-23 17:57 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Linux-ALSA, Greg Kroah-Hartman, Linux USB List,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul, Mark Brown,
open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM, Sam Ravnborg
On Wed, Dec 23, 2020 at 10:54:26AM -0700, Rob Herring wrote:
> On Mon, Dec 21, 2020 at 11:39 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > Hi Rob,
> >
> > On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> > > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> > > preferred for a single entry while greater than 1 should have an 'items'
> > > list.
> > >
> > > A meta-schema check for this is pending once these existing cases are
> > > fixed.
> > >
> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Cc: Vinod Koul <vkoul@kernel.org>
> > > Cc: Mark Brown <broonie@kernel.org>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Jassi Brar <jaswinder.singh@linaro.org>
> > > Cc: dri-devel@lists.freedesktop.org
> > > Cc: dmaengine@vger.kernel.org
> > > Cc: alsa-devel@alsa-project.org
> > > Cc: linux-usb@vger.kernel.org
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > With one comment below,
> > Acked-by: Sam Ravnborg <sam@ravnborg.org>
> >
> > > ---
> > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > index 737c1f47b7de..54c361d4a7af 100644
> > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > @@ -74,11 +74,8 @@ properties:
> > >
> > > phys:
> > > maxItems: 1
> > > - items:
> > > - - description: phandle + phy specifier pair.
> >
> > The description may help some people, so keeping the
> > description and deleting maxItems would maybe be better.
>
> Do we really want to describe 'phys' hundreds of times? No. The
> question I ask on the descriptions is could it be generated instead.
I agree. If the description had mentioned why particular PHY was
referenced, I would have kept that, but "the phy is a phy" is probably
not something we want to duplicate everywhere.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-23 17:57 ` Laurent Pinchart
0 siblings, 0 replies; 29+ messages in thread
From: Laurent Pinchart @ 2020-12-23 17:57 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Linux-ALSA, Greg Kroah-Hartman, Linux USB List,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul, Mark Brown,
open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM, Sam Ravnborg
On Wed, Dec 23, 2020 at 10:54:26AM -0700, Rob Herring wrote:
> On Mon, Dec 21, 2020 at 11:39 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > Hi Rob,
> >
> > On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> > > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> > > preferred for a single entry while greater than 1 should have an 'items'
> > > list.
> > >
> > > A meta-schema check for this is pending once these existing cases are
> > > fixed.
> > >
> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Cc: Vinod Koul <vkoul@kernel.org>
> > > Cc: Mark Brown <broonie@kernel.org>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Jassi Brar <jaswinder.singh@linaro.org>
> > > Cc: dri-devel@lists.freedesktop.org
> > > Cc: dmaengine@vger.kernel.org
> > > Cc: alsa-devel@alsa-project.org
> > > Cc: linux-usb@vger.kernel.org
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > With one comment below,
> > Acked-by: Sam Ravnborg <sam@ravnborg.org>
> >
> > > ---
> > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > index 737c1f47b7de..54c361d4a7af 100644
> > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > @@ -74,11 +74,8 @@ properties:
> > >
> > > phys:
> > > maxItems: 1
> > > - items:
> > > - - description: phandle + phy specifier pair.
> >
> > The description may help some people, so keeping the
> > description and deleting maxItems would maybe be better.
>
> Do we really want to describe 'phys' hundreds of times? No. The
> question I ask on the descriptions is could it be generated instead.
I agree. If the description had mentioned why particular PHY was
referenced, I would have kept that, but "the phy is a phy" is probably
not something we want to duplicate everywhere.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
2020-12-23 17:54 ` Rob Herring
(?)
@ 2020-12-23 19:38 ` Sam Ravnborg
-1 siblings, 0 replies; 29+ messages in thread
From: Sam Ravnborg @ 2020-12-23 19:38 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Linux-ALSA, Greg Kroah-Hartman, Linux USB List,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul, Mark Brown,
Laurent Pinchart, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM
Hi Rob,
> > With one comment below,
> > Acked-by: Sam Ravnborg <sam@ravnborg.org>
> >
> > > ---
> > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > index 737c1f47b7de..54c361d4a7af 100644
> > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > @@ -74,11 +74,8 @@ properties:
> > >
> > > phys:
> > > maxItems: 1
> > > - items:
> > > - - description: phandle + phy specifier pair.
> >
> > The description may help some people, so keeping the
> > description and deleting maxItems would maybe be better.
>
> Do we really want to describe 'phys' hundreds of times? No.
Agree, for common properties we as a minimum want a phy-common.yaml
or some such - and have the description exactly once.
> The
> question I ask on the descriptions is could it be generated instead.
That could also be an idea, but assuming most people look at the source
then the same "most people" would miss the generated descriptions.
But to be clear - I see that phys: is a commonly used property so no
problem to have the description dropped here.
Ack still stands.
Sam
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-23 19:38 ` Sam Ravnborg
0 siblings, 0 replies; 29+ messages in thread
From: Sam Ravnborg @ 2020-12-23 19:38 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Linux-ALSA, Greg Kroah-Hartman, Linux USB List,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul, Mark Brown,
Laurent Pinchart, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM
Hi Rob,
> > With one comment below,
> > Acked-by: Sam Ravnborg <sam@ravnborg.org>
> >
> > > ---
> > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > index 737c1f47b7de..54c361d4a7af 100644
> > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > @@ -74,11 +74,8 @@ properties:
> > >
> > > phys:
> > > maxItems: 1
> > > - items:
> > > - - description: phandle + phy specifier pair.
> >
> > The description may help some people, so keeping the
> > description and deleting maxItems would maybe be better.
>
> Do we really want to describe 'phys' hundreds of times? No.
Agree, for common properties we as a minimum want a phy-common.yaml
or some such - and have the description exactly once.
> The
> question I ask on the descriptions is could it be generated instead.
That could also be an idea, but assuming most people look at the source
then the same "most people" would miss the generated descriptions.
But to be clear - I see that phys: is a commonly used property so no
problem to have the description dropped here.
Ack still stands.
Sam
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-23 19:38 ` Sam Ravnborg
0 siblings, 0 replies; 29+ messages in thread
From: Sam Ravnborg @ 2020-12-23 19:38 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Linux-ALSA, Greg Kroah-Hartman, Linux USB List,
linux-kernel, dri-devel, Jassi Brar, Vinod Koul, Mark Brown,
Laurent Pinchart, open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM
Hi Rob,
> > With one comment below,
> > Acked-by: Sam Ravnborg <sam@ravnborg.org>
> >
> > > ---
> > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > index 737c1f47b7de..54c361d4a7af 100644
> > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > > @@ -74,11 +74,8 @@ properties:
> > >
> > > phys:
> > > maxItems: 1
> > > - items:
> > > - - description: phandle + phy specifier pair.
> >
> > The description may help some people, so keeping the
> > description and deleting maxItems would maybe be better.
>
> Do we really want to describe 'phys' hundreds of times? No.
Agree, for common properties we as a minimum want a phy-common.yaml
or some such - and have the description exactly once.
> The
> question I ask on the descriptions is could it be generated instead.
That could also be an idea, but assuming most people look at the source
then the same "most people" would miss the generated descriptions.
But to be clear - I see that phys: is a commonly used property so no
problem to have the description dropped here.
Ack still stands.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
2020-12-22 4:06 ` Rob Herring
(?)
@ 2020-12-28 14:25 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 29+ messages in thread
From: Greg Kroah-Hartman @ 2020-12-28 14:25 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-kernel, Laurent Pinchart, Vinod Koul,
Mark Brown, Jassi Brar, dri-devel, dmaengine, alsa-devel,
linux-usb
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-28 14:25 ` Greg Kroah-Hartman
0 siblings, 0 replies; 29+ messages in thread
From: Greg Kroah-Hartman @ 2020-12-28 14:25 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, alsa-devel, linux-usb, linux-kernel, dri-devel,
Jassi Brar, Vinod Koul, Mark Brown, Laurent Pinchart, dmaengine
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH] dt-bindings: Drop redundant maxItems/items
@ 2020-12-28 14:25 ` Greg Kroah-Hartman
0 siblings, 0 replies; 29+ messages in thread
From: Greg Kroah-Hartman @ 2020-12-28 14:25 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, alsa-devel, linux-usb, linux-kernel, dri-devel,
Jassi Brar, Vinod Koul, Mark Brown, Laurent Pinchart, dmaengine
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 29+ messages in thread
end of thread, other threads:[~2020-12-28 14:35 UTC | newest]
Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-22 4:06 [PATCH] dt-bindings: Drop redundant maxItems/items Rob Herring
2020-12-22 4:06 ` Rob Herring
2020-12-22 4:06 ` Rob Herring
2020-12-22 6:39 ` Sam Ravnborg
2020-12-22 6:39 ` Sam Ravnborg
2020-12-23 17:54 ` Rob Herring
2020-12-23 17:54 ` Rob Herring
2020-12-23 17:54 ` Rob Herring
2020-12-23 17:57 ` Laurent Pinchart
2020-12-23 17:57 ` Laurent Pinchart
2020-12-23 17:57 ` Laurent Pinchart
2020-12-23 19:38 ` Sam Ravnborg
2020-12-23 19:38 ` Sam Ravnborg
2020-12-23 19:38 ` Sam Ravnborg
2020-12-22 7:00 ` Laurent Pinchart
2020-12-22 7:00 ` Laurent Pinchart
2020-12-22 7:00 ` Laurent Pinchart
2020-12-22 16:27 ` Vinod Koul
2020-12-22 16:27 ` Vinod Koul
2020-12-22 16:27 ` Vinod Koul
2020-12-22 16:39 ` Jassi Brar
2020-12-22 16:39 ` Jassi Brar
2020-12-22 16:39 ` Jassi Brar
2020-12-22 17:12 ` Mark Brown
2020-12-22 17:12 ` Mark Brown
2020-12-22 17:12 ` Mark Brown
2020-12-28 14:25 ` Greg Kroah-Hartman
2020-12-28 14:25 ` Greg Kroah-Hartman
2020-12-28 14:25 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.