* + mm-add-prototype-for-__add_to_page_cache_locked.patch added to -mm tree
@ 2020-12-23 20:39 akpm
0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2020-12-23 20:39 UTC (permalink / raw)
To: mm-commits, willy, alex.shi, jrdr.linux
The patch titled
Subject: mm: add prototype for __add_to_page_cache_locked()
has been added to the -mm tree. Its filename is
mm-add-prototype-for-__add_to_page_cache_locked.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-add-prototype-for-__add_to_page_cache_locked.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-add-prototype-for-__add_to_page_cache_locked.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Souptick Joarder <jrdr.linux@gmail.com>
Subject: mm: add prototype for __add_to_page_cache_locked()
Otherwise it causes a gcc warning:
../mm/filemap.c:830:14: warning: no previous prototype for
`__add_to_page_cache_locked' [-Wmissing-prototypes]
A previous attempt to make this function static led to compilation errors
when CONFIG_DEBUG_INFO_BTF is enabled because __add_to_page_cache_locked()
is referred to by BPF code.
Adding a prototype will silence the warning.
Link: https://lkml.kernel.org/r/1608693702-4665-1-git-send-email-jrdr.linux@gmail.com
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Cc: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/mm.h | 7 +++++++
1 file changed, 7 insertions(+)
--- a/include/linux/mm.h~mm-add-prototype-for-__add_to_page_cache_locked
+++ a/include/linux/mm.h
@@ -216,6 +216,13 @@ int overcommit_kbytes_handler(struct ctl
loff_t *);
int overcommit_policy_handler(struct ctl_table *, int, void *, size_t *,
loff_t *);
+/*
+ * Any attempt to mark this function as static leads to build failure
+ * when CONFIG_DEBUG_INFO_BTF is enabled because __add_to_page_cache_locked()
+ * is referred to by BPF code. This must be visible for error injection.
+ */
+int __add_to_page_cache_locked(struct page *page, struct address_space *mapping,
+ pgoff_t index, gfp_t gfp, void **shadowp);
#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n))
_
Patches currently in -mm which might be from jrdr.linux@gmail.com are
mm-add-prototype-for-__add_to_page_cache_locked.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
* + mm-add-prototype-for-__add_to_page_cache_locked.patch added to -mm tree
@ 2020-12-22 19:16 akpm
0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2020-12-22 19:16 UTC (permalink / raw)
To: mm-commits, alex.shi, jrdr.linux
The patch titled
Subject: include/linux/mm.h: add prototype for __add_to_page_cache_locked()
has been added to the -mm tree. Its filename is
mm-add-prototype-for-__add_to_page_cache_locked.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-add-prototype-for-__add_to_page_cache_locked.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-add-prototype-for-__add_to_page_cache_locked.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Souptick Joarder <jrdr.linux@gmail.com>
Subject: include/linux/mm.h: add prototype for __add_to_page_cache_locked()
Otherwise it causes a gcc warning:
../mm/filemap.c:830:14: warning: no previous prototype for
`__add_to_page_cache_locked' [-Wmissing-prototypes]
A previous attempt to make this function static led to compilation errors
for a few architectures.
Adding a prototype will silence the warning.
Link: https://lkml.kernel.org/r/1608646792-29073-1-git-send-email-jrdr.linux@gmail.com
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Cc: Alex Shi <alex.shi@linux.alibaba.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/mm.h | 6 ++++++
1 file changed, 6 insertions(+)
--- a/include/linux/mm.h~mm-add-prototype-for-__add_to_page_cache_locked
+++ a/include/linux/mm.h
@@ -216,6 +216,12 @@ int overcommit_kbytes_handler(struct ctl
loff_t *);
int overcommit_policy_handler(struct ctl_table *, int, void *, size_t *,
loff_t *);
+/*
+ * Any attempt to mark this function as static leads to build failure
+ * for few architectures. Adding a prototype to silence gcc warning.
+ */
+int __add_to_page_cache_locked(struct page *page, struct address_space *mapping,
+ pgoff_t offset, gfp_t gfp, void **shadowp);
#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n))
_
Patches currently in -mm which might be from jrdr.linux@gmail.com are
mm-add-prototype-for-__add_to_page_cache_locked.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-23 20:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23 20:39 + mm-add-prototype-for-__add_to_page_cache_locked.patch added to -mm tree akpm
-- strict thread matches above, loose matches on Subject: below --
2020-12-22 19:16 akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.