From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Ignat Korchagin <ignat@cloudflare.com>,
agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com,
dm-crypt@saout.de, linux-kernel@vger.kernel.org,
ebiggers@kernel.org, Damien.LeMoal@wdc.com, mpatocka@redhat.com,
kernel-team@cloudflare.com, nobuto.murata@canonical.com,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org,
linux-crypto <linux-crypto@vger.kernel.org>
Subject: Re: dm-crypt with no_read_workqueue and no_write_workqueue + btrfs scrub = BUG()
Date: Thu, 24 Dec 2020 07:56:42 +1100 [thread overview]
Message-ID: <20201223205642.GA19817@gondor.apana.org.au> (raw)
In-Reply-To: <74c7129b-a437-ebc4-1466-7fb9f034e006@maciej.szmigiero.name>
On Wed, Dec 23, 2020 at 04:37:34PM +0100, Maciej S. Szmigiero wrote:
>
> It looks like to me that the skcipher API might not be safe to
> call from a softirq context, after all.
skcipher is safe to use in a softirq. The problem is only in
dm-crypt where it tries to allocate memory with GFP_NOIO.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Damien.LeMoal@wdc.com, snitzer@redhat.com,
kernel-team@cloudflare.com, dm-crypt@saout.de,
linux-kernel@vger.kernel.org, nobuto.murata@canonical.com,
ebiggers@kernel.org, Chris Mason <clm@fb.com>,
dm-devel@redhat.com, mpatocka@redhat.com,
linux-btrfs@vger.kernel.org,
Ignat Korchagin <ignat@cloudflare.com>,
David Sterba <dsterba@suse.com>,
Josef Bacik <josef@toxicpanda.com>,
agk@redhat.com, linux-crypto <linux-crypto@vger.kernel.org>
Subject: Re: [dm-crypt] dm-crypt with no_read_workqueue and no_write_workqueue + btrfs scrub = BUG()
Date: Thu, 24 Dec 2020 07:56:42 +1100 [thread overview]
Message-ID: <20201223205642.GA19817@gondor.apana.org.au> (raw)
In-Reply-To: <74c7129b-a437-ebc4-1466-7fb9f034e006@maciej.szmigiero.name>
On Wed, Dec 23, 2020 at 04:37:34PM +0100, Maciej S. Szmigiero wrote:
>
> It looks like to me that the skcipher API might not be safe to
> call from a softirq context, after all.
skcipher is safe to use in a softirq. The problem is only in
dm-crypt where it tries to allocate memory with GFP_NOIO.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
dm-crypt mailing list
dm-crypt@saout.de
https://www.saout.de/mailman/listinfo/dm-crypt
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Damien.LeMoal@wdc.com, snitzer@redhat.com,
kernel-team@cloudflare.com, dm-crypt@saout.de,
linux-kernel@vger.kernel.org, nobuto.murata@canonical.com,
ebiggers@kernel.org, Chris Mason <clm@fb.com>,
dm-devel@redhat.com, mpatocka@redhat.com,
linux-btrfs@vger.kernel.org,
Ignat Korchagin <ignat@cloudflare.com>,
David Sterba <dsterba@suse.com>,
Josef Bacik <josef@toxicpanda.com>,
agk@redhat.com, linux-crypto <linux-crypto@vger.kernel.org>
Subject: Re: [dm-devel] dm-crypt with no_read_workqueue and no_write_workqueue + btrfs scrub = BUG()
Date: Thu, 24 Dec 2020 07:56:42 +1100 [thread overview]
Message-ID: <20201223205642.GA19817@gondor.apana.org.au> (raw)
In-Reply-To: <74c7129b-a437-ebc4-1466-7fb9f034e006@maciej.szmigiero.name>
On Wed, Dec 23, 2020 at 04:37:34PM +0100, Maciej S. Szmigiero wrote:
>
> It looks like to me that the skcipher API might not be safe to
> call from a softirq context, after all.
skcipher is safe to use in a softirq. The problem is only in
dm-crypt where it tries to allocate memory with GFP_NOIO.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2020-12-23 20:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 18:11 dm-crypt with no_read_workqueue and no_write_workqueue + btrfs scrub = BUG() Maciej S. Szmigiero
2020-12-14 18:11 ` [dm-devel] " Maciej S. Szmigiero
2020-12-14 18:11 ` [dm-crypt] " Maciej S. Szmigiero
2020-12-14 18:11 ` Maciej S. Szmigiero
2020-12-23 15:37 ` Maciej S. Szmigiero
2020-12-23 15:37 ` [dm-devel] " Maciej S. Szmigiero
2020-12-23 15:37 ` [dm-crypt] " Maciej S. Szmigiero
2020-12-23 20:56 ` Herbert Xu [this message]
2020-12-23 20:56 ` [dm-devel] " Herbert Xu
2020-12-23 20:56 ` [dm-crypt] " Herbert Xu
2020-12-24 18:46 ` Ignat Korchagin
2020-12-24 18:46 ` [dm-devel] " Ignat Korchagin
2020-12-24 18:46 ` [dm-crypt] " Ignat Korchagin
2020-12-24 18:52 ` Maciej S. Szmigiero
2020-12-24 18:52 ` [dm-devel] " Maciej S. Szmigiero
2020-12-24 18:52 ` [dm-crypt] " Maciej S. Szmigiero
2020-12-23 21:09 ` Ignat Korchagin
2020-12-23 21:09 ` [dm-devel] " Ignat Korchagin
2020-12-23 21:09 ` [dm-crypt] " Ignat Korchagin
2020-12-23 21:19 ` Maciej S. Szmigiero
2020-12-23 21:19 ` [dm-devel] " Maciej S. Szmigiero
2020-12-23 21:19 ` [dm-crypt] " Maciej S. Szmigiero
2020-12-23 21:31 ` Ignat Korchagin
2020-12-23 21:31 ` [dm-devel] " Ignat Korchagin
2020-12-23 21:31 ` [dm-crypt] " Ignat Korchagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223205642.GA19817@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Damien.LeMoal@wdc.com \
--cc=agk@redhat.com \
--cc=clm@fb.com \
--cc=dm-crypt@saout.de \
--cc=dm-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=ebiggers@kernel.org \
--cc=ignat@cloudflare.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@cloudflare.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mpatocka@redhat.com \
--cc=nobuto.murata@canonical.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.