All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ARM: mstar: Unify common parts of BreadBee boards into a dtsi
@ 2020-12-24  2:03 ` Daniel Palmer
  0 siblings, 0 replies; 5+ messages in thread
From: Daniel Palmer @ 2020-12-24  2:03 UTC (permalink / raw)
  To: soc, devicetree
  Cc: linux-arm-kernel, linux-kernel, arnd, olof, w, Daniel Palmer

The BreadBee and the BreadBee Crust are the same PCB with a different
SoC mounted. There are two top level dts to handle this.

To avoid deduplicating the parts that are more related to the PCB than
the SoC (i.e. the voltage regs and LEDs) add a common dtsi that can
be included in both top level dts.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
---
 .../dts/mstar-infinity-breadbee-common.dtsi   | 49 +++++++++++++++++++
 .../mstar-infinity-msc313-breadbee_crust.dts  |  1 +
 .../dts/mstar-infinity3-msc313e-breadbee.dts  |  1 +
 3 files changed, 51 insertions(+)
 create mode 100644 arch/arm/boot/dts/mstar-infinity-breadbee-common.dtsi

diff --git a/arch/arm/boot/dts/mstar-infinity-breadbee-common.dtsi b/arch/arm/boot/dts/mstar-infinity-breadbee-common.dtsi
new file mode 100644
index 000000000000..507ff2fba837
--- /dev/null
+++ b/arch/arm/boot/dts/mstar-infinity-breadbee-common.dtsi
@@ -0,0 +1,49 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2020 thingy.jp.
+ * Author: Daniel Palmer <daniel@thingy.jp>
+ */
+
+#include <dt-bindings/gpio/gpio.h>
+
+/ {
+	vcc_core: fixedregulator@0 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_core";
+		regulator-min-microvolt = <1000000>;
+		regulator-max-microvolt = <1000000>;
+		regulator-boot-on;
+	};
+
+	vcc_dram: fixedregulator@1 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_dram";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-boot-on;
+	};
+
+	vcc_io: fixedregulator@2 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_io";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+		red {
+			gpios = <&gpio MSC313_GPIO_SR_IO16 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "activity";
+		};
+		yellow {
+			gpios = <&gpio MSC313_GPIO_SR_IO17 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+		};
+	};
+};
+
+&cpu0 {
+	cpu-supply = <&vcc_core>;
+};
diff --git a/arch/arm/boot/dts/mstar-infinity-msc313-breadbee_crust.dts b/arch/arm/boot/dts/mstar-infinity-msc313-breadbee_crust.dts
index f9db2ff86f2d..db4910dcb8a7 100644
--- a/arch/arm/boot/dts/mstar-infinity-msc313-breadbee_crust.dts
+++ b/arch/arm/boot/dts/mstar-infinity-msc313-breadbee_crust.dts
@@ -6,6 +6,7 @@
 
 /dts-v1/;
 #include "mstar-infinity-msc313.dtsi"
+#include "mstar-infinity-breadbee-common.dtsi"
 
 / {
 	model = "BreadBee Crust";
diff --git a/arch/arm/boot/dts/mstar-infinity3-msc313e-breadbee.dts b/arch/arm/boot/dts/mstar-infinity3-msc313e-breadbee.dts
index f0eda80a95cc..e64ca4ce1830 100644
--- a/arch/arm/boot/dts/mstar-infinity3-msc313e-breadbee.dts
+++ b/arch/arm/boot/dts/mstar-infinity3-msc313e-breadbee.dts
@@ -6,6 +6,7 @@
 
 /dts-v1/;
 #include "mstar-infinity3-msc313e.dtsi"
+#include "mstar-infinity-breadbee-common.dtsi"
 
 / {
 	model = "BreadBee";
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH v2] ARM: mstar: Unify common parts of BreadBee boards into a dtsi
@ 2020-12-24  2:03 ` Daniel Palmer
  0 siblings, 0 replies; 5+ messages in thread
From: Daniel Palmer @ 2020-12-24  2:03 UTC (permalink / raw)
  To: soc, devicetree
  Cc: arnd, Daniel Palmer, linux-kernel, olof, w, linux-arm-kernel

The BreadBee and the BreadBee Crust are the same PCB with a different
SoC mounted. There are two top level dts to handle this.

To avoid deduplicating the parts that are more related to the PCB than
the SoC (i.e. the voltage regs and LEDs) add a common dtsi that can
be included in both top level dts.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
---
 .../dts/mstar-infinity-breadbee-common.dtsi   | 49 +++++++++++++++++++
 .../mstar-infinity-msc313-breadbee_crust.dts  |  1 +
 .../dts/mstar-infinity3-msc313e-breadbee.dts  |  1 +
 3 files changed, 51 insertions(+)
 create mode 100644 arch/arm/boot/dts/mstar-infinity-breadbee-common.dtsi

diff --git a/arch/arm/boot/dts/mstar-infinity-breadbee-common.dtsi b/arch/arm/boot/dts/mstar-infinity-breadbee-common.dtsi
new file mode 100644
index 000000000000..507ff2fba837
--- /dev/null
+++ b/arch/arm/boot/dts/mstar-infinity-breadbee-common.dtsi
@@ -0,0 +1,49 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2020 thingy.jp.
+ * Author: Daniel Palmer <daniel@thingy.jp>
+ */
+
+#include <dt-bindings/gpio/gpio.h>
+
+/ {
+	vcc_core: fixedregulator@0 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_core";
+		regulator-min-microvolt = <1000000>;
+		regulator-max-microvolt = <1000000>;
+		regulator-boot-on;
+	};
+
+	vcc_dram: fixedregulator@1 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_dram";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-boot-on;
+	};
+
+	vcc_io: fixedregulator@2 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_io";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+		red {
+			gpios = <&gpio MSC313_GPIO_SR_IO16 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "activity";
+		};
+		yellow {
+			gpios = <&gpio MSC313_GPIO_SR_IO17 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+		};
+	};
+};
+
+&cpu0 {
+	cpu-supply = <&vcc_core>;
+};
diff --git a/arch/arm/boot/dts/mstar-infinity-msc313-breadbee_crust.dts b/arch/arm/boot/dts/mstar-infinity-msc313-breadbee_crust.dts
index f9db2ff86f2d..db4910dcb8a7 100644
--- a/arch/arm/boot/dts/mstar-infinity-msc313-breadbee_crust.dts
+++ b/arch/arm/boot/dts/mstar-infinity-msc313-breadbee_crust.dts
@@ -6,6 +6,7 @@
 
 /dts-v1/;
 #include "mstar-infinity-msc313.dtsi"
+#include "mstar-infinity-breadbee-common.dtsi"
 
 / {
 	model = "BreadBee Crust";
diff --git a/arch/arm/boot/dts/mstar-infinity3-msc313e-breadbee.dts b/arch/arm/boot/dts/mstar-infinity3-msc313e-breadbee.dts
index f0eda80a95cc..e64ca4ce1830 100644
--- a/arch/arm/boot/dts/mstar-infinity3-msc313e-breadbee.dts
+++ b/arch/arm/boot/dts/mstar-infinity3-msc313e-breadbee.dts
@@ -6,6 +6,7 @@
 
 /dts-v1/;
 #include "mstar-infinity3-msc313e.dtsi"
+#include "mstar-infinity-breadbee-common.dtsi"
 
 / {
 	model = "BreadBee";
-- 
2.29.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] ARM: mstar: Unify common parts of BreadBee boards into a dtsi
@ 2021-01-22 22:43   ` Arnd Bergmann
  0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2021-01-22 22:43 UTC (permalink / raw)
  To: devicetree, soc, Daniel Palmer
  Cc: Arnd Bergmann, w, olof, linux-kernel, linux-arm-kernel

From: Arnd Bergmann <arnd@arndb.de>

On Thu, 24 Dec 2020 11:03:54 +0900, Daniel Palmer wrote:
> The BreadBee and the BreadBee Crust are the same PCB with a different
> SoC mounted. There are two top level dts to handle this.
> 
> To avoid deduplicating the parts that are more related to the PCB than
> the SoC (i.e. the voltage regs and LEDs) add a common dtsi that can
> be included in both top level dts.

This was missing in my earlier merges, sorry about that.

Now applied to arm/dt for v5.12, thanks!

[1/1] ARM: mstar: Unify common parts of BreadBee boards into a dtsi
      commit: 8367611892442ea788139ea1063308b6e7b6f04f

       Arnd

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] ARM: mstar: Unify common parts of BreadBee boards into a dtsi
@ 2021-01-22 22:43   ` Arnd Bergmann
  0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2021-01-22 22:43 UTC (permalink / raw)
  To: devicetree, soc, Daniel Palmer
  Cc: olof, linux-arm-kernel, w, Arnd Bergmann, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

On Thu, 24 Dec 2020 11:03:54 +0900, Daniel Palmer wrote:
> The BreadBee and the BreadBee Crust are the same PCB with a different
> SoC mounted. There are two top level dts to handle this.
> 
> To avoid deduplicating the parts that are more related to the PCB than
> the SoC (i.e. the voltage regs and LEDs) add a common dtsi that can
> be included in both top level dts.

This was missing in my earlier merges, sorry about that.

Now applied to arm/dt for v5.12, thanks!

[1/1] ARM: mstar: Unify common parts of BreadBee boards into a dtsi
      commit: 8367611892442ea788139ea1063308b6e7b6f04f

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] ARM: mstar: Unify common parts of BreadBee boards into a dtsi
  2020-12-24  2:03 ` Daniel Palmer
  (?)
  (?)
@ 2021-01-22 23:00 ` patchwork-bot+linux-soc
  -1 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+linux-soc @ 2021-01-22 23:00 UTC (permalink / raw)
  To: Daniel Palmer; +Cc: soc

Hello:

This patch was applied to soc/soc.git (refs/heads/for-next):

On Thu, 24 Dec 2020 11:03:54 +0900 you wrote:
> The BreadBee and the BreadBee Crust are the same PCB with a different
> SoC mounted. There are two top level dts to handle this.
> 
> To avoid deduplicating the parts that are more related to the PCB than
> the SoC (i.e. the voltage regs and LEDs) add a common dtsi that can
> be included in both top level dts.
> 
> [...]

Here is the summary with links:
  - [v2] ARM: mstar: Unify common parts of BreadBee boards into a dtsi
    https://git.kernel.org/soc/soc/c/836761189244

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-22 23:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-24  2:03 [PATCH v2] ARM: mstar: Unify common parts of BreadBee boards into a dtsi Daniel Palmer
2020-12-24  2:03 ` Daniel Palmer
2021-01-22 22:43 ` Arnd Bergmann
2021-01-22 22:43   ` Arnd Bergmann
2021-01-22 23:00 ` patchwork-bot+linux-soc

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.