* [PATCH 1/1] mmc: fsl_esdhc_spl: remove superfluous free()
@ 2020-12-27 9:50 ` Heinrich Schuchardt
2020-12-27 23:01 ` Jaehoon Chung
2021-01-19 13:05 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2020-12-27 9:50 UTC (permalink / raw)
To: u-boot
Freeing a buffer before calling hang() is superfluous. Removing the call
reduces the SPL size.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/mmc/fsl_esdhc_spl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/mmc/fsl_esdhc_spl.c b/drivers/mmc/fsl_esdhc_spl.c
index afe55fad9d..bee76572ac 100644
--- a/drivers/mmc/fsl_esdhc_spl.c
+++ b/drivers/mmc/fsl_esdhc_spl.c
@@ -91,20 +91,17 @@ void __noreturn mmc_boot(void)
CONFIG_CFG_DATA_SECTOR, 1, tmp_buf);
if (err != 1) {
puts("spl: mmc read failed!!\n");
- free(tmp_buf);
hang();
}
val = *(tmp_buf + MBRDBR_BOOT_SIG_55);
if (0x55 != val) {
puts("spl: mmc signature is not valid!!\n");
- free(tmp_buf);
hang();
}
val = *(tmp_buf + MBRDBR_BOOT_SIG_AA);
if (0xAA != val) {
puts("spl: mmc signature is not valid!!\n");
- free(tmp_buf);
hang();
}
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/1] mmc: fsl_esdhc_spl: remove superfluous free()
2020-12-27 9:50 ` [PATCH 1/1] mmc: fsl_esdhc_spl: remove superfluous free() Heinrich Schuchardt
@ 2020-12-27 23:01 ` Jaehoon Chung
2021-01-19 13:05 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2020-12-27 23:01 UTC (permalink / raw)
To: u-boot
On 12/27/20 6:50 PM, Heinrich Schuchardt wrote:
> Freeing a buffer before calling hang() is superfluous. Removing the call
> reduces the SPL size.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/fsl_esdhc_spl.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/fsl_esdhc_spl.c b/drivers/mmc/fsl_esdhc_spl.c
> index afe55fad9d..bee76572ac 100644
> --- a/drivers/mmc/fsl_esdhc_spl.c
> +++ b/drivers/mmc/fsl_esdhc_spl.c
> @@ -91,20 +91,17 @@ void __noreturn mmc_boot(void)
> CONFIG_CFG_DATA_SECTOR, 1, tmp_buf);
> if (err != 1) {
> puts("spl: mmc read failed!!\n");
> - free(tmp_buf);
> hang();
> }
>
> val = *(tmp_buf + MBRDBR_BOOT_SIG_55);
> if (0x55 != val) {
> puts("spl: mmc signature is not valid!!\n");
> - free(tmp_buf);
> hang();
> }
> val = *(tmp_buf + MBRDBR_BOOT_SIG_AA);
> if (0xAA != val) {
> puts("spl: mmc signature is not valid!!\n");
> - free(tmp_buf);
> hang();
> }
>
> --
> 2.29.2
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] mmc: fsl_esdhc_spl: remove superfluous free()
2020-12-27 9:50 ` [PATCH 1/1] mmc: fsl_esdhc_spl: remove superfluous free() Heinrich Schuchardt
2020-12-27 23:01 ` Jaehoon Chung
@ 2021-01-19 13:05 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-01-19 13:05 UTC (permalink / raw)
To: u-boot
On Sun, Dec 27, 2020 at 10:50:26AM +0100, Heinrich Schuchardt wrote:
> Freeing a buffer before calling hang() is superfluous. Removing the call
> reduces the SPL size.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210119/a4544e72/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-19 13:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20201227095103epcas1p3db3035189f7da3cc04d1ecc7e54a112a@epcas1p3.samsung.com>
2020-12-27 9:50 ` [PATCH 1/1] mmc: fsl_esdhc_spl: remove superfluous free() Heinrich Schuchardt
2020-12-27 23:01 ` Jaehoon Chung
2021-01-19 13:05 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.