All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dts: Log name of expected .dtb file
@ 2020-12-27 20:34 Florian Klink
  2021-01-18 13:01 ` Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Klink @ 2020-12-27 20:34 UTC (permalink / raw)
  To: u-boot

Make it more obvious what .dts file was expected by the build system.

When adding support for a new board, I kept getting this error message,
assuming I passed a wrong DEVICE_TREE parameter.

However, what was really the mistake was that the entry in
`arch/arm/dts/Makefile` was missing, and u-boot didn't like not being
able to find the .dtb file that should have been produced.

Simply logging the expected .dtb file name should make it easier to spot
such mistakes.

Signed-off-by: Florian Klink <flokli@flokli.de>
---
 dts/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dts/Makefile b/dts/Makefile
index a20930eb9a..a0347c9d34 100644
--- a/dts/Makefile
+++ b/dts/Makefile
@@ -32,7 +32,7 @@ targets += dt.dtb dt-spl.dtb
 $(DTB): arch-dtbs
 	$(Q)test -e $@ || (						\
 	echo >&2;							\
-	echo >&2 "Device Tree Source is not correctly specified.";	\
+	echo >&2 "Device Tree Source ($@) is not correctly specified.";	\
 	echo >&2 "Please define 'CONFIG_DEFAULT_DEVICE_TREE'";		\
 	echo >&2 "or build with 'DEVICE_TREE=<device_tree>' argument";	\
 	echo >&2;							\
-- 
2.29.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] dts: Log name of expected .dtb file
  2020-12-27 20:34 [PATCH] dts: Log name of expected .dtb file Florian Klink
@ 2021-01-18 13:01 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2021-01-18 13:01 UTC (permalink / raw)
  To: u-boot

On Sun, Dec 27, 2020 at 09:34:43PM +0100, Florian Klink wrote:

> Make it more obvious what .dts file was expected by the build system.
> 
> When adding support for a new board, I kept getting this error message,
> assuming I passed a wrong DEVICE_TREE parameter.
> 
> However, what was really the mistake was that the entry in
> `arch/arm/dts/Makefile` was missing, and u-boot didn't like not being
> able to find the .dtb file that should have been produced.
> 
> Simply logging the expected .dtb file name should make it easier to spot
> such mistakes.
> 
> Signed-off-by: Florian Klink <flokli@flokli.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210118/c4c4aa8b/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-18 13:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-27 20:34 [PATCH] dts: Log name of expected .dtb file Florian Klink
2021-01-18 13:01 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.