[gfs2:for-next.bob9i 4/4] fs/gfs2/super.c:601:5-10: Unneeded variable: "error". Return "0" on line 637

[gfs2:for-next.bob9i 4/4] fs/gfs2/super.c:601:5-10: Unneeded variable: "error". Return "0" on line 637

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

CC: kbuild-all(a)lists.01.org
CC: cluster-devel(a)redhat.com
TO: Bob Peterson <rpeterso@redhat.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git for-next.bob9i
head:   bf6dff1ef653cbb1a118cf489625aeaa30f32e1e
commit: bf6dff1ef653cbb1a118cf489625aeaa30f32e1e [4/4] gfs2: move freeze glock outside the make_fs_rw and _ro functions
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: microblaze-randconfig-c003-20201221 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> fs/gfs2/super.c:601:5-10: Unneeded variable: "error". Return "0" on line 637

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29646 bytes --]

[PATCH] gfs2: fix returnvar.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1540 bytes --]

CC: kbuild-all(a)lists.01.org
CC: cluster-devel(a)redhat.com
TO: Bob Peterson <rpeterso@redhat.com>
CC: Andreas Gruenbacher <agruenba@redhat.com>
CC: cluster-devel(a)redhat.com
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

fs/gfs2/super.c:601:5-10: Unneeded variable: "error". Return "0" on line 637


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: bf6dff1ef653 ("gfs2: move freeze glock outside the make_fs_rw and _ro functions")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git for-next.bob9i
head:   bf6dff1ef653cbb1a118cf489625aeaa30f32e1e
commit: bf6dff1ef653cbb1a118cf489625aeaa30f32e1e [4/4] gfs2: move freeze glock outside the make_fs_rw and _ro functions
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago

Please take the patch only if it's a positive warning. Thanks!

 super.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@@ -598,7 +598,6 @@ out:
 
 int gfs2_make_fs_ro(struct gfs2_sbd *sdp)
 {
-	int error = 0;
 	int log_write_allowed = test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags);
 
 	gfs2_flush_delete_work(sdp);
@@ -634,7 +633,7 @@ int gfs2_make_fs_ro(struct gfs2_sbd *sdp
 	if (!log_write_allowed)
 		sdp->sd_vfs->s_flags |= SB_RDONLY;
 
-	return error;
+	return 0;
 }
 
 /**