drivers/edac/edac_mc_sysfs.c:210:8-16: WARNING: use scnprintf or sprintf

drivers/edac/edac_mc_sysfs.c:210:8-16: WARNING: use scnprintf or sprintf

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2942 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   52cd5f9c22eeef26d05f9d9338ba4eb38f14dd3a
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
date:   5 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 5 months ago
config: x86_64-randconfig-c002-20201222 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/edac/edac_mc_sysfs.c:210:8-16: WARNING: use scnprintf or sprintf
   drivers/edac/edac_mc_sysfs.c:490:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/hid/hid-picolcd_core.c:304:8-16: WARNING: use scnprintf or sprintf
   drivers/hid/hid-picolcd_core.c:259:9-17: WARNING: use scnprintf or sprintf
--
>> drivers/hwmon/ltc4151.c:131:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/hwmon/ltc4261.c:150:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/ltc4261.c:133:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/ptp/ptp_sysfs.c:16:8-16: WARNING: use scnprintf or sprintf
   drivers/ptp/ptp_sysfs.c:230:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/hwmon/sch5636.c:275:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5636.c:261:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5636.c:247:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5636.c:187:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5636.c:179:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5636.c:163:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5636.c:230:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5636.c:216:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5636.c:202:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/video/fbdev/sm501fb.c:1169:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/video/fbdev/uvesafb.c:1640:8-16: WARNING: use scnprintf or sprintf
   drivers/video/fbdev/uvesafb.c:1626:9-17: WARNING: use scnprintf or sprintf
   drivers/video/fbdev/uvesafb.c:1596:9-17: WARNING: use scnprintf or sprintf
   drivers/video/fbdev/uvesafb.c:1611:9-17: WARNING: use scnprintf or sprintf
   drivers/video/fbdev/uvesafb.c:1550:8-16: WARNING: use scnprintf or sprintf
   drivers/video/fbdev/uvesafb.c:1581:9-17: WARNING: use scnprintf or sprintf
--
>> net/netfilter/xt_IDLETIMER.c:88:9-17: WARNING: use scnprintf or sprintf

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30492 bytes --]

[PATCH] coccinelle: api: fix device_attr_show.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2285 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Borislav Petkov <bp@alien8.de>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
CC: Tony Luck <tony.luck@intel.com>
CC: James Morse <james.morse@arm.com>
CC: Robert Richter <rrichter@marvell.com>
CC: linux-edac(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/edac/edac_mc_sysfs.c:210:8-16: WARNING: use scnprintf or sprintf
drivers/edac/edac_mc_sysfs.c:494:8-16: WARNING: use scnprintf or sprintf


 From Documentation/filesystems/sysfs.txt:
  show() must not use snprintf() when formatting the value to be
  returned to user space. If you can guarantee that an overflow
  will never happen you can use sprintf() otherwise you must use
  scnprintf().

Generated by: scripts/coccinelle/api/device_attr_show.cocci

Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   52cd5f9c22eeef26d05f9d9338ba4eb38f14dd3a
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 3 hours ago
:::::: commit date: 5 months ago

Please take the patch only if it's a positive warning. Thanks!

 edac_mc_sysfs.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/edac/edac_mc_sysfs.c
+++ b/drivers/edac/edac_mc_sysfs.c
@@ -207,7 +207,7 @@ static ssize_t channel_dimm_label_show(s
 	if (!rank->dimm->label[0])
 		return 0;
 
-	return snprintf(data, sizeof(rank->dimm->label) + 1, "%s\n",
+	return scnprintf(data, sizeof(rank->dimm->label) + 1, "%s\n",
 			rank->dimm->label);
 }
 
@@ -491,7 +491,7 @@ static ssize_t dimmdev_label_show(struct
 	if (!dimm->label[0])
 		return 0;
 
-	return snprintf(data, sizeof(dimm->label) + 1, "%s\n", dimm->label);
+	return scnprintf(data, sizeof(dimm->label) + 1, "%s\n", dimm->label);
 }
 
 static ssize_t dimmdev_label_store(struct device *dev,

[PATCH] coccinelle: api: fix device_attr_show.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2432 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: "Bruno Prémont" <bonbons@linux-vserver.org>
CC: Jiri Kosina <jikos@kernel.org>
CC: Benjamin Tissoires <benjamin.tissoires@redhat.com>
CC: linux-input(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/hid/hid-picolcd_core.c:304:8-16: WARNING: use scnprintf or sprintf
drivers/hid/hid-picolcd_core.c:259:9-17: WARNING: use scnprintf or sprintf


 From Documentation/filesystems/sysfs.txt:
  show() must not use snprintf() when formatting the value to be
  returned to user space. If you can guarantee that an overflow
  will never happen you can use sprintf() otherwise you must use
  scnprintf().

Generated by: scripts/coccinelle/api/device_attr_show.cocci

Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   52cd5f9c22eeef26d05f9d9338ba4eb38f14dd3a
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 3 hours ago
:::::: commit date: 5 months ago

Please take the patch only if it's a positive warning. Thanks!

 hid-picolcd_core.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- a/drivers/hid/hid-picolcd_core.c
+++ b/drivers/hid/hid-picolcd_core.c
@@ -256,9 +256,9 @@ static ssize_t picolcd_operation_mode_sh
 	struct picolcd_data *data = dev_get_drvdata(dev);
 
 	if (data->status & PICOLCD_BOOTLOADER)
-		return snprintf(buf, PAGE_SIZE, "[bootloader] lcd\n");
+		return scnprintf(buf, PAGE_SIZE, "[bootloader] lcd\n");
 	else
-		return snprintf(buf, PAGE_SIZE, "bootloader [lcd]\n");
+		return scnprintf(buf, PAGE_SIZE, "bootloader [lcd]\n");
 }
 
 static ssize_t picolcd_operation_mode_store(struct device *dev,
@@ -301,7 +301,7 @@ static ssize_t picolcd_operation_mode_de
 {
 	struct picolcd_data *data = dev_get_drvdata(dev);
 
-	return snprintf(buf, PAGE_SIZE, "%hu\n", data->opmode_delay);
+	return scnprintf(buf, PAGE_SIZE, "%hu\n", data->opmode_delay);
 }
 
 static ssize_t picolcd_operation_mode_delay_store(struct device *dev,

[PATCH] coccinelle: api: fix device_attr_show.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Jean Delvare <jdelvare@suse.com>
CC: Guenter Roeck <linux@roeck-us.net>
CC: linux-hwmon(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/hwmon/ltc4151.c:131:8-16: WARNING: use scnprintf or sprintf


 From Documentation/filesystems/sysfs.txt:
  show() must not use snprintf() when formatting the value to be
  returned to user space. If you can guarantee that an overflow
  will never happen you can use sprintf() otherwise you must use
  scnprintf().

Generated by: scripts/coccinelle/api/device_attr_show.cocci

Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   52cd5f9c22eeef26d05f9d9338ba4eb38f14dd3a
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 3 hours ago
:::::: commit date: 5 months ago

Please take the patch only if it's a positive warning. Thanks!

 ltc4151.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/hwmon/ltc4151.c
+++ b/drivers/hwmon/ltc4151.c
@@ -128,7 +128,7 @@ static ssize_t ltc4151_value_show(struct
 		return PTR_ERR(data);
 
 	value = ltc4151_get_value(data, attr->index);
-	return snprintf(buf, PAGE_SIZE, "%d\n", value);
+	return scnprintf(buf, PAGE_SIZE, "%d\n", value);
 }
 
 /*

[PATCH] coccinelle: api: fix device_attr_show.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2146 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Guenter Roeck <linux@roeck-us.net>
CC: Jean Delvare <jdelvare@suse.com>
CC: linux-hwmon(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/hwmon/ltc4261.c:150:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/ltc4261.c:133:8-16: WARNING: use scnprintf or sprintf


 From Documentation/filesystems/sysfs.txt:
  show() must not use snprintf() when formatting the value to be
  returned to user space. If you can guarantee that an overflow
  will never happen you can use sprintf() otherwise you must use
  scnprintf().

Generated by: scripts/coccinelle/api/device_attr_show.cocci

Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   52cd5f9c22eeef26d05f9d9338ba4eb38f14dd3a
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 3 hours ago
:::::: commit date: 5 months ago

Please take the patch only if it's a positive warning. Thanks!

 ltc4261.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/hwmon/ltc4261.c
+++ b/drivers/hwmon/ltc4261.c
@@ -130,7 +130,7 @@ static ssize_t ltc4261_value_show(struct
 		return PTR_ERR(data);
 
 	value = ltc4261_get_value(data, attr->index);
-	return snprintf(buf, PAGE_SIZE, "%d\n", value);
+	return scnprintf(buf, PAGE_SIZE, "%d\n", value);
 }
 
 static ssize_t ltc4261_bool_show(struct device *dev,
@@ -147,7 +147,7 @@ static ssize_t ltc4261_bool_show(struct
 	if (fault)		/* Clear reported faults in chip register */
 		i2c_smbus_write_byte_data(data->client, LTC4261_FAULT, ~fault);
 
-	return snprintf(buf, PAGE_SIZE, "%d\n", fault ? 1 : 0);
+	return scnprintf(buf, PAGE_SIZE, "%d\n", fault ? 1 : 0);
 }
 
 /*

[PATCH] coccinelle: api: fix device_attr_show.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2138 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Richard Cochran <richardcochran@gmail.com>
CC: netdev(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/ptp/ptp_sysfs.c:16:8-16: WARNING: use scnprintf or sprintf
drivers/ptp/ptp_sysfs.c:230:8-16: WARNING: use scnprintf or sprintf


 From Documentation/filesystems/sysfs.txt:
  show() must not use snprintf() when formatting the value to be
  returned to user space. If you can guarantee that an overflow
  will never happen you can use sprintf() otherwise you must use
  scnprintf().

Generated by: scripts/coccinelle/api/device_attr_show.cocci

Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   52cd5f9c22eeef26d05f9d9338ba4eb38f14dd3a
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 3 hours ago
:::::: commit date: 5 months ago

Please take the patch only if it's a positive warning. Thanks!

 ptp_sysfs.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/ptp/ptp_sysfs.c
+++ b/drivers/ptp/ptp_sysfs.c
@@ -13,7 +13,7 @@ static ssize_t clock_name_show(struct de
 			       struct device_attribute *attr, char *page)
 {
 	struct ptp_clock *ptp = dev_get_drvdata(dev);
-	return snprintf(page, PAGE_SIZE-1, "%s\n", ptp->info->name);
+	return scnprintf(page, PAGE_SIZE-1, "%s\n", ptp->info->name);
 }
 static DEVICE_ATTR_RO(clock_name);
 
@@ -227,7 +227,7 @@ static ssize_t ptp_pin_show(struct devic
 
 	mutex_unlock(&ptp->pincfg_mux);
 
-	return snprintf(page, PAGE_SIZE, "%u %u\n", func, chan);
+	return scnprintf(page, PAGE_SIZE, "%u %u\n", func, chan);
 }
 
 static ssize_t ptp_pin_store(struct device *dev, struct device_attribute *attr,

[PATCH] coccinelle: api: fix device_attr_show.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 4773 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Jean Delvare <jdelvare@suse.com>
CC: Guenter Roeck <linux@roeck-us.net>
CC: linux-hwmon(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/hwmon/sch5636.c:275:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:261:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:247:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:187:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:179:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:163:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:230:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:216:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:202:8-16: WARNING: use scnprintf or sprintf


 From Documentation/filesystems/sysfs.txt:
  show() must not use snprintf() when formatting the value to be
  returned to user space. If you can guarantee that an overflow
  will never happen you can use sprintf() otherwise you must use
  scnprintf().

Generated by: scripts/coccinelle/api/device_attr_show.cocci

Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   52cd5f9c22eeef26d05f9d9338ba4eb38f14dd3a
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 3 hours ago
:::::: commit date: 5 months ago

Please take the patch only if it's a positive warning. Thanks!

 sch5636.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

--- a/drivers/hwmon/sch5636.c
+++ b/drivers/hwmon/sch5636.c
@@ -160,7 +160,7 @@ static int reg_to_rpm(u16 reg)
 static ssize_t name_show(struct device *dev, struct device_attribute *devattr,
 			 char *buf)
 {
-	return snprintf(buf, PAGE_SIZE, "%s\n", DEVNAME);
+	return scnprintf(buf, PAGE_SIZE, "%s\n", DEVNAME);
 }
 
 static ssize_t in_value_show(struct device *dev,
@@ -176,7 +176,7 @@ static ssize_t in_value_show(struct devi
 	val = DIV_ROUND_CLOSEST(
 		data->in[attr->index] * SCH5636_REG_IN_FACTORS[attr->index],
 		255);
-	return snprintf(buf, PAGE_SIZE, "%d\n", val);
+	return scnprintf(buf, PAGE_SIZE, "%d\n", val);
 }
 
 static ssize_t in_label_show(struct device *dev,
@@ -184,7 +184,7 @@ static ssize_t in_label_show(struct devi
 {
 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
 
-	return snprintf(buf, PAGE_SIZE, "%s\n",
+	return scnprintf(buf, PAGE_SIZE, "%s\n",
 			SCH5636_IN_LABELS[attr->index]);
 }
 
@@ -199,7 +199,7 @@ static ssize_t temp_value_show(struct de
 		return PTR_ERR(data);
 
 	val = (data->temp_val[attr->index] - 64) * 1000;
-	return snprintf(buf, PAGE_SIZE, "%d\n", val);
+	return scnprintf(buf, PAGE_SIZE, "%d\n", val);
 }
 
 static ssize_t temp_fault_show(struct device *dev,
@@ -213,7 +213,7 @@ static ssize_t temp_fault_show(struct de
 		return PTR_ERR(data);
 
 	val = (data->temp_ctrl[attr->index] & SCH5636_TEMP_WORKING) ? 0 : 1;
-	return snprintf(buf, PAGE_SIZE, "%d\n", val);
+	return scnprintf(buf, PAGE_SIZE, "%d\n", val);
 }
 
 static ssize_t temp_alarm_show(struct device *dev,
@@ -227,7 +227,7 @@ static ssize_t temp_alarm_show(struct de
 		return PTR_ERR(data);
 
 	val = (data->temp_ctrl[attr->index] & SCH5636_TEMP_ALARM) ? 1 : 0;
-	return snprintf(buf, PAGE_SIZE, "%d\n", val);
+	return scnprintf(buf, PAGE_SIZE, "%d\n", val);
 }
 
 static ssize_t fan_value_show(struct device *dev,
@@ -244,7 +244,7 @@ static ssize_t fan_value_show(struct dev
 	if (val < 0)
 		return val;
 
-	return snprintf(buf, PAGE_SIZE, "%d\n", val);
+	return scnprintf(buf, PAGE_SIZE, "%d\n", val);
 }
 
 static ssize_t fan_fault_show(struct device *dev,
@@ -258,7 +258,7 @@ static ssize_t fan_fault_show(struct dev
 		return PTR_ERR(data);
 
 	val = (data->fan_ctrl[attr->index] & SCH5636_FAN_NOT_PRESENT) ? 1 : 0;
-	return snprintf(buf, PAGE_SIZE, "%d\n", val);
+	return scnprintf(buf, PAGE_SIZE, "%d\n", val);
 }
 
 static ssize_t fan_alarm_show(struct device *dev,
@@ -272,7 +272,7 @@ static ssize_t fan_alarm_show(struct dev
 		return PTR_ERR(data);
 
 	val = (data->fan_ctrl[attr->index] & SCH5636_FAN_ALARM) ? 1 : 0;
-	return snprintf(buf, PAGE_SIZE, "%d\n", val);
+	return scnprintf(buf, PAGE_SIZE, "%d\n", val);
 }
 
 static struct sensor_device_attribute sch5636_attr[] = {

[PATCH] coccinelle: api: fix device_attr_show.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1815 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
CC: dri-devel(a)lists.freedesktop.org
CC: linux-fbdev(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/video/fbdev/sm501fb.c:1169:8-16: WARNING: use scnprintf or sprintf


 From Documentation/filesystems/sysfs.txt:
  show() must not use snprintf() when formatting the value to be
  returned to user space. If you can guarantee that an overflow
  will never happen you can use sprintf() otherwise you must use
  scnprintf().

Generated by: scripts/coccinelle/api/device_attr_show.cocci

Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   52cd5f9c22eeef26d05f9d9338ba4eb38f14dd3a
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 3 hours ago
:::::: commit date: 5 months ago

Please take the patch only if it's a positive warning. Thanks!

 sm501fb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/video/fbdev/sm501fb.c
+++ b/drivers/video/fbdev/sm501fb.c
@@ -1166,7 +1166,7 @@ static ssize_t sm501fb_crtsrc_show(struc
 	ctrl = smc501_readl(info->regs + SM501_DC_CRT_CONTROL);
 	ctrl &= SM501_DC_CRT_CONTROL_SEL;
 
-	return snprintf(buf, PAGE_SIZE, "%s\n", ctrl ? "crt" : "panel");
+	return scnprintf(buf, PAGE_SIZE, "%s\n", ctrl ? "crt" : "panel");
 }
 
 /* sm501fb_crtsrc_show

[PATCH] coccinelle: api: fix device_attr_show.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3940 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Michal Januszewski <spock@gentoo.org>
CC: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
CC: linux-fbdev(a)vger.kernel.org
CC: dri-devel(a)lists.freedesktop.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/video/fbdev/uvesafb.c:1640:8-16: WARNING: use scnprintf or sprintf
drivers/video/fbdev/uvesafb.c:1626:9-17: WARNING: use scnprintf or sprintf
drivers/video/fbdev/uvesafb.c:1596:9-17: WARNING: use scnprintf or sprintf
drivers/video/fbdev/uvesafb.c:1611:9-17: WARNING: use scnprintf or sprintf
drivers/video/fbdev/uvesafb.c:1550:8-16: WARNING: use scnprintf or sprintf
drivers/video/fbdev/uvesafb.c:1581:9-17: WARNING: use scnprintf or sprintf


 From Documentation/filesystems/sysfs.txt:
  show() must not use snprintf() when formatting the value to be
  returned to user space. If you can guarantee that an overflow
  will never happen you can use sprintf() otherwise you must use
  scnprintf().

Generated by: scripts/coccinelle/api/device_attr_show.cocci

Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   52cd5f9c22eeef26d05f9d9338ba4eb38f14dd3a
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 3 hours ago
:::::: commit date: 5 months ago

Please take the patch only if it's a positive warning. Thanks!

 uvesafb.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

--- a/drivers/video/fbdev/uvesafb.c
+++ b/drivers/video/fbdev/uvesafb.c
@@ -1547,7 +1547,7 @@ static ssize_t uvesafb_show_vbe_ver(stru
 	struct fb_info *info = dev_get_drvdata(dev);
 	struct uvesafb_par *par = info->par;
 
-	return snprintf(buf, PAGE_SIZE, "%.4x\n", par->vbe_ib.vbe_version);
+	return scnprintf(buf, PAGE_SIZE, "%.4x\n", par->vbe_ib.vbe_version);
 }
 
 static DEVICE_ATTR(vbe_version, S_IRUGO, uvesafb_show_vbe_ver, NULL);
@@ -1578,7 +1578,7 @@ static ssize_t uvesafb_show_vendor(struc
 	struct uvesafb_par *par = info->par;
 
 	if (par->vbe_ib.oem_vendor_name_ptr)
-		return snprintf(buf, PAGE_SIZE, "%s\n", (char *)
+		return scnprintf(buf, PAGE_SIZE, "%s\n", (char *)
 			(&par->vbe_ib) + par->vbe_ib.oem_vendor_name_ptr);
 	else
 		return 0;
@@ -1593,7 +1593,7 @@ static ssize_t uvesafb_show_product_name
 	struct uvesafb_par *par = info->par;
 
 	if (par->vbe_ib.oem_product_name_ptr)
-		return snprintf(buf, PAGE_SIZE, "%s\n", (char *)
+		return scnprintf(buf, PAGE_SIZE, "%s\n", (char *)
 			(&par->vbe_ib) + par->vbe_ib.oem_product_name_ptr);
 	else
 		return 0;
@@ -1608,7 +1608,7 @@ static ssize_t uvesafb_show_product_rev(
 	struct uvesafb_par *par = info->par;
 
 	if (par->vbe_ib.oem_product_rev_ptr)
-		return snprintf(buf, PAGE_SIZE, "%s\n", (char *)
+		return scnprintf(buf, PAGE_SIZE, "%s\n", (char *)
 			(&par->vbe_ib) + par->vbe_ib.oem_product_rev_ptr);
 	else
 		return 0;
@@ -1623,7 +1623,7 @@ static ssize_t uvesafb_show_oem_string(s
 	struct uvesafb_par *par = info->par;
 
 	if (par->vbe_ib.oem_string_ptr)
-		return snprintf(buf, PAGE_SIZE, "%s\n",
+		return scnprintf(buf, PAGE_SIZE, "%s\n",
 			(char *)(&par->vbe_ib) + par->vbe_ib.oem_string_ptr);
 	else
 		return 0;
@@ -1637,7 +1637,7 @@ static ssize_t uvesafb_show_nocrtc(struc
 	struct fb_info *info = dev_get_drvdata(dev);
 	struct uvesafb_par *par = info->par;
 
-	return snprintf(buf, PAGE_SIZE, "%d\n", par->nocrtc);
+	return scnprintf(buf, PAGE_SIZE, "%d\n", par->nocrtc);
 }
 
 static ssize_t uvesafb_store_nocrtc(struct device *dev,

[PATCH] coccinelle: api: fix device_attr_show.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2042 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Pablo Neira Ayuso <pablo@netfilter.org>
CC: Jozsef Kadlecsik <kadlec@netfilter.org>
CC: Florian Westphal <fw@strlen.de>
CC: Jakub Kicinski <kuba@kernel.org>
CC: netfilter-devel(a)vger.kernel.org
CC: coreteam(a)netfilter.org
CC: netdev(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

net/netfilter/xt_IDLETIMER.c:88:9-17: WARNING: use scnprintf or sprintf


 From Documentation/filesystems/sysfs.txt:
  show() must not use snprintf() when formatting the value to be
  returned to user space. If you can guarantee that an overflow
  will never happen you can use sprintf() otherwise you must use
  scnprintf().

Generated by: scripts/coccinelle/api/device_attr_show.cocci

Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   52cd5f9c22eeef26d05f9d9338ba4eb38f14dd3a
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 3 hours ago
:::::: commit date: 5 months ago

Please take the patch only if it's a positive warning. Thanks!

 xt_IDLETIMER.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/net/netfilter/xt_IDLETIMER.c
+++ b/net/netfilter/xt_IDLETIMER.c
@@ -85,9 +85,9 @@ static ssize_t idletimer_tg_show(struct
 	mutex_unlock(&list_mutex);
 
 	if (time_after(expires, jiffies) || ktimespec.tv_sec > 0)
-		return snprintf(buf, PAGE_SIZE, "%ld\n", time_diff);
+		return scnprintf(buf, PAGE_SIZE, "%ld\n", time_diff);
 
-	return snprintf(buf, PAGE_SIZE, "0\n");
+	return scnprintf(buf, PAGE_SIZE, "0\n");
 }
 
 static void idletimer_tg_work(struct work_struct *work)

drivers/edac/edac_mc_sysfs.c:210:8-16: WARNING: use scnprintf or sprintf

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2399 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   9c7d619be5a002ea29c172df5e3c1227c22cbb41
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
date:   4 weeks ago
:::::: branch date: 10 hours ago
:::::: commit date: 4 weeks ago
config: x86_64-randconfig-c002-20200901 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/edac/edac_mc_sysfs.c:210:8-16: WARNING: use scnprintf or sprintf
   drivers/edac/edac_mc_sysfs.c:490:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/fsi/fsi-master-gpio.c:720:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/hwmon/sch5627.c:275:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5627.c:288:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5627.c:263:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5627.c:312:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5627.c:304:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5627.c:198:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5627.c:246:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5627.c:224:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5627.c:235:8-16: WARNING: use scnprintf or sprintf
   drivers/hwmon/sch5627.c:212:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/video/fbdev/uvesafb.c:1640:8-16: WARNING: use scnprintf or sprintf
   drivers/video/fbdev/uvesafb.c:1626:9-17: WARNING: use scnprintf or sprintf
   drivers/video/fbdev/uvesafb.c:1596:9-17: WARNING: use scnprintf or sprintf
   drivers/video/fbdev/uvesafb.c:1611:9-17: WARNING: use scnprintf or sprintf
   drivers/video/fbdev/uvesafb.c:1550:8-16: WARNING: use scnprintf or sprintf
   drivers/video/fbdev/uvesafb.c:1581:9-17: WARNING: use scnprintf or sprintf

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35293 bytes --]