* [PATCH] pinctrl: ralink: rt2880: fix '-Wmissing-prototypes' in init function
@ 2020-12-28 6:47 Sergio Paracuellos
2021-01-04 14:40 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Sergio Paracuellos @ 2020-12-28 6:47 UTC (permalink / raw)
To: linus.walleij
Cc: linux-gpio, gregkh, yanaijie, neil, linux-kernel, kernel test robot
Kernel test robot reported the following warning:
'warning: no previous prototype for 'rt2880_pinmux_init''.
This function is the entry point for the platform driver and
it is private to this driver. Hence declare it 'static' which is
the correct thing to do fixing also this warning.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
Hi Linus,
Just a note to let you know that this patch is rebased on the top of this
series which are pending to be applied:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2020-December/149353.html
Thanks in advance for your time!
Best regards,
Sergio Paracuellos
drivers/pinctrl/ralink/pinctrl-rt2880.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/ralink/pinctrl-rt2880.c b/drivers/pinctrl/ralink/pinctrl-rt2880.c
index 983da62ff3be..1f8e8d5b71fd 100644
--- a/drivers/pinctrl/ralink/pinctrl-rt2880.c
+++ b/drivers/pinctrl/ralink/pinctrl-rt2880.c
@@ -361,7 +361,7 @@ static struct platform_driver rt2880_pinmux_driver = {
},
};
-int __init rt2880_pinmux_init(void)
+static int __init rt2880_pinmux_init(void)
{
return platform_driver_register(&rt2880_pinmux_driver);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: ralink: rt2880: fix '-Wmissing-prototypes' in init function
2020-12-28 6:47 [PATCH] pinctrl: ralink: rt2880: fix '-Wmissing-prototypes' in init function Sergio Paracuellos
@ 2021-01-04 14:40 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2021-01-04 14:40 UTC (permalink / raw)
To: Sergio Paracuellos
Cc: open list:GPIO SUBSYSTEM, Greg KH, Jason Yan, NeilBrown,
linux-kernel, kernel test robot
On Mon, Dec 28, 2020 at 7:47 AM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:
> Kernel test robot reported the following warning:
> 'warning: no previous prototype for 'rt2880_pinmux_init''.
> This function is the entry point for the platform driver and
> it is private to this driver. Hence declare it 'static' which is
> the correct thing to do fixing also this warning.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-04 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-28 6:47 [PATCH] pinctrl: ralink: rt2880: fix '-Wmissing-prototypes' in init function Sergio Paracuellos
2021-01-04 14:40 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.