* [PATCH] perf record: Tweak "Lowering..." warning in record_opts__config_freq
@ 2020-12-28 3:19 Hans-Peter Nilsson
2020-12-28 15:25 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Hans-Peter Nilsson @ 2020-12-28 3:19 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Adrian Hunter, Kan Liang, Ian Rogers
That is, instead of "Lowering default frequency rate to <F>" say
"Lowering default frequency rate from <f> to <F>", specifying
the overridden default frequency <f>, so you don't have to grep
through the source to "remember" that was e.g. 4000.
Signed-off-by: Hans-Peter Nilsson <hp@axis.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
---
tools/perf/util/record.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/record.c b/tools/perf/util/record.c
index 07e4b96a6625..3b38e7be10da 100644
--- a/tools/perf/util/record.c
+++ b/tools/perf/util/record.c
@@ -202,10 +202,10 @@ static int record_opts__config_freq(struct record_opts *opts)
* Default frequency is over current maximum.
*/
if (max_rate < opts->freq) {
- pr_warning("Lowering default frequency rate to %u.\n"
+ pr_warning("Lowering default frequency rate from %u to %u.\n"
"Please consider tweaking "
"/proc/sys/kernel/perf_event_max_sample_rate.\n",
- max_rate);
+ opts->freq, max_rate);
opts->freq = max_rate;
}
--
2.11.0
brgds, H-P
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf record: Tweak "Lowering..." warning in record_opts__config_freq
2020-12-28 3:19 [PATCH] perf record: Tweak "Lowering..." warning in record_opts__config_freq Hans-Peter Nilsson
@ 2020-12-28 15:25 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-12-28 15:25 UTC (permalink / raw)
To: Hans-Peter Nilsson
Cc: linux-kernel, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, Adrian Hunter,
Kan Liang, Ian Rogers
Em Mon, Dec 28, 2020 at 04:19:08AM +0100, Hans-Peter Nilsson escreveu:
> That is, instead of "Lowering default frequency rate to <F>" say
> "Lowering default frequency rate from <f> to <F>", specifying
> the overridden default frequency <f>, so you don't have to grep
> through the source to "remember" that was e.g. 4000.
Thanks, applied.
- Arnaldo
> Signed-off-by: Hans-Peter Nilsson <hp@axis.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Kan Liang <kan.liang@linux.intel.com>
> Cc: Ian Rogers <irogers@google.com>
> ---
> tools/perf/util/record.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/record.c b/tools/perf/util/record.c
> index 07e4b96a6625..3b38e7be10da 100644
> --- a/tools/perf/util/record.c
> +++ b/tools/perf/util/record.c
> @@ -202,10 +202,10 @@ static int record_opts__config_freq(struct record_opts *opts)
> * Default frequency is over current maximum.
> */
> if (max_rate < opts->freq) {
> - pr_warning("Lowering default frequency rate to %u.\n"
> + pr_warning("Lowering default frequency rate from %u to %u.\n"
> "Please consider tweaking "
> "/proc/sys/kernel/perf_event_max_sample_rate.\n",
> - max_rate);
> + opts->freq, max_rate);
> opts->freq = max_rate;
> }
>
> --
> 2.11.0
>
> brgds, H-P
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-28 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-28 3:19 [PATCH] perf record: Tweak "Lowering..." warning in record_opts__config_freq Hans-Peter Nilsson
2020-12-28 15:25 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.