* [Buildroot] [PATCH v2 0/2 ] package/timescaledb: Don't build with postgresql 13
@ 2020-12-29 9:52 Maxim Kochetkov
2020-12-29 9:52 ` [Buildroot] [PATCH 1/2] package/postgresql: allow to select postgresql version Maxim Kochetkov
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Maxim Kochetkov @ 2020-12-29 9:52 UTC (permalink / raw)
To: buildroot
TimescaleDB is not supporting postgresql 13 at the moment.
Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
---
changes in v2:
- Hide version selection in "if BR2_PACKAGE_POSTGRESQL" block
Maxim Kochetkov (2):
package/postgresql: allow to select postgresql version
package/timescaledb: add dependency on postgresql 12
package/postgresql/Config.in | 24 ++++++++++++++++++++++++
package/postgresql/postgresql.hash | 3 +++
package/postgresql/postgresql.mk | 2 +-
package/timescaledb/Config.in | 1 +
4 files changed, 29 insertions(+), 1 deletion(-)
--
2.29.2
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/2] package/postgresql: allow to select postgresql version 2020-12-29 9:52 [Buildroot] [PATCH v2 0/2 ] package/timescaledb: Don't build with postgresql 13 Maxim Kochetkov @ 2020-12-29 9:52 ` Maxim Kochetkov 2020-12-29 17:49 ` Yann E. MORIN 2020-12-29 9:52 ` [Buildroot] [PATCH 2/2] package/timescaledb: add dependency on postgresql 12 Maxim Kochetkov 2020-12-29 17:46 ` [Buildroot] [PATCH v2 0/2 ] package/timescaledb: Don't build with postgresql 13 Yann E. MORIN 2 siblings, 1 reply; 5+ messages in thread From: Maxim Kochetkov @ 2020-12-29 9:52 UTC (permalink / raw) To: buildroot Some packages (like timescaledb) needs older version of PostgreSQL. Another use case is supporting older database format. PostgreSQL can't automatically upgrade database to next major version. Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru> --- package/postgresql/Config.in | 24 ++++++++++++++++++++++++ package/postgresql/postgresql.hash | 3 +++ package/postgresql/postgresql.mk | 2 +- 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/package/postgresql/Config.in b/package/postgresql/Config.in index 2f677daf5b..aa9b28dcb3 100644 --- a/package/postgresql/Config.in +++ b/package/postgresql/Config.in @@ -22,3 +22,27 @@ config BR2_PACKAGE_POSTGRESQL comment "postgresql needs a toolchain w/ dynamic library, wchar" depends on BR2_USE_MMU depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR + +if BR2_PACKAGE_POSTGRESQL + +choice + prompt "PostgreSQL Version" + default BR2_POSTGRESQL_VERSION_12 + help + Select the version of postgresql you wish to use. + +config BR2_POSTGRESQL_VERSION_12 + bool "postgresql 12" + +config BR2_POSTGRESQL_VERSION_13 + bool "postgresql 13" + +endchoice + +config BR2_POSTGRESQL_VERSION + string + default "12.5" if BR2_POSTGRESQL_VERSION_12 + default "13.1" if BR2_POSTGRESQL_VERSION_13 + depends on BR2_PACKAGE_POSTGRESQL + +endif diff --git a/package/postgresql/postgresql.hash b/package/postgresql/postgresql.hash index ef676cccc4..ed61e79a09 100644 --- a/package/postgresql/postgresql.hash +++ b/package/postgresql/postgresql.hash @@ -1,5 +1,8 @@ # From https://ftp.postgresql.org/pub/source/v13.1/postgresql-13.1.tar.bz2.sha256 sha256 12345c83b89aa29808568977f5200d6da00f88a035517f925293355432ffe61f postgresql-13.1.tar.bz2 +# From https://ftp.postgresql.org/pub/source/v13.1/postgresql-12.5.tar.bz2.sha256 +sha256 bd0d25341d9578b5473c9506300022de26370879581f5fddd243a886ce79ff95 postgresql-12.5.tar.bz2 + # License file, Locally calculated sha256 739e5d454d81d31a482469338b7c856f1f5c6b4cdda1551cea6f0f6d18eef62c COPYRIGHT diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk index 98361c00c8..09f226bd85 100644 --- a/package/postgresql/postgresql.mk +++ b/package/postgresql/postgresql.mk @@ -4,7 +4,7 @@ # ################################################################################ -POSTGRESQL_VERSION = 13.1 +POSTGRESQL_VERSION = $(call qstrip,$(BR2_POSTGRESQL_VERSION)) POSTGRESQL_SOURCE = postgresql-$(POSTGRESQL_VERSION).tar.bz2 POSTGRESQL_SITE = https://ftp.postgresql.org/pub/source/v$(POSTGRESQL_VERSION) POSTGRESQL_LICENSE = PostgreSQL -- 2.29.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] package/postgresql: allow to select postgresql version 2020-12-29 9:52 ` [Buildroot] [PATCH 1/2] package/postgresql: allow to select postgresql version Maxim Kochetkov @ 2020-12-29 17:49 ` Yann E. MORIN 0 siblings, 0 replies; 5+ messages in thread From: Yann E. MORIN @ 2020-12-29 17:49 UTC (permalink / raw) To: buildroot Maxim, All, On 2020-12-29 12:52 +0300, Maxim Kochetkov via buildroot spake thusly: > Some packages (like timescaledb) needs older version of PostgreSQL. As replied to the cover letter: what about bumping tiemscaledb? > Another use case is supporting older database format. PostgreSQL can't > automatically upgrade database to next major version. There are a lot of other packages that may require migrating data when upgrading; we can't have a version choice for all those. So, I've marked this patch, and follosing, as Changes Requested in our patchwork. Regards, Yann E. MORIN. > Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru> > --- > package/postgresql/Config.in | 24 ++++++++++++++++++++++++ > package/postgresql/postgresql.hash | 3 +++ > package/postgresql/postgresql.mk | 2 +- > 3 files changed, 28 insertions(+), 1 deletion(-) > > diff --git a/package/postgresql/Config.in b/package/postgresql/Config.in > index 2f677daf5b..aa9b28dcb3 100644 > --- a/package/postgresql/Config.in > +++ b/package/postgresql/Config.in > @@ -22,3 +22,27 @@ config BR2_PACKAGE_POSTGRESQL > comment "postgresql needs a toolchain w/ dynamic library, wchar" > depends on BR2_USE_MMU > depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR > + > +if BR2_PACKAGE_POSTGRESQL > + > +choice > + prompt "PostgreSQL Version" > + default BR2_POSTGRESQL_VERSION_12 > + help > + Select the version of postgresql you wish to use. > + > +config BR2_POSTGRESQL_VERSION_12 > + bool "postgresql 12" > + > +config BR2_POSTGRESQL_VERSION_13 > + bool "postgresql 13" > + > +endchoice > + > +config BR2_POSTGRESQL_VERSION > + string > + default "12.5" if BR2_POSTGRESQL_VERSION_12 > + default "13.1" if BR2_POSTGRESQL_VERSION_13 > + depends on BR2_PACKAGE_POSTGRESQL > + > +endif > diff --git a/package/postgresql/postgresql.hash b/package/postgresql/postgresql.hash > index ef676cccc4..ed61e79a09 100644 > --- a/package/postgresql/postgresql.hash > +++ b/package/postgresql/postgresql.hash > @@ -1,5 +1,8 @@ > # From https://ftp.postgresql.org/pub/source/v13.1/postgresql-13.1.tar.bz2.sha256 > sha256 12345c83b89aa29808568977f5200d6da00f88a035517f925293355432ffe61f postgresql-13.1.tar.bz2 > > +# From https://ftp.postgresql.org/pub/source/v13.1/postgresql-12.5.tar.bz2.sha256 > +sha256 bd0d25341d9578b5473c9506300022de26370879581f5fddd243a886ce79ff95 postgresql-12.5.tar.bz2 > + > # License file, Locally calculated > sha256 739e5d454d81d31a482469338b7c856f1f5c6b4cdda1551cea6f0f6d18eef62c COPYRIGHT > diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk > index 98361c00c8..09f226bd85 100644 > --- a/package/postgresql/postgresql.mk > +++ b/package/postgresql/postgresql.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -POSTGRESQL_VERSION = 13.1 > +POSTGRESQL_VERSION = $(call qstrip,$(BR2_POSTGRESQL_VERSION)) > POSTGRESQL_SOURCE = postgresql-$(POSTGRESQL_VERSION).tar.bz2 > POSTGRESQL_SITE = https://ftp.postgresql.org/pub/source/v$(POSTGRESQL_VERSION) > POSTGRESQL_LICENSE = PostgreSQL > -- > 2.29.2 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] package/timescaledb: add dependency on postgresql 12 2020-12-29 9:52 [Buildroot] [PATCH v2 0/2 ] package/timescaledb: Don't build with postgresql 13 Maxim Kochetkov 2020-12-29 9:52 ` [Buildroot] [PATCH 1/2] package/postgresql: allow to select postgresql version Maxim Kochetkov @ 2020-12-29 9:52 ` Maxim Kochetkov 2020-12-29 17:46 ` [Buildroot] [PATCH v2 0/2 ] package/timescaledb: Don't build with postgresql 13 Yann E. MORIN 2 siblings, 0 replies; 5+ messages in thread From: Maxim Kochetkov @ 2020-12-29 9:52 UTC (permalink / raw) To: buildroot TimescaleDB 1.7.4 does not support postgresql 13. PostgreSQL 12 must be selected to build timescaledb. Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru> --- package/timescaledb/Config.in | 1 + 1 file changed, 1 insertion(+) diff --git a/package/timescaledb/Config.in b/package/timescaledb/Config.in index af4a868527..f0e1c2e9b2 100644 --- a/package/timescaledb/Config.in +++ b/package/timescaledb/Config.in @@ -1,6 +1,7 @@ config BR2_PACKAGE_TIMESCALEDB bool "timescaledb" depends on BR2_PACKAGE_POSTGRESQL + depends on BR2_POSTGRESQL_VERSION_12 help TimescaleDB is an open-source database designed to make SQL scalable for time-series data. -- 2.29.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 0/2 ] package/timescaledb: Don't build with postgresql 13 2020-12-29 9:52 [Buildroot] [PATCH v2 0/2 ] package/timescaledb: Don't build with postgresql 13 Maxim Kochetkov 2020-12-29 9:52 ` [Buildroot] [PATCH 1/2] package/postgresql: allow to select postgresql version Maxim Kochetkov 2020-12-29 9:52 ` [Buildroot] [PATCH 2/2] package/timescaledb: add dependency on postgresql 12 Maxim Kochetkov @ 2020-12-29 17:46 ` Yann E. MORIN 2 siblings, 0 replies; 5+ messages in thread From: Yann E. MORIN @ 2020-12-29 17:46 UTC (permalink / raw) To: buildroot Maxim, All, On 2020-12-29 12:52 +0300, Maxim Kochetkov via buildroot spake thusly: > TimescaleDB is not supporting postgresql 13 at the moment. What about bumping timescaledb to version 2.0.0, which carries the following patches, and thus should ahve PG13 support: 21dc9b9c1a30 Allow building against PG13 source 002510cb01e1 Add compatibilty wrapper functions for base64 encoding/decoding be8dd086a089 Add missing utils/acl.h includes We are otherwise trying hard to not have a version choice, except in very special cases (hardware support, bootloaders, incomaptible APIs, etc...), so I would prefer that we carry a few upstream patches if updating timescaledb is not possible. Regards, Yann E. MORIN. > Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru> > --- > changes in v2: > - Hide version selection in "if BR2_PACKAGE_POSTGRESQL" block > > Maxim Kochetkov (2): > package/postgresql: allow to select postgresql version > package/timescaledb: add dependency on postgresql 12 > > package/postgresql/Config.in | 24 ++++++++++++++++++++++++ > package/postgresql/postgresql.hash | 3 +++ > package/postgresql/postgresql.mk | 2 +- > package/timescaledb/Config.in | 1 + > 4 files changed, 29 insertions(+), 1 deletion(-) > > -- > 2.29.2 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-29 17:49 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-12-29 9:52 [Buildroot] [PATCH v2 0/2 ] package/timescaledb: Don't build with postgresql 13 Maxim Kochetkov 2020-12-29 9:52 ` [Buildroot] [PATCH 1/2] package/postgresql: allow to select postgresql version Maxim Kochetkov 2020-12-29 17:49 ` Yann E. MORIN 2020-12-29 9:52 ` [Buildroot] [PATCH 2/2] package/timescaledb: add dependency on postgresql 12 Maxim Kochetkov 2020-12-29 17:46 ` [Buildroot] [PATCH v2 0/2 ] package/timescaledb: Don't build with postgresql 13 Yann E. MORIN
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.