All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/1] package/tpm2-pkcs11: new package
@ 2020-12-22 10:32 Yair Ben-Avraham
  2020-12-29 20:00 ` Yann E. MORIN
  0 siblings, 1 reply; 2+ messages in thread
From: Yair Ben-Avraham @ 2020-12-22 10:32 UTC (permalink / raw)
  To: buildroot

A PKCS#11 interface for TPM2 hardware

Signed-off-by: Yair Ben-Avraham <yairba@protonmail.com>
---
 DEVELOPERS                           |  1 +
 package/Config.in                    |  1 +
 package/tpm2-pkcs11/Config.in        | 15 ++++++++++
 package/tpm2-pkcs11/tpm2-pkcs11.hash |  3 ++
 package/tpm2-pkcs11/tpm2-pkcs11.mk   | 42 ++++++++++++++++++++++++++++
 5 files changed, 62 insertions(+)
 create mode 100644 package/tpm2-pkcs11/Config.in
 create mode 100644 package/tpm2-pkcs11/tpm2-pkcs11.hash
 create mode 100644 package/tpm2-pkcs11/tpm2-pkcs11.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index d0b4cd7531..11f20a1c49 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2687,6 +2687,7 @@ F:	package/fwup/

 N:	Yair Ben Avraham <yairba@protonmail.com>
 F:	package/gloox/
+F:	package/tpm2-pkcs11/

 N:	Yann E. MORIN <yann.morin.1998@free.fr>
 F:	board/friendlyarm/nanopi-neo/
diff --git a/package/Config.in b/package/Config.in
index c3677dd15e..43a7549841 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1363,6 +1363,7 @@ menu "Crypto"
 	source "package/pkcs11-helper/Config.in"
 	source "package/rhash/Config.in"
 	source "package/tinydtls/Config.in"
+	source "package/tpm2-pkcs11/Config.in"
 	source "package/tpm2-tss/Config.in"
 	source "package/trousers/Config.in"
 	source "package/ustream-ssl/Config.in"
diff --git a/package/tpm2-pkcs11/Config.in b/package/tpm2-pkcs11/Config.in
new file mode 100644
index 0000000000..ab7ad02480
--- /dev/null
+++ b/package/tpm2-pkcs11/Config.in
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_TPM2_PKCS11
+	bool "tpm2-pkcs11"
+	depends on !BR2_STATIC_LIBS # tpm2-tss
+	select BR2_PACKAGE_LIBYAML
+	select BR2_PACKAGE_P11_KIT
+	select BR2_PACKAGE_SQLITE
+	select BR2_PACKAGE_TPM2_TOOLS
+	select BR2_PACKAGE_TPM2_TSS
+	help
+	  A PKCS#11 interface for TPM2 hardware
+
+	  https://github.com/tpm2-software/tpm2-pkcs11
+
+comment "tpm2-pkcs11 needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
diff --git a/package/tpm2-pkcs11/tpm2-pkcs11.hash b/package/tpm2-pkcs11/tpm2-pkcs11.hash
new file mode 100644
index 0000000000..16dd9166ba
--- /dev/null
+++ b/package/tpm2-pkcs11/tpm2-pkcs11.hash
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256  13425c34358ec798d333743099b9aec5e42f6a4653c4c0e40eb075681f369687  tpm2-pkcs11-1.5.0.tar.gz
+sha256  793aa007f793458434d7cc60b1c827053a399308658b32fcaa6023802adc22e1  LICENSE
diff --git a/package/tpm2-pkcs11/tpm2-pkcs11.mk b/package/tpm2-pkcs11/tpm2-pkcs11.mk
new file mode 100644
index 0000000000..14ff1e4e07
--- /dev/null
+++ b/package/tpm2-pkcs11/tpm2-pkcs11.mk
@@ -0,0 +1,42 @@
+################################################################################
+#
+# tpm2-pkcs11
+#
+################################################################################
+
+TPM2_PKCS11_VERSION = 1.5.0
+TPM2_PKCS11_SITE = https://github.com/tpm2-software/tpm2-pkcs11/releases/download/$(TPM2_PKCS11_VERSION)
+TPM2_PKCS11_LICENSE = BSD-2-Clause
+TPM2_PKCS11_LICENSE_FILES = LICENSE
+TPM2_PKCS11_DEPENDENCIES = libyaml p11-kit sqlite tpm2-tools tpm2-tss
+
+TPM2_PKCS11_CONF_OPTS += \
+		--disable-hardening \
+		--with-p11kitconfigdir=/../usr/share/p11-kit/modules
+
+# Fix tpm.c:746:5: error: 'for' loop initial declarations are only allowed in C99 mode
+# Fix implicit declaration of function 'strnlen'
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM),y)
+TPM2_PKCS11_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -std=gnu99"
+endif
+
+# do not build man pages
+TPM2_PKCS11_CONF_ENV += ac_cv_prog_PANDOC=''
+
+ifeq ($(BR2_PACKAGE_TPM2_TOOLS),y)
+TPM2_PKCS11_CONF_ENV += \
+	ac_cv_prog_tpm2_createprimary=yes \
+	ac_cv_prog_tpm2_create=yes \
+	ac_cv_prog_tpm2_evictcontrol=yes \
+	ac_cv_prog_tpm2_readpublic=yes \
+	ac_cv_prog_tpm2_load=yes \
+	ac_cv_prog_tpm2_loadexternal=yes \
+	ac_cv_prog_tpm2_unseal=yes \
+	ac_cv_prog_tpm2_encryptdecrypt=yes \
+	ac_cv_prog_tpm2_sign=yes \
+	ac_cv_prog_tpm2_getcap=yes \
+	ac_cv_prog_tpm2_import=yes \
+	ac_cv_prog_tpm2_changeauth=yes
+endif
+
+$(eval $(autotools-package))
--
2.20.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/tpm2-pkcs11: new package
  2020-12-22 10:32 [Buildroot] [PATCH v2 1/1] package/tpm2-pkcs11: new package Yair Ben-Avraham
@ 2020-12-29 20:00 ` Yann E. MORIN
  0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2020-12-29 20:00 UTC (permalink / raw)
  To: buildroot

Yair, All,

On 2020-12-22 10:32 +0000, Yair Ben-Avraham via buildroot spake thusly:
> A PKCS#11 interface for TPM2 hardware
> 
> Signed-off-by: Yair Ben-Avraham <yairba@protonmail.com>
[--SNIP--]
> diff --git a/package/tpm2-pkcs11/Config.in b/package/tpm2-pkcs11/Config.in
> new file mode 100644
> index 0000000000..ab7ad02480
> --- /dev/null
> +++ b/package/tpm2-pkcs11/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_TPM2_PKCS11
> +	bool "tpm2-pkcs11"
> +	depends on !BR2_STATIC_LIBS # tpm2-tss
> +	select BR2_PACKAGE_LIBYAML
> +	select BR2_PACKAGE_P11_KIT
> +	select BR2_PACKAGE_SQLITE
> +	select BR2_PACKAGE_TPM2_TOOLS
> +	select BR2_PACKAGE_TPM2_TSS

You need to propagate the dependencies of all the packages you select:

    p11-kit depends on !static, MMU, and threads

When you propagate a dependency from two packages, you should add both
to the comment:

    depends on !BR2_STATIC_LIBS # tpm2-tss, p11-kit

> +	help
> +	  A PKCS#11 interface for TPM2 hardware
> +
> +	  https://github.com/tpm2-software/tpm2-pkcs11
> +
> +comment "tpm2-pkcs11 needs a toolchain w/ dynamic library"
> +	depends on BR2_STATIC_LIBS
> diff --git a/package/tpm2-pkcs11/tpm2-pkcs11.hash b/package/tpm2-pkcs11/tpm2-pkcs11.hash
> new file mode 100644
> index 0000000000..16dd9166ba
> --- /dev/null
> +++ b/package/tpm2-pkcs11/tpm2-pkcs11.hash
> @@ -0,0 +1,3 @@
> +# Locally computed:
> +sha256  13425c34358ec798d333743099b9aec5e42f6a4653c4c0e40eb075681f369687  tpm2-pkcs11-1.5.0.tar.gz
> +sha256  793aa007f793458434d7cc60b1c827053a399308658b32fcaa6023802adc22e1  LICENSE
> diff --git a/package/tpm2-pkcs11/tpm2-pkcs11.mk b/package/tpm2-pkcs11/tpm2-pkcs11.mk
> new file mode 100644
> index 0000000000..14ff1e4e07
> --- /dev/null
> +++ b/package/tpm2-pkcs11/tpm2-pkcs11.mk
> @@ -0,0 +1,42 @@
> +################################################################################
> +#
> +# tpm2-pkcs11
> +#
> +################################################################################
> +
> +TPM2_PKCS11_VERSION = 1.5.0
> +TPM2_PKCS11_SITE = https://github.com/tpm2-software/tpm2-pkcs11/releases/download/$(TPM2_PKCS11_VERSION)
> +TPM2_PKCS11_LICENSE = BSD-2-Clause
> +TPM2_PKCS11_LICENSE_FILES = LICENSE
> +TPM2_PKCS11_DEPENDENCIES = libyaml p11-kit sqlite tpm2-tools tpm2-tss
> +
> +TPM2_PKCS11_CONF_OPTS += \
> +		--disable-hardening \
> +		--with-p11kitconfigdir=/../usr/share/p11-kit/modules

Why the leading /../ ?

> +# Fix tpm.c:746:5: error: 'for' loop initial declarations are only allowed in C99 mode
> +# Fix implicit declaration of function 'strnlen'
> +ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM),y)
> +TPM2_PKCS11_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -std=gnu99"

Why does it only matter for the CS ARM toolchain?

> +endif
> +
> +# do not build man pages
> +TPM2_PKCS11_CONF_ENV += ac_cv_prog_PANDOC=''
> +
> +ifeq ($(BR2_PACKAGE_TPM2_TOOLS),y)
> +TPM2_PKCS11_CONF_ENV += \
> +	ac_cv_prog_tpm2_createprimary=yes \
> +	ac_cv_prog_tpm2_create=yes \
> +	ac_cv_prog_tpm2_evictcontrol=yes \
> +	ac_cv_prog_tpm2_readpublic=yes \
> +	ac_cv_prog_tpm2_load=yes \
> +	ac_cv_prog_tpm2_loadexternal=yes \
> +	ac_cv_prog_tpm2_unseal=yes \
> +	ac_cv_prog_tpm2_encryptdecrypt=yes \
> +	ac_cv_prog_tpm2_sign=yes \
> +	ac_cv_prog_tpm2_getcap=yes \
> +	ac_cv_prog_tpm2_import=yes \
> +	ac_cv_prog_tpm2_changeauth=yes
> +endif

What are those for? A little blurb in the commit log would be nice...

Regards,
Yann E. MORIN.

> +$(eval $(autotools-package))
> --
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-29 20:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-22 10:32 [Buildroot] [PATCH v2 1/1] package/tpm2-pkcs11: new package Yair Ben-Avraham
2020-12-29 20:00 ` Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.