All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] initramfs: fix "Decoding failed"
@ 2020-12-30  5:59 Hongfei Shang
  0 siblings, 0 replies; only message in thread
From: Hongfei Shang @ 2020-12-30  5:59 UTC (permalink / raw)
  To: linux-kernel; +Cc: Hongfei Shang

From: Hongfei Shang <shanghongfei@kylinos.cn>

when initrd image file load in memory, it is align to 4 bytes,
so there are may be some padding bytes(<4),
should ignore these padding bytes and handle as normal end

before: (when size of initrd.img is: size%4 = 1, 2 or 3)
"Initramfs unpacking failed: Decoding failed"

after:
no error message

Signed-off-by: Hongfei Shang <shanghongfei@kylinos.cn>
---
 lib/decompress_unlz4.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lib/decompress_unlz4.c b/lib/decompress_unlz4.c
index c0cfcfd486be..7527f1541dfd 100644
--- a/lib/decompress_unlz4.c
+++ b/lib/decompress_unlz4.c
@@ -181,6 +181,14 @@ STATIC inline int INIT unlz4(u8 *input, long in_len,
 				goto exit_2;
 			}
 			inp += chunksize;
+
+			if (size < 4) {
+				unsigned int padding = 0;
+
+				memcpy(&padding, inp, size);
+				if (padding == 0)
+					break;
+			}
 		}
 	}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-30  6:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-30  5:59 [PATCH] initramfs: fix "Decoding failed" Hongfei Shang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.