* [PATCH] drm/amdgpu: correct releasing the same sdma fw repeatedly @ 2020-12-30 9:22 Jiansong Chen 2020-12-30 10:02 ` Zhang, Hawking 0 siblings, 1 reply; 3+ messages in thread From: Jiansong Chen @ 2020-12-30 9:22 UTC (permalink / raw) To: amd-gfx; +Cc: Jiansong Chen, Tao.Zhou1, Hawking.Zhang Same as sienna_cichlid, dimgrey_cavefish and navy_flounder reuse sdma0 fw for other instances, so free it only once. Signed-off-by: Jiansong Chen <Jiansong.Chen@amd.com> Change-Id: I9dda4a9b73e20243ee48f54d8f0c7593d7e7354b --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c index f1ba36a094da..6ac314c8be32 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c @@ -125,7 +125,8 @@ static void sdma_v5_2_destroy_inst_ctx(struct amdgpu_device *adev) release_firmware(adev->sdma.instance[i].fw); adev->sdma.instance[i].fw = NULL; - if (adev->asic_type == CHIP_SIENNA_CICHLID) + if (adev->asic_type >= CHIP_SIENNA_CICHLID && + adev->asic_type <= CHIP_DIMGREY_CAVEFISH) break; } -- 2.25.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amdgpu: correct releasing the same sdma fw repeatedly 2020-12-30 9:22 [PATCH] drm/amdgpu: correct releasing the same sdma fw repeatedly Jiansong Chen @ 2020-12-30 10:02 ` Zhang, Hawking 2020-12-30 10:07 ` Chen, Jiansong (Simon) 0 siblings, 1 reply; 3+ messages in thread From: Zhang, Hawking @ 2020-12-30 10:02 UTC (permalink / raw) To: Chen, Jiansong (Simon), amd-gfx; +Cc: Zhou1, Tao, Chen, Jiansong (Simon) [AMD Public Use] Shall we ignore this patch and wait for your latest fixes that remove the asic type check for sdma_v5_2. I agree with you that should be more reasonable approach. Regards, Hawking -----Original Message----- From: Jiansong Chen <Jiansong.Chen@amd.com> Sent: Wednesday, December 30, 2020 17:23 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao <Tao.Zhou1@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>; Chen, Jiansong (Simon) <Jiansong.Chen@amd.com> Subject: [PATCH] drm/amdgpu: correct releasing the same sdma fw repeatedly Same as sienna_cichlid, dimgrey_cavefish and navy_flounder reuse sdma0 fw for other instances, so free it only once. Signed-off-by: Jiansong Chen <Jiansong.Chen@amd.com> Change-Id: I9dda4a9b73e20243ee48f54d8f0c7593d7e7354b --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c index f1ba36a094da..6ac314c8be32 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c @@ -125,7 +125,8 @@ static void sdma_v5_2_destroy_inst_ctx(struct amdgpu_device *adev) release_firmware(adev->sdma.instance[i].fw); adev->sdma.instance[i].fw = NULL; - if (adev->asic_type == CHIP_SIENNA_CICHLID) + if (adev->asic_type >= CHIP_SIENNA_CICHLID && + adev->asic_type <= CHIP_DIMGREY_CAVEFISH) break; } -- 2.25.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amdgpu: correct releasing the same sdma fw repeatedly 2020-12-30 10:02 ` Zhang, Hawking @ 2020-12-30 10:07 ` Chen, Jiansong (Simon) 0 siblings, 0 replies; 3+ messages in thread From: Chen, Jiansong (Simon) @ 2020-12-30 10:07 UTC (permalink / raw) To: Zhang, Hawking, amd-gfx; +Cc: Zhou1, Tao Ok, I will send another patch. Regards, Jiansong -----Original Message----- From: Zhang, Hawking <Hawking.Zhang@amd.com> Sent: Wednesday, December 30, 2020 6:02 PM To: Chen, Jiansong (Simon) <Jiansong.Chen@amd.com>; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao <Tao.Zhou1@amd.com>; Chen, Jiansong (Simon) <Jiansong.Chen@amd.com> Subject: RE: [PATCH] drm/amdgpu: correct releasing the same sdma fw repeatedly [AMD Public Use] Shall we ignore this patch and wait for your latest fixes that remove the asic type check for sdma_v5_2. I agree with you that should be more reasonable approach. Regards, Hawking -----Original Message----- From: Jiansong Chen <Jiansong.Chen@amd.com> Sent: Wednesday, December 30, 2020 17:23 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao <Tao.Zhou1@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>; Chen, Jiansong (Simon) <Jiansong.Chen@amd.com> Subject: [PATCH] drm/amdgpu: correct releasing the same sdma fw repeatedly Same as sienna_cichlid, dimgrey_cavefish and navy_flounder reuse sdma0 fw for other instances, so free it only once. Signed-off-by: Jiansong Chen <Jiansong.Chen@amd.com> Change-Id: I9dda4a9b73e20243ee48f54d8f0c7593d7e7354b --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c index f1ba36a094da..6ac314c8be32 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c @@ -125,7 +125,8 @@ static void sdma_v5_2_destroy_inst_ctx(struct amdgpu_device *adev) release_firmware(adev->sdma.instance[i].fw); adev->sdma.instance[i].fw = NULL; - if (adev->asic_type == CHIP_SIENNA_CICHLID) + if (adev->asic_type >= CHIP_SIENNA_CICHLID && + adev->asic_type <= CHIP_DIMGREY_CAVEFISH) break; } -- 2.25.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-30 10:08 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-12-30 9:22 [PATCH] drm/amdgpu: correct releasing the same sdma fw repeatedly Jiansong Chen 2020-12-30 10:02 ` Zhang, Hawking 2020-12-30 10:07 ` Chen, Jiansong (Simon)
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.