[stable:linux-5.4.y 1860/4216] drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: warning: no previous prototype for function 'lpfc_defer_pt2pt_acc'

[stable:linux-5.4.y 1860/4216] drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: warning: no previous prototype for function 'lpfc_defer_pt2pt_acc'

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3903 bytes --]

Hi James,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.4.y
head:   dfce803cd87dc139cfe4da1a68a5b3585e9e47e7
commit: 6b8fbd9b2db056d888dc4f34f61c824faea659b3 [1860/4216] scsi: lpfc: Fix pt2pt discovery on SLI3 HBAs
config: x86_64-randconfig-r021-20201230 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 6b316febb4388764789677f81f03aff373ec35b2)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=6b8fbd9b2db056d888dc4f34f61c824faea659b3
        git remote add stable https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
        git fetch --no-tags stable linux-5.4.y
        git checkout 6b8fbd9b2db056d888dc4f34f61c824faea659b3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: warning: no previous prototype for function 'lpfc_defer_pt2pt_acc' [-Wmissing-prototypes]
   lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox)
   ^
   drivers/scsi/lpfc/lpfc_nportdisc.c:289:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void
   ^
   static 
   1 warning generated.


vim +/lpfc_defer_pt2pt_acc +290 drivers/scsi/lpfc/lpfc_nportdisc.c

   281	
   282	/* lpfc_defer_pt2pt_acc - Complete SLI3 pt2pt processing on link up
   283	 * @phba: pointer to lpfc hba data structure.
   284	 * @link_mbox: pointer to CONFIG_LINK mailbox object
   285	 *
   286	 * This routine is only called if we are SLI3, direct connect pt2pt
   287	 * mode and the remote NPort issues the PLOGI after link up.
   288	 */
   289	void
 > 290	lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox)
   291	{
   292		LPFC_MBOXQ_t *login_mbox;
   293		MAILBOX_t *mb = &link_mbox->u.mb;
   294		struct lpfc_iocbq *save_iocb;
   295		struct lpfc_nodelist *ndlp;
   296		int rc;
   297	
   298		ndlp = link_mbox->ctx_ndlp;
   299		login_mbox = link_mbox->context3;
   300		save_iocb = login_mbox->context3;
   301		link_mbox->context3 = NULL;
   302		login_mbox->context3 = NULL;
   303	
   304		/* Check for CONFIG_LINK error */
   305		if (mb->mbxStatus) {
   306			lpfc_printf_log(phba, KERN_ERR, LOG_DISCOVERY,
   307					"4575 CONFIG_LINK fails pt2pt discovery: %x\n",
   308					mb->mbxStatus);
   309			mempool_free(login_mbox, phba->mbox_mem_pool);
   310			mempool_free(link_mbox, phba->mbox_mem_pool);
   311			lpfc_sli_release_iocbq(phba, save_iocb);
   312			return;
   313		}
   314	
   315		/* Now that CONFIG_LINK completed, and our SID is configured,
   316		 * we can now proceed with sending the PLOGI ACC.
   317		 */
   318		rc = lpfc_els_rsp_acc(link_mbox->vport, ELS_CMD_PLOGI,
   319				      save_iocb, ndlp, login_mbox);
   320		if (rc) {
   321			lpfc_printf_log(phba, KERN_ERR, LOG_DISCOVERY,
   322					"4576 PLOGI ACC fails pt2pt discovery: %x\n",
   323					rc);
   324			mempool_free(login_mbox, phba->mbox_mem_pool);
   325		}
   326	
   327		mempool_free(link_mbox, phba->mbox_mem_pool);
   328		lpfc_sli_release_iocbq(phba, save_iocb);
   329	}
   330	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38275 bytes --]