* [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
@ 2021-01-02 16:44 Marek Vasut
2021-01-02 16:44 ` [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02 Marek Vasut
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Marek Vasut @ 2021-01-02 16:44 UTC (permalink / raw)
To: u-boot
The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
using output-low DT property leads to the GPIO being set high instead.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
---
arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
index 7f5cff49b70..59d13713d88 100644
--- a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
+++ b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
@@ -37,7 +37,7 @@
*/
usb-port-power {
gpio-hog;
- gpios = <13 GPIO_ACTIVE_LOW>;
+ gpios = <13 0>;
output-low;
line-name = "usb-port-power";
};
--
2.29.2
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02
2021-01-02 16:44 [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
@ 2021-01-02 16:44 ` Marek Vasut
2021-01-05 16:39 ` Patrice CHOTARD
2021-01-06 9:05 ` Patrick DELAUNAY
2021-01-05 13:55 ` [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
` (2 subsequent siblings)
3 siblings, 2 replies; 13+ messages in thread
From: Marek Vasut @ 2021-01-02 16:44 UTC (permalink / raw)
To: u-boot
The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
Since GPIO_ACTIVE_HIGH is defined as 0, this change only increases the
correctness of the DT.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
---
arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
index e8508aa4d5a..4948ccd4014 100644
--- a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
+++ b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
@@ -37,7 +37,7 @@
*/
usb-hub {
gpio-hog;
- gpios = <8 GPIO_ACTIVE_HIGH>;
+ gpios = <8 0>;
output-high;
line-name = "rs485-rx-en";
};
@@ -65,7 +65,7 @@
*/
usb-hub {
gpio-hog;
- gpios = <2 GPIO_ACTIVE_HIGH>;
+ gpios = <2 0>;
output-high;
line-name = "usb-hub-reset";
};
--
2.29.2
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
2021-01-02 16:44 [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
2021-01-02 16:44 ` [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02 Marek Vasut
@ 2021-01-05 13:55 ` Marek Vasut
2021-01-05 16:39 ` Patrice CHOTARD
2021-01-06 9:05 ` Patrick DELAUNAY
3 siblings, 0 replies; 13+ messages in thread
From: Marek Vasut @ 2021-01-05 13:55 UTC (permalink / raw)
To: u-boot
On 1/2/21 5:44 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
> using output-low DT property leads to the GPIO being set high instead.
+CC Tom
These two should be applied to 2021.01 as well, can you pick them ?
Thanks
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
2021-01-02 16:44 [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
2021-01-02 16:44 ` [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02 Marek Vasut
2021-01-05 13:55 ` [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
@ 2021-01-05 16:39 ` Patrice CHOTARD
2021-01-06 9:05 ` Patrick DELAUNAY
3 siblings, 0 replies; 13+ messages in thread
From: Patrice CHOTARD @ 2021-01-05 16:39 UTC (permalink / raw)
To: u-boot
Hi Marek
On 1/2/21 5:44 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
> using output-low DT property leads to the GPIO being set high instead.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
> index 7f5cff49b70..59d13713d88 100644
> --- a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
> +++ b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
> @@ -37,7 +37,7 @@
> */
> usb-port-power {
> gpio-hog;
> - gpios = <13 GPIO_ACTIVE_LOW>;
> + gpios = <13 0>;
> output-low;
> line-name = "usb-port-power";
> };
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02
2021-01-02 16:44 ` [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02 Marek Vasut
@ 2021-01-05 16:39 ` Patrice CHOTARD
2021-01-06 9:05 ` Patrick DELAUNAY
1 sibling, 0 replies; 13+ messages in thread
From: Patrice CHOTARD @ 2021-01-05 16:39 UTC (permalink / raw)
To: u-boot
Hi Marek
On 1/2/21 5:44 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Since GPIO_ACTIVE_HIGH is defined as 0, this change only increases the
> correctness of the DT.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
> index e8508aa4d5a..4948ccd4014 100644
> --- a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
> +++ b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
> @@ -37,7 +37,7 @@
> */
> usb-hub {
> gpio-hog;
> - gpios = <8 GPIO_ACTIVE_HIGH>;
> + gpios = <8 0>;
> output-high;
> line-name = "rs485-rx-en";
> };
> @@ -65,7 +65,7 @@
> */
> usb-hub {
> gpio-hog;
> - gpios = <2 GPIO_ACTIVE_HIGH>;
> + gpios = <2 0>;
> output-high;
> line-name = "usb-hub-reset";
> };
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02
2021-01-02 16:44 ` [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02 Marek Vasut
2021-01-05 16:39 ` Patrice CHOTARD
@ 2021-01-06 9:05 ` Patrick DELAUNAY
1 sibling, 0 replies; 13+ messages in thread
From: Patrick DELAUNAY @ 2021-01-06 9:05 UTC (permalink / raw)
To: u-boot
On 1/2/21 5:44 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Since GPIO_ACTIVE_HIGH is defined as 0, this change only increases the
> correctness of the DT.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
> index e8508aa4d5a..4948ccd4014 100644
> --- a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
> +++ b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
> @@ -37,7 +37,7 @@
> */
> usb-hub {
> gpio-hog;
> - gpios = <8 GPIO_ACTIVE_HIGH>;
> + gpios = <8 0>;
> output-high;
> line-name = "rs485-rx-en";
> };
> @@ -65,7 +65,7 @@
> */
> usb-hub {
> gpio-hog;
> - gpios = <2 GPIO_ACTIVE_HIGH>;
> + gpios = <2 0>;
> output-high;
> line-name = "usb-hub-reset";
> };
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Thanks
Patrick
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
2021-01-02 16:44 [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
` (2 preceding siblings ...)
2021-01-05 16:39 ` Patrice CHOTARD
@ 2021-01-06 9:05 ` Patrick DELAUNAY
3 siblings, 0 replies; 13+ messages in thread
From: Patrick DELAUNAY @ 2021-01-06 9:05 UTC (permalink / raw)
To: u-boot
Hi Marek,
On 1/2/21 5:44 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
> using output-low DT property leads to the GPIO being set high instead.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
> index 7f5cff49b70..59d13713d88 100644
> --- a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
> +++ b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
> @@ -37,7 +37,7 @@
> */
> usb-port-power {
> gpio-hog;
> - gpios = <13 GPIO_ACTIVE_LOW>;
> + gpios = <13 0>;
> output-low;
> line-name = "usb-port-power";
> };
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Thanks
Patrick
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
2021-01-14 17:13 ` Marek Vasut
@ 2021-01-14 17:37 ` Alexandre TORGUE
0 siblings, 0 replies; 13+ messages in thread
From: Alexandre TORGUE @ 2021-01-14 17:37 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel
Cc: Maxime Coquelin, linux-stm32, Alexandre Torgue, Patrick Delaunay,
Patrice Chotard
On 1/14/21 6:13 PM, Marek Vasut wrote:
> On 1/14/21 6:11 PM, Alexandre TORGUE wrote:
>>
>>
>> On 1/14/21 6:08 PM, Marek Vasut wrote:
>>> On 1/14/21 4:11 PM, Alexandre TORGUE wrote:
>>>> Hi Marek
>>>
>>> Hi,
>>>
>>> [...]
>>>
>>>>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>>> b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>>> index 25528a1c096f..757707766fa0 100644
>>>>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>>> @@ -49,7 +49,7 @@ &gpioa {
>>>>> */
>>>>> usb-port-power-hog {
>>>>
>>>> On my tree this node is "usb-port-power". Do you want to update the
>>>> node name too ? I can do it directly during the merge if you want.
>>>> (Note, it is the case for DRC02 hog update).
>>>
>>> Please pick "[PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM"
>>> first, then this patch should apply cleanly.
>>
>> Yes I just saw this one. It doesn't contain a fixes tag, I can add the
>> same than for other hog patches ?
>
> If that is OK with you, please do. Thanks
Done. Series applied on stm32-fixes.
Regards
Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
2021-01-14 17:11 ` Alexandre TORGUE
@ 2021-01-14 17:13 ` Marek Vasut
2021-01-14 17:37 ` Alexandre TORGUE
0 siblings, 1 reply; 13+ messages in thread
From: Marek Vasut @ 2021-01-14 17:13 UTC (permalink / raw)
To: Alexandre TORGUE, linux-arm-kernel
Cc: Maxime Coquelin, linux-stm32, Alexandre Torgue, Patrick Delaunay,
Patrice Chotard
On 1/14/21 6:11 PM, Alexandre TORGUE wrote:
>
>
> On 1/14/21 6:08 PM, Marek Vasut wrote:
>> On 1/14/21 4:11 PM, Alexandre TORGUE wrote:
>>> Hi Marek
>>
>> Hi,
>>
>> [...]
>>
>>>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>> b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>> index 25528a1c096f..757707766fa0 100644
>>>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>>> @@ -49,7 +49,7 @@ &gpioa {
>>>> */
>>>> usb-port-power-hog {
>>>
>>> On my tree this node is "usb-port-power". Do you want to update the
>>> node name too ? I can do it directly during the merge if you want.
>>> (Note, it is the case for DRC02 hog update).
>>
>> Please pick "[PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM"
>> first, then this patch should apply cleanly.
>
> Yes I just saw this one. It doesn't contain a fixes tag, I can add the
> same than for other hog patches ?
If that is OK with you, please do. Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
2021-01-14 17:08 ` Marek Vasut
@ 2021-01-14 17:11 ` Alexandre TORGUE
2021-01-14 17:13 ` Marek Vasut
0 siblings, 1 reply; 13+ messages in thread
From: Alexandre TORGUE @ 2021-01-14 17:11 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel
Cc: Maxime Coquelin, linux-stm32, Alexandre Torgue, Patrick Delaunay,
Patrice Chotard
On 1/14/21 6:08 PM, Marek Vasut wrote:
> On 1/14/21 4:11 PM, Alexandre TORGUE wrote:
>> Hi Marek
>
> Hi,
>
> [...]
>
>>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>> b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>> index 25528a1c096f..757707766fa0 100644
>>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>>> @@ -49,7 +49,7 @@ &gpioa {
>>> */
>>> usb-port-power-hog {
>>
>> On my tree this node is "usb-port-power". Do you want to update the
>> node name too ? I can do it directly during the merge if you want.
>> (Note, it is the case for DRC02 hog update).
>
> Please pick "[PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM"
> first, then this patch should apply cleanly.
Yes I just saw this one. It doesn't contain a fixes tag, I can add the
same than for other hog patches ?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
2021-01-14 15:11 ` Alexandre TORGUE
@ 2021-01-14 17:08 ` Marek Vasut
2021-01-14 17:11 ` Alexandre TORGUE
0 siblings, 1 reply; 13+ messages in thread
From: Marek Vasut @ 2021-01-14 17:08 UTC (permalink / raw)
To: Alexandre TORGUE, linux-arm-kernel
Cc: Maxime Coquelin, linux-stm32, Alexandre Torgue, Patrick Delaunay,
Patrice Chotard
On 1/14/21 4:11 PM, Alexandre TORGUE wrote:
> Hi Marek
Hi,
[...]
>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>> b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>> index 25528a1c096f..757707766fa0 100644
>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
>> @@ -49,7 +49,7 @@ &gpioa {
>> */
>> usb-port-power-hog {
>
> On my tree this node is "usb-port-power". Do you want to update the node
> name too ? I can do it directly during the merge if you want.
> (Note, it is the case for DRC02 hog update).
Please pick "[PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM"
first, then this patch should apply cleanly.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
2020-12-29 17:55 Marek Vasut
@ 2021-01-14 15:11 ` Alexandre TORGUE
2021-01-14 17:08 ` Marek Vasut
0 siblings, 1 reply; 13+ messages in thread
From: Alexandre TORGUE @ 2021-01-14 15:11 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel
Cc: Maxime Coquelin, linux-stm32, Alexandre Torgue, Patrick Delaunay,
Patrice Chotard
Hi Marek
On 12/29/20 6:55 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
> using output-low DT property leads to the GPIO being set high instead.
>
> Fixes: ac68793f49de ("ARM: dts: stm32: Add DHCOM based PicoITX board")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> index 25528a1c096f..757707766fa0 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> @@ -49,7 +49,7 @@ &gpioa {
> */
> usb-port-power-hog {
On my tree this node is "usb-port-power". Do you want to update the node
name too ? I can do it directly during the merge if you want.
(Note, it is the case for DRC02 hog update).
regards
alex
> gpio-hog;
> - gpios = <13 GPIO_ACTIVE_LOW>;
> + gpios = <13 0>;
> output-low;
> line-name = "usb-port-power";
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
@ 2020-12-29 17:55 Marek Vasut
2021-01-14 15:11 ` Alexandre TORGUE
0 siblings, 1 reply; 13+ messages in thread
From: Marek Vasut @ 2020-12-29 17:55 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Alexandre Torgue, Patrice Chotard, Patrick Delaunay,
Maxime Coquelin, linux-stm32
The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
using output-low DT property leads to the GPIO being set high instead.
Fixes: ac68793f49de ("ARM: dts: stm32: Add DHCOM based PicoITX board")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
---
arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
index 25528a1c096f..757707766fa0 100644
--- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
@@ -49,7 +49,7 @@ &gpioa {
*/
usb-port-power-hog {
gpio-hog;
- gpios = <13 GPIO_ACTIVE_LOW>;
+ gpios = <13 0>;
output-low;
line-name = "usb-port-power";
};
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-01-14 17:39 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-02 16:44 [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
2021-01-02 16:44 ` [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02 Marek Vasut
2021-01-05 16:39 ` Patrice CHOTARD
2021-01-06 9:05 ` Patrick DELAUNAY
2021-01-05 13:55 ` [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
2021-01-05 16:39 ` Patrice CHOTARD
2021-01-06 9:05 ` Patrick DELAUNAY
-- strict thread matches above, loose matches on Subject: below --
2020-12-29 17:55 Marek Vasut
2021-01-14 15:11 ` Alexandre TORGUE
2021-01-14 17:08 ` Marek Vasut
2021-01-14 17:11 ` Alexandre TORGUE
2021-01-14 17:13 ` Marek Vasut
2021-01-14 17:37 ` Alexandre TORGUE
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.