From: Herbert Xu <herbert@gondor.apana.org.au>
To: matthias.bgg@kernel.org
Cc: mpm@selenic.com, rjui@broadcom.com, sbranden@broadcom.com,
f.fainelli@gmail.com, linux-kernel@vger.kernel.org,
Julia.Lawall@inria.fr, bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, nsaenzjulienne@suse.de,
linux-crypto@vger.kernel.org,
Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block.
Date: Sun, 3 Jan 2021 09:08:32 +1100 [thread overview]
Message-ID: <20210102220832.GO12767@gondor.apana.org.au> (raw)
In-Reply-To: <20201218105708.28480-1-matthias.bgg@kernel.org>
On Fri, Dec 18, 2020 at 11:57:07AM +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> When trying to disable the block we bitwise or the control
> register with value zero. This is confusing as using bitwise or with
> value zero doesn't have any effect at all. Drop this as we already set
> the enable bit to zero by appling inverted RNG_RBGEN_MASK.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> ---
>
> Changes in v2:
> - fix commit message, dropping Fixes tag
> - drop inverted RNT_RBGEN_ENABLE in disable case
>
> drivers/char/hw_random/iproc-rng200.c | 3 ---
> 1 file changed, 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: matthias.bgg@kernel.org
Cc: f.fainelli@gmail.com, sbranden@broadcom.com, rjui@broadcom.com,
linux-kernel@vger.kernel.org, Julia.Lawall@inria.fr,
Matthias Brugger <mbrugger@suse.com>,
bcm-kernel-feedback-list@broadcom.com, nsaenzjulienne@suse.de,
mpm@selenic.com, linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block.
Date: Sun, 3 Jan 2021 09:08:32 +1100 [thread overview]
Message-ID: <20210102220832.GO12767@gondor.apana.org.au> (raw)
In-Reply-To: <20201218105708.28480-1-matthias.bgg@kernel.org>
On Fri, Dec 18, 2020 at 11:57:07AM +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> When trying to disable the block we bitwise or the control
> register with value zero. This is confusing as using bitwise or with
> value zero doesn't have any effect at all. Drop this as we already set
> the enable bit to zero by appling inverted RNG_RBGEN_MASK.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> ---
>
> Changes in v2:
> - fix commit message, dropping Fixes tag
> - drop inverted RNT_RBGEN_ENABLE in disable case
>
> drivers/char/hw_random/iproc-rng200.c | 3 ---
> 1 file changed, 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-02 22:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 10:57 [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block matthias.bgg
2020-12-18 10:57 ` matthias.bgg
2020-12-18 10:57 ` [PATCH v2 2/2] hwrng: iproc-rng200: Move enable/disable in separate function matthias.bgg
2020-12-18 10:57 ` matthias.bgg
2020-12-18 17:32 ` Scott Branden
2020-12-18 17:32 ` Scott Branden
2021-01-02 22:08 ` Herbert Xu
2021-01-02 22:08 ` Herbert Xu
2020-12-18 17:30 ` [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block Scott Branden
2020-12-18 17:30 ` Scott Branden
2020-12-18 17:34 ` Florian Fainelli
2020-12-18 17:34 ` Florian Fainelli
2021-01-02 22:08 ` Herbert Xu [this message]
2021-01-02 22:08 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210102220832.GO12767@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Julia.Lawall@inria.fr \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=mpm@selenic.com \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.