All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: fsl_aud2htx: select SND_SOC_IMX_PCM_DMA
@ 2021-01-03 13:53 ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2021-01-03 13:53 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Shengjiu Wang, Nicolin Chen
  Cc: Arnd Bergmann, Fabio Estevam, Viorel Suman, Matthias Schiffer,
	alsa-devel, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

The newly added driver requires DMA support and fails to build
when that is disabled:

aarch64-linux-ld: sound/soc/fsl/fsl_aud2htx.o: in function `fsl_aud2htx_probe':
fsl_aud2htx.c:(.text+0x3e0): undefined reference to `imx_pcm_dma_init'

Fixes: 8a24c834c053 ("ASoC: fsl_aud2htx: Add aud2htx module driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/soc/fsl/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 84db0b7b9d59..d7f30036d434 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -108,6 +108,7 @@ config SND_SOC_FSL_XCVR
 config SND_SOC_FSL_AUD2HTX
 	tristate "AUDIO TO HDMI TX module support"
 	depends on ARCH_MXC || COMPILE_TEST
+	select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n
 	help
 	  Say Y if you want to add AUDIO TO HDMI TX support for NXP.
 
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] ASoC: fsl_aud2htx: select SND_SOC_IMX_PCM_DMA
@ 2021-01-03 13:53 ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2021-01-03 13:53 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Shengjiu Wang, Nicolin Chen
  Cc: alsa-devel, Matthias Schiffer, Arnd Bergmann, linux-kernel,
	Viorel Suman, Fabio Estevam

From: Arnd Bergmann <arnd@arndb.de>

The newly added driver requires DMA support and fails to build
when that is disabled:

aarch64-linux-ld: sound/soc/fsl/fsl_aud2htx.o: in function `fsl_aud2htx_probe':
fsl_aud2htx.c:(.text+0x3e0): undefined reference to `imx_pcm_dma_init'

Fixes: 8a24c834c053 ("ASoC: fsl_aud2htx: Add aud2htx module driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/soc/fsl/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 84db0b7b9d59..d7f30036d434 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -108,6 +108,7 @@ config SND_SOC_FSL_XCVR
 config SND_SOC_FSL_AUD2HTX
 	tristate "AUDIO TO HDMI TX module support"
 	depends on ARCH_MXC || COMPILE_TEST
+	select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n
 	help
 	  Say Y if you want to add AUDIO TO HDMI TX support for NXP.
 
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: fsl_aud2htx: select SND_SOC_IMX_PCM_DMA
  2021-01-03 13:53 ` Arnd Bergmann
@ 2021-01-03 20:38   ` Nicolin Chen
  -1 siblings, 0 replies; 6+ messages in thread
From: Nicolin Chen @ 2021-01-03 20:38 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Shengjiu Wang, Arnd Bergmann, Fabio Estevam, Viorel Suman,
	Matthias Schiffer, alsa-devel, linux-kernel

On Sun, Jan 03, 2021 at 02:53:17PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added driver requires DMA support and fails to build
> when that is disabled:
> 
> aarch64-linux-ld: sound/soc/fsl/fsl_aud2htx.o: in function `fsl_aud2htx_probe':
> fsl_aud2htx.c:(.text+0x3e0): undefined reference to `imx_pcm_dma_init'
> 
> Fixes: 8a24c834c053 ("ASoC: fsl_aud2htx: Add aud2htx module driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: fsl_aud2htx: select SND_SOC_IMX_PCM_DMA
@ 2021-01-03 20:38   ` Nicolin Chen
  0 siblings, 0 replies; 6+ messages in thread
From: Nicolin Chen @ 2021-01-03 20:38 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: alsa-devel, Matthias Schiffer, Arnd Bergmann, linux-kernel,
	Shengjiu Wang, Takashi Iwai, Liam Girdwood, Mark Brown,
	Viorel Suman, Fabio Estevam

On Sun, Jan 03, 2021 at 02:53:17PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added driver requires DMA support and fails to build
> when that is disabled:
> 
> aarch64-linux-ld: sound/soc/fsl/fsl_aud2htx.o: in function `fsl_aud2htx_probe':
> fsl_aud2htx.c:(.text+0x3e0): undefined reference to `imx_pcm_dma_init'
> 
> Fixes: 8a24c834c053 ("ASoC: fsl_aud2htx: Add aud2htx module driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: fsl_aud2htx: select SND_SOC_IMX_PCM_DMA
  2021-01-03 13:53 ` Arnd Bergmann
@ 2021-01-04 17:39   ` Mark Brown
  -1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2021-01-04 17:39 UTC (permalink / raw)
  To: Shengjiu Wang, Liam Girdwood, Nicolin Chen, Jaroslav Kysela,
	Takashi Iwai, Arnd Bergmann
  Cc: Viorel Suman, linux-kernel, Arnd Bergmann, Fabio Estevam,
	Matthias Schiffer, alsa-devel

On Sun, 3 Jan 2021 14:53:17 +0100, Arnd Bergmann wrote:
> The newly added driver requires DMA support and fails to build
> when that is disabled:
> 
> aarch64-linux-ld: sound/soc/fsl/fsl_aud2htx.o: in function `fsl_aud2htx_probe':
> fsl_aud2htx.c:(.text+0x3e0): undefined reference to `imx_pcm_dma_init'

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: fsl_aud2htx: select SND_SOC_IMX_PCM_DMA
      commit: a1f31cc4e98e1833f53fd2c6e9a218d6b86f5388

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: fsl_aud2htx: select SND_SOC_IMX_PCM_DMA
@ 2021-01-04 17:39   ` Mark Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2021-01-04 17:39 UTC (permalink / raw)
  To: Shengjiu Wang, Liam Girdwood, Nicolin Chen, Jaroslav Kysela,
	Takashi Iwai, Arnd Bergmann
  Cc: alsa-devel, Matthias Schiffer, Arnd Bergmann, linux-kernel,
	Viorel Suman, Fabio Estevam

On Sun, 3 Jan 2021 14:53:17 +0100, Arnd Bergmann wrote:
> The newly added driver requires DMA support and fails to build
> when that is disabled:
> 
> aarch64-linux-ld: sound/soc/fsl/fsl_aud2htx.o: in function `fsl_aud2htx_probe':
> fsl_aud2htx.c:(.text+0x3e0): undefined reference to `imx_pcm_dma_init'

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: fsl_aud2htx: select SND_SOC_IMX_PCM_DMA
      commit: a1f31cc4e98e1833f53fd2c6e9a218d6b86f5388

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-04 17:41 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-03 13:53 [PATCH] ASoC: fsl_aud2htx: select SND_SOC_IMX_PCM_DMA Arnd Bergmann
2021-01-03 13:53 ` Arnd Bergmann
2021-01-03 20:38 ` Nicolin Chen
2021-01-03 20:38   ` Nicolin Chen
2021-01-04 17:39 ` Mark Brown
2021-01-04 17:39   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.