From: Jakub Kicinski <kuba@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Hauke Mehrtens <hauke@hauke-m.de>,
netdev@vger.kernel.org, vivien.didelot@gmail.com,
f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs
Date: Mon, 4 Jan 2021 13:52:37 -0800 [thread overview]
Message-ID: <20210104135237.064fba8e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAFBinCD7cOPZf8NpkhpRG2PiuMcjtqwxu7vQQoXULpCBbTCAoA@mail.gmail.com>
On Sun, 3 Jan 2021 03:12:21 +0100 Martin Blumenstingl wrote:
> Hi Andrew,
>
> On Sun, Jan 3, 2021 at 3:09 AM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Sun, Jan 03, 2021 at 02:25:43AM +0100, Martin Blumenstingl wrote:
> > > Enable GSWIP_MII_CFG_EN also for internal PHYs to make traffic flow.
> > > Without this the PHY link is detected properly and ethtool statistics
> > > for TX are increasing but there's no RX traffic coming in.
> > >
> > > Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> > > Cc: stable@vger.kernel.org
> >
> > Hi Martin
> >
> > No need to Cc: stable. David or Jakub will handle the backport to
> > stable. You should however set the subject to [PATCH net 1/2] and
> > base the patches on the net tree, not net-next.
> do you recommend re-sending these patches and changing the subject?
> the lantiq_gswip.c driver is identical in -net and -net-next and so
> the patch will apply fine in both cases
Resend is pretty much always a safe bet. But since as you said trees
are identical at the moment I made an exception applied as is :)
Thanks everyone!
next prev parent reply other threads:[~2021-01-04 21:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 1:25 [PATCH 0/2] net: dsa: lantiq_gswip: two fixes for -net/-stable Martin Blumenstingl
2021-01-03 1:25 ` [PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs Martin Blumenstingl
2021-01-03 1:35 ` Hauke Mehrtens
2021-01-03 2:09 ` Andrew Lunn
2021-01-03 2:12 ` Martin Blumenstingl
2021-01-04 21:52 ` Jakub Kicinski [this message]
2021-01-04 23:54 ` Martin Blumenstingl
2021-01-04 19:53 ` Florian Fainelli
2021-01-03 1:25 ` [PATCH 2/2] net: dsa: lantiq_gswip: Fix GSWIP_MII_CFG(p) register access Martin Blumenstingl
2021-01-03 1:36 ` Hauke Mehrtens
2021-01-04 19:58 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104135237.064fba8e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.