* [PATCH v2 -next] staging: vc04_services: use DEFINE_MUTEX() for mutex lock
@ 2020-12-24 13:25 ` Zheng Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Zheng Yongjun @ 2020-12-24 13:25 UTC (permalink / raw)
To: nsaenzjulienne, bcm-kernel-feedback-list, devel, linux-kernel
Cc: gregkh, Zheng Yongjun
mutex lock can be initialized automatically with DEFINE_MUTEX()
rather than explicitly calling mutex_init().
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
.../vc04_services/interface/vchiq_arm/vchiq_connected.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
index 79b75efa6868..864253866155 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
@@ -12,13 +12,12 @@ static int g_connected;
static int g_num_deferred_callbacks;
static VCHIQ_CONNECTED_CALLBACK_T g_deferred_callback[MAX_CALLBACKS];
static int g_once_init;
-static struct mutex g_connected_mutex;
+static DEFINE_MUTEX(g_connected_mutex);
/* Function to initialize our lock */
static void connected_init(void)
{
if (!g_once_init) {
- mutex_init(&g_connected_mutex);
g_once_init = 1;
}
}
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2 -next] staging: vc04_services: use DEFINE_MUTEX() for mutex lock
@ 2020-12-24 13:25 ` Zheng Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Zheng Yongjun @ 2020-12-24 13:25 UTC (permalink / raw)
To: nsaenzjulienne, bcm-kernel-feedback-list, devel, linux-kernel
Cc: gregkh, Zheng Yongjun
mutex lock can be initialized automatically with DEFINE_MUTEX()
rather than explicitly calling mutex_init().
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
.../vc04_services/interface/vchiq_arm/vchiq_connected.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
index 79b75efa6868..864253866155 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
@@ -12,13 +12,12 @@ static int g_connected;
static int g_num_deferred_callbacks;
static VCHIQ_CONNECTED_CALLBACK_T g_deferred_callback[MAX_CALLBACKS];
static int g_once_init;
-static struct mutex g_connected_mutex;
+static DEFINE_MUTEX(g_connected_mutex);
/* Function to initialize our lock */
static void connected_init(void)
{
if (!g_once_init) {
- mutex_init(&g_connected_mutex);
g_once_init = 1;
}
}
--
2.22.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 -next] staging: vc04_services: use DEFINE_MUTEX() for mutex lock
2020-12-24 13:25 ` Zheng Yongjun
@ 2021-01-04 14:14 ` Dan Carpenter
-1 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2021-01-04 14:14 UTC (permalink / raw)
To: Zheng Yongjun
Cc: nsaenzjulienne, bcm-kernel-feedback-list, devel, linux-kernel, gregkh
On Thu, Dec 24, 2020 at 09:25:28PM +0800, Zheng Yongjun wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_connected.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> index 79b75efa6868..864253866155 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> @@ -12,13 +12,12 @@ static int g_connected;
> static int g_num_deferred_callbacks;
> static VCHIQ_CONNECTED_CALLBACK_T g_deferred_callback[MAX_CALLBACKS];
> static int g_once_init;
> -static struct mutex g_connected_mutex;
> +static DEFINE_MUTEX(g_connected_mutex);
>
> /* Function to initialize our lock */
> static void connected_init(void)
> {
> if (!g_once_init) {
> - mutex_init(&g_connected_mutex);
> g_once_init = 1;
> }
Delete the extra curly braces.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 -next] staging: vc04_services: use DEFINE_MUTEX() for mutex lock
@ 2021-01-04 14:14 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2021-01-04 14:14 UTC (permalink / raw)
To: Zheng Yongjun
Cc: devel, gregkh, bcm-kernel-feedback-list, linux-kernel, nsaenzjulienne
On Thu, Dec 24, 2020 at 09:25:28PM +0800, Zheng Yongjun wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_connected.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> index 79b75efa6868..864253866155 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> @@ -12,13 +12,12 @@ static int g_connected;
> static int g_num_deferred_callbacks;
> static VCHIQ_CONNECTED_CALLBACK_T g_deferred_callback[MAX_CALLBACKS];
> static int g_once_init;
> -static struct mutex g_connected_mutex;
> +static DEFINE_MUTEX(g_connected_mutex);
>
> /* Function to initialize our lock */
> static void connected_init(void)
> {
> if (!g_once_init) {
> - mutex_init(&g_connected_mutex);
> g_once_init = 1;
> }
Delete the extra curly braces.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-04 14:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-24 13:25 [PATCH v2 -next] staging: vc04_services: use DEFINE_MUTEX() for mutex lock Zheng Yongjun
2020-12-24 13:25 ` Zheng Yongjun
2021-01-04 14:14 ` Dan Carpenter
2021-01-04 14:14 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.