* [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies
@ 2020-12-22 13:00 Marco Chiappero
2020-12-23 7:51 ` Herbert Xu
2020-12-23 18:39 ` Ard Biesheuvel
0 siblings, 2 replies; 9+ messages in thread
From: Marco Chiappero @ 2020-12-22 13:00 UTC (permalink / raw)
To: herbert
Cc: linux-crypto, qat-linux, giovanni.cabiddu, Marco Chiappero,
kernel test robot
This patch includes a missing dependency (CRYPTO_AES) which may
lead to an "undefined reference to `aes_expandkey'" linking error.
Fixes: 5106dfeaeabe ("crypto: qat - add AES-XTS support for QAT GEN4 devices")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Marco Chiappero <marco.chiappero@intel.com>
---
drivers/crypto/qat/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
index beb379b23dc3..846a3d90b41a 100644
--- a/drivers/crypto/qat/Kconfig
+++ b/drivers/crypto/qat/Kconfig
@@ -11,6 +11,7 @@ config CRYPTO_DEV_QAT
select CRYPTO_SHA1
select CRYPTO_SHA256
select CRYPTO_SHA512
+ select CRYPTO_AES
select FW_LOADER
config CRYPTO_DEV_QAT_DH895xCC
--
2.26.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies
2020-12-22 13:00 [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies Marco Chiappero
@ 2020-12-23 7:51 ` Herbert Xu
2020-12-23 18:39 ` Ard Biesheuvel
1 sibling, 0 replies; 9+ messages in thread
From: Herbert Xu @ 2020-12-23 7:51 UTC (permalink / raw)
To: Marco Chiappero
Cc: linux-crypto, qat-linux, giovanni.cabiddu, kernel test robot
On Tue, Dec 22, 2020 at 01:00:24PM +0000, Marco Chiappero wrote:
> This patch includes a missing dependency (CRYPTO_AES) which may
> lead to an "undefined reference to `aes_expandkey'" linking error.
>
> Fixes: 5106dfeaeabe ("crypto: qat - add AES-XTS support for QAT GEN4 devices")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Marco Chiappero <marco.chiappero@intel.com>
> ---
> drivers/crypto/qat/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies
2020-12-22 13:00 [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies Marco Chiappero
2020-12-23 7:51 ` Herbert Xu
@ 2020-12-23 18:39 ` Ard Biesheuvel
2020-12-23 20:57 ` Herbert Xu
2021-01-04 15:17 ` [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies Chiappero, Marco
1 sibling, 2 replies; 9+ messages in thread
From: Ard Biesheuvel @ 2020-12-23 18:39 UTC (permalink / raw)
To: Marco Chiappero
Cc: Herbert Xu, Linux Crypto Mailing List, qat-linux,
Giovanni Cabiddu, kernel test robot
On Tue, 22 Dec 2020 at 13:39, Marco Chiappero <marco.chiappero@intel.com> wrote:
>
> This patch includes a missing dependency (CRYPTO_AES) which may
> lead to an "undefined reference to `aes_expandkey'" linking error.
>
> Fixes: 5106dfeaeabe ("crypto: qat - add AES-XTS support for QAT GEN4 devices")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Marco Chiappero <marco.chiappero@intel.com>
> ---
> drivers/crypto/qat/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
> index beb379b23dc3..846a3d90b41a 100644
> --- a/drivers/crypto/qat/Kconfig
> +++ b/drivers/crypto/qat/Kconfig
> @@ -11,6 +11,7 @@ config CRYPTO_DEV_QAT
> select CRYPTO_SHA1
> select CRYPTO_SHA256
> select CRYPTO_SHA512
> + select CRYPTO_AES
> select FW_LOADER
>
> config CRYPTO_DEV_QAT_DH895xCC
> --
> 2.26.2
>
This should be 'select CRYPTO_LIB_AES'
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies
2020-12-23 18:39 ` Ard Biesheuvel
@ 2020-12-23 20:57 ` Herbert Xu
2021-01-04 15:35 ` [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig Marco Chiappero
2021-01-04 15:17 ` [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies Chiappero, Marco
1 sibling, 1 reply; 9+ messages in thread
From: Herbert Xu @ 2020-12-23 20:57 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: Marco Chiappero, Linux Crypto Mailing List, qat-linux,
Giovanni Cabiddu, kernel test robot
On Wed, Dec 23, 2020 at 07:39:46PM +0100, Ard Biesheuvel wrote:
>
> This should be 'select CRYPTO_LIB_AES'
Please send a follow-up. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies
2020-12-23 18:39 ` Ard Biesheuvel
2020-12-23 20:57 ` Herbert Xu
@ 2021-01-04 15:17 ` Chiappero, Marco
1 sibling, 0 replies; 9+ messages in thread
From: Chiappero, Marco @ 2021-01-04 15:17 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Herbert Xu, Linux Crypto Mailing List
> On Tue, 22 Dec 2020 at 13:39, Marco Chiappero <marco.chiappero@intel.com>
> wrote:
>
> > diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
> > index beb379b23dc3..846a3d90b41a 100644
> > --- a/drivers/crypto/qat/Kconfig
> > +++ b/drivers/crypto/qat/Kconfig
> > @@ -11,6 +11,7 @@ config CRYPTO_DEV_QAT
> > select CRYPTO_SHA1
> > select CRYPTO_SHA256
> > select CRYPTO_SHA512
> > + select CRYPTO_AES
> > select FW_LOADER
> >
> > config CRYPTO_DEV_QAT_DH895xCC
> > --
> > 2.26.2
> >
>
> This should be 'select CRYPTO_LIB_AES'
Thank you for bringing this up.
Regards,
Marco
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig
2020-12-23 20:57 ` Herbert Xu
@ 2021-01-04 15:35 ` Marco Chiappero
2021-01-04 15:48 ` Ard Biesheuvel
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Marco Chiappero @ 2021-01-04 15:35 UTC (permalink / raw)
To: herbert
Cc: linux-crypto, qat-linux, giovanni.cabiddu, Marco Chiappero,
Ard Biesheuvel
Use CRYPTO_LIB_AES in place of CRYPTO_AES in the dependences for the QAT
common code.
Fixes: c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")
Reported-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Marco Chiappero <marco.chiappero@intel.com>
---
drivers/crypto/qat/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
index 846a3d90b41a..77783feb62b2 100644
--- a/drivers/crypto/qat/Kconfig
+++ b/drivers/crypto/qat/Kconfig
@@ -11,7 +11,7 @@ config CRYPTO_DEV_QAT
select CRYPTO_SHA1
select CRYPTO_SHA256
select CRYPTO_SHA512
- select CRYPTO_AES
+ select CRYPTO_LIB_AES
select FW_LOADER
config CRYPTO_DEV_QAT_DH895xCC
--
2.26.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig
2021-01-04 15:35 ` [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig Marco Chiappero
@ 2021-01-04 15:48 ` Ard Biesheuvel
2021-01-04 17:01 ` Giovanni Cabiddu
2021-01-14 6:46 ` Herbert Xu
2 siblings, 0 replies; 9+ messages in thread
From: Ard Biesheuvel @ 2021-01-04 15:48 UTC (permalink / raw)
To: Marco Chiappero
Cc: Herbert Xu, Linux Crypto Mailing List, qat-linux, Giovanni Cabiddu
On Mon, 4 Jan 2021 at 16:13, Marco Chiappero <marco.chiappero@intel.com> wrote:
>
> Use CRYPTO_LIB_AES in place of CRYPTO_AES in the dependences for the QAT
> common code.
>
> Fixes: c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")
> Reported-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Marco Chiappero <marco.chiappero@intel.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> drivers/crypto/qat/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
> index 846a3d90b41a..77783feb62b2 100644
> --- a/drivers/crypto/qat/Kconfig
> +++ b/drivers/crypto/qat/Kconfig
> @@ -11,7 +11,7 @@ config CRYPTO_DEV_QAT
> select CRYPTO_SHA1
> select CRYPTO_SHA256
> select CRYPTO_SHA512
> - select CRYPTO_AES
> + select CRYPTO_LIB_AES
> select FW_LOADER
>
> config CRYPTO_DEV_QAT_DH895xCC
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig
2021-01-04 15:35 ` [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig Marco Chiappero
2021-01-04 15:48 ` Ard Biesheuvel
@ 2021-01-04 17:01 ` Giovanni Cabiddu
2021-01-14 6:46 ` Herbert Xu
2 siblings, 0 replies; 9+ messages in thread
From: Giovanni Cabiddu @ 2021-01-04 17:01 UTC (permalink / raw)
To: Marco Chiappero; +Cc: herbert, linux-crypto, qat-linux, Ard Biesheuvel
On Mon, Jan 04, 2021 at 03:35:15PM +0000, Marco Chiappero wrote:
> Use CRYPTO_LIB_AES in place of CRYPTO_AES in the dependences for the QAT
> common code.
>
> Fixes: c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")
> Reported-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Marco Chiappero <marco.chiappero@intel.com>
Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
> drivers/crypto/qat/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
> index 846a3d90b41a..77783feb62b2 100644
> --- a/drivers/crypto/qat/Kconfig
> +++ b/drivers/crypto/qat/Kconfig
> @@ -11,7 +11,7 @@ config CRYPTO_DEV_QAT
> select CRYPTO_SHA1
> select CRYPTO_SHA256
> select CRYPTO_SHA512
> - select CRYPTO_AES
> + select CRYPTO_LIB_AES
> select FW_LOADER
>
> config CRYPTO_DEV_QAT_DH895xCC
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig
2021-01-04 15:35 ` [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig Marco Chiappero
2021-01-04 15:48 ` Ard Biesheuvel
2021-01-04 17:01 ` Giovanni Cabiddu
@ 2021-01-14 6:46 ` Herbert Xu
2 siblings, 0 replies; 9+ messages in thread
From: Herbert Xu @ 2021-01-14 6:46 UTC (permalink / raw)
To: Marco Chiappero; +Cc: linux-crypto, qat-linux, giovanni.cabiddu, Ard Biesheuvel
On Mon, Jan 04, 2021 at 03:35:15PM +0000, Marco Chiappero wrote:
> Use CRYPTO_LIB_AES in place of CRYPTO_AES in the dependences for the QAT
> common code.
>
> Fixes: c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")
> Reported-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Marco Chiappero <marco.chiappero@intel.com>
> ---
> drivers/crypto/qat/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-01-14 6:47 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-22 13:00 [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies Marco Chiappero
2020-12-23 7:51 ` Herbert Xu
2020-12-23 18:39 ` Ard Biesheuvel
2020-12-23 20:57 ` Herbert Xu
2021-01-04 15:35 ` [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig Marco Chiappero
2021-01-04 15:48 ` Ard Biesheuvel
2021-01-04 17:01 ` Giovanni Cabiddu
2021-01-14 6:46 ` Herbert Xu
2021-01-04 15:17 ` [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies Chiappero, Marco
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.