+ kasan-fix-incorrect-arguments-passing-in-kasan_add_zero_shadow.patch added to -mm tree

+ kasan-fix-incorrect-arguments-passing-in-kasan_add_zero_shadow.patch added to -mm tree

[akpm]

The patch titled
     Subject: kasan: fix incorrect arguments passing in kasan_add_zero_shadow
has been added to the -mm tree.  Its filename is
     kasan-fix-incorrect-arguments-passing-in-kasan_add_zero_shadow.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/kasan-fix-incorrect-arguments-passing-in-kasan_add_zero_shadow.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/kasan-fix-incorrect-arguments-passing-in-kasan_add_zero_shadow.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Lecopzer Chen <lecopzer@gmail.com>
Subject: kasan: fix incorrect arguments passing in kasan_add_zero_shadow

kasan_remove_zero_shadow() shall use original virtual address, start and
size, instead of shadow address.

Link: https://lkml.kernel.org/r/20210103063847.5963-1-lecopzer@gmail.com
Fixes: 0207df4fa1a86 ("kernel/memremap, kasan: make ZONE_DEVICE with work with KASAN")
Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Alexander Potapenko <glider@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/kasan/init.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/mm/kasan/init.c~kasan-fix-incorrect-arguments-passing-in-kasan_add_zero_shadow
+++ a/mm/kasan/init.c
@@ -485,7 +485,6 @@ int kasan_add_zero_shadow(void *start, u
 
 	ret = kasan_populate_early_shadow(shadow_start, shadow_end);
 	if (ret)
-		kasan_remove_zero_shadow(shadow_start,
-					size >> KASAN_SHADOW_SCALE_SHIFT);
+		kasan_remove_zero_shadow(start, size);
 	return ret;
 }
_

Patches currently in -mm which might be from lecopzer@gmail.com are

kasan-fix-unaligned-address-is-unhandled-in-kasan_remove_zero_shadow.patch
kasan-fix-incorrect-arguments-passing-in-kasan_add_zero_shadow.patch

Re: + kasan-fix-incorrect-arguments-passing-in-kasan_add_zero_shadow.patch added to -mm tree

[Andrew Morton]

On Mon, 04 Jan 2021 13:29:13 -0800 akpm@linux-foundation.org wrote:

> 
> From: Lecopzer Chen <lecopzer@gmail.com>
> Subject: kasan: fix incorrect arguments passing in kasan_add_zero_shadow
> 
> kasan_remove_zero_shadow() shall use original virtual address, start and
> size, instead of shadow address.
> 
> Link: https://lkml.kernel.org/r/20210103063847.5963-1-lecopzer@gmail.com
> Fixes: 0207df4fa1a86 ("kernel/memremap, kasan: make ZONE_DEVICE with work with KASAN")
> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> Cc: Alexander Potapenko <glider@google.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  mm/kasan/init.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/mm/kasan/init.c~kasan-fix-incorrect-arguments-passing-in-kasan_add_zero_shadow
> +++ a/mm/kasan/init.c
> @@ -485,7 +485,6 @@ int kasan_add_zero_shadow(void *start, u
>  
>  	ret = kasan_populate_early_shadow(shadow_start, shadow_end);
>  	if (ret)
> -		kasan_remove_zero_shadow(shadow_start,
> -					size >> KASAN_SHADOW_SCALE_SHIFT);
> +		kasan_remove_zero_shadow(start, size);
>  	return ret;
>  }

Reviewer input on this one, please?