From: "Michael S. Tsirkin" <mst@redhat.com> To: Xuan Zhuo <xuanzhuo@linux.alibaba.com> Cc: netdev@vger.kernel.org, dust.li@linux.alibaba.com, tonylu@linux.alibaba.com, "Jason Wang" <jasowang@redhat.com>, "David S. Miller" <davem@davemloft.net>, "Jakub Kicinski" <kuba@kernel.org>, "Björn Töpel" <bjorn.topel@intel.com>, "Magnus Karlsson" <magnus.karlsson@intel.com>, "Jonathan Lemon" <jonathan.lemon@gmail.com>, "Alexei Starovoitov" <ast@kernel.org>, "Daniel Borkmann" <daniel@iogearbox.net>, "Jesper Dangaard Brouer" <hawk@kernel.org>, "John Fastabend" <john.fastabend@gmail.com>, "Andrii Nakryiko" <andrii@kernel.org>, "Martin KaFai Lau" <kafai@fb.com>, "Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>, "KP Singh" <kpsingh@kernel.org>, "open list:VIRTIO CORE AND NET DRIVERS" <virtualization@lists.linux-foundation.org>, "open list" <linux-kernel@vger.kernel.org>, "open list:XDP SOCKETS (AF_XDP)" <bpf@vger.kernel.org> Subject: Re: [PATCH netdev 0/5] virtio-net support xdp socket zero copy xmit Date: Tue, 5 Jan 2021 07:25:11 -0500 [thread overview] Message-ID: <20210105072316-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <cover.1609837120.git.xuanzhuo@linux.alibaba.com> On Tue, Jan 05, 2021 at 05:11:38PM +0800, Xuan Zhuo wrote: > The first patch made some adjustments to xsk. > > The second patch itself can be used as an independent patch to solve the problem > that XDP may fail to load when the number of queues is insufficient. > > The third to last patch implements support for xsk in virtio-net. > > A practical problem with virtio is that tx interrupts are not very reliable. > There will always be some missing or delayed tx interrupts. Would appreciate a bit more data on this one. Is this a host bug? Device bug? Can we limit the work around somehow? > So I specially added > a point timer to solve this problem. Of course, considering performance issues, > The timer only triggers when the ring of the network card is full. > > Regarding the issue of virtio-net supporting xsk's zero copy rx, I am also > developing it, but I found that the modification may be relatively large, so I > consider this patch set to be separated from the code related to xsk zero copy > rx. > > Xuan Zhuo (5): > xsk: support get page for drv > virtio-net: support XDP_TX when not more queues > virtio-net, xsk: distinguish XDP_TX and XSK XMIT ctx > xsk, virtio-net: prepare for support xsk > virtio-net, xsk: virtio-net support xsk zero copy tx > > drivers/net/virtio_net.c | 643 +++++++++++++++++++++++++++++++++++++++----- > include/linux/netdevice.h | 1 + > include/net/xdp_sock_drv.h | 10 + > include/net/xsk_buff_pool.h | 1 + > net/xdp/xsk_buff_pool.c | 10 +- > 5 files changed, 597 insertions(+), 68 deletions(-) > > -- > 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Xuan Zhuo <xuanzhuo@linux.alibaba.com> Cc: "Song Liu" <songliubraving@fb.com>, "Martin KaFai Lau" <kafai@fb.com>, "open list" <linux-kernel@vger.kernel.org>, "Jesper Dangaard Brouer" <hawk@kernel.org>, "Daniel Borkmann" <daniel@iogearbox.net>, netdev@vger.kernel.org, "John Fastabend" <john.fastabend@gmail.com>, "Alexei Starovoitov" <ast@kernel.org>, "open list:VIRTIO CORE AND NET DRIVERS" <virtualization@lists.linux-foundation.org>, "Andrii Nakryiko" <andrii@kernel.org>, "Yonghong Song" <yhs@fb.com>, dust.li@linux.alibaba.com, "Jonathan Lemon" <jonathan.lemon@gmail.com>, "KP Singh" <kpsingh@kernel.org>, "Jakub Kicinski" <kuba@kernel.org>, "open list:XDP SOCKETS (AF_XDP)" <bpf@vger.kernel.org>, "Björn Töpel" <bjorn.topel@intel.com>, tonylu@linux.alibaba.com, "David S. Miller" <davem@davemloft.net>, "Magnus Karlsson" <magnus.karlsson@intel.com> Subject: Re: [PATCH netdev 0/5] virtio-net support xdp socket zero copy xmit Date: Tue, 5 Jan 2021 07:25:11 -0500 [thread overview] Message-ID: <20210105072316-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <cover.1609837120.git.xuanzhuo@linux.alibaba.com> On Tue, Jan 05, 2021 at 05:11:38PM +0800, Xuan Zhuo wrote: > The first patch made some adjustments to xsk. > > The second patch itself can be used as an independent patch to solve the problem > that XDP may fail to load when the number of queues is insufficient. > > The third to last patch implements support for xsk in virtio-net. > > A practical problem with virtio is that tx interrupts are not very reliable. > There will always be some missing or delayed tx interrupts. Would appreciate a bit more data on this one. Is this a host bug? Device bug? Can we limit the work around somehow? > So I specially added > a point timer to solve this problem. Of course, considering performance issues, > The timer only triggers when the ring of the network card is full. > > Regarding the issue of virtio-net supporting xsk's zero copy rx, I am also > developing it, but I found that the modification may be relatively large, so I > consider this patch set to be separated from the code related to xsk zero copy > rx. > > Xuan Zhuo (5): > xsk: support get page for drv > virtio-net: support XDP_TX when not more queues > virtio-net, xsk: distinguish XDP_TX and XSK XMIT ctx > xsk, virtio-net: prepare for support xsk > virtio-net, xsk: virtio-net support xsk zero copy tx > > drivers/net/virtio_net.c | 643 +++++++++++++++++++++++++++++++++++++++----- > include/linux/netdevice.h | 1 + > include/net/xdp_sock_drv.h | 10 + > include/net/xsk_buff_pool.h | 1 + > net/xdp/xsk_buff_pool.c | 10 +- > 5 files changed, 597 insertions(+), 68 deletions(-) > > -- > 1.8.3.1 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-01-05 12:27 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-05 9:11 [PATCH netdev 0/5] virtio-net support xdp socket zero copy xmit Xuan Zhuo 2021-01-05 9:11 ` [PATCH netdev 1/5] xsk: support get page for drv Xuan Zhuo 2021-01-05 9:11 ` [PATCH netdev 2/5] virtio-net: support XDP_TX when not more queues Xuan Zhuo 2021-01-05 9:11 ` [PATCH netdev 3/5] virtio-net, xsk: distinguish XDP_TX and XSK XMIT ctx Xuan Zhuo 2021-01-05 9:11 ` [PATCH netdev 4/5] xsk, virtio-net: prepare for support xsk Xuan Zhuo 2021-01-05 9:11 ` [PATCH netdev 5/5] virtio-net, xsk: virtio-net support xsk zero copy tx Xuan Zhuo 2021-01-05 13:19 ` kernel test robot 2021-01-05 13:19 ` kernel test robot 2021-01-05 13:21 ` Michael S. Tsirkin 2021-01-05 13:21 ` Michael S. Tsirkin 2021-01-05 13:25 ` [kbuild] " Dan Carpenter 2021-01-05 13:25 ` Dan Carpenter 2021-01-05 13:25 ` Dan Carpenter 2021-01-05 13:29 ` kernel test robot 2021-01-05 13:29 ` kernel test robot 2021-01-05 13:35 ` kernel test robot 2021-01-05 13:35 ` kernel test robot 2021-01-05 9:32 ` [PATCH netdev 0/5] virtio-net support xdp socket zero copy xmit Jason Wang 2021-01-05 9:32 ` Jason Wang 2021-01-05 12:25 ` Michael S. Tsirkin [this message] 2021-01-05 12:25 ` Michael S. Tsirkin 2021-01-16 2:59 ` [PATCH net-next v2 0/7] " Xuan Zhuo 2021-01-16 2:59 ` [PATCH net-next v2 1/7] xsk: support get page for drv Xuan Zhuo 2021-01-16 2:59 ` [PATCH net-next v2 2/7] virtio-net, xsk: distinguish XDP_TX and XSK XMIT ctx Xuan Zhuo 2021-01-18 6:45 ` Jason Wang 2021-01-18 6:45 ` Jason Wang 2021-01-16 2:59 ` [PATCH net-next v2 3/7] xsk, virtio-net: prepare for support xsk zerocopy xmit Xuan Zhuo 2021-01-16 2:59 ` [PATCH net-next v2 4/7] virtio-net, xsk: support xsk enable/disable Xuan Zhuo 2021-01-16 2:59 ` [PATCH net-next v2 5/7] virtio-net, xsk: realize the function of xsk packet sending Xuan Zhuo 2021-01-16 4:47 ` Jakub Kicinski 2021-01-18 9:10 ` Jason Wang 2021-01-18 9:10 ` Jason Wang 2021-01-18 12:27 ` Michael S. Tsirkin 2021-01-18 12:27 ` Michael S. Tsirkin 2021-01-16 2:59 ` [PATCH net-next v2 6/7] virtio-net, xsk: implement xsk wakeup callback Xuan Zhuo 2021-01-19 4:50 ` Jason Wang 2021-01-19 4:50 ` Jason Wang 2021-01-16 2:59 ` [PATCH net-next v2 7/7] virtio-net, xsk: set xsk completed when packet sent done Xuan Zhuo 2021-01-18 6:28 ` [PATCH net-next v2 0/7] virtio-net support xdp socket zero copy xmit Jason Wang 2021-01-18 6:28 ` Jason Wang [not found] <1609850555.8687568-1-xuanzhuo@linux.alibaba.com> 2021-01-06 2:46 ` [PATCH netdev 0/5] " Jason Wang 2021-01-06 2:46 ` Jason Wang [not found] <1609901717.683732-2-xuanzhuo@linux.alibaba.com> 2021-01-06 3:54 ` Jason Wang 2021-01-06 3:54 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210105072316-mutt-send-email-mst@kernel.org \ --to=mst@redhat.com \ --cc=andrii@kernel.org \ --cc=ast@kernel.org \ --cc=bjorn.topel@intel.com \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=dust.li@linux.alibaba.com \ --cc=hawk@kernel.org \ --cc=jasowang@redhat.com \ --cc=john.fastabend@gmail.com \ --cc=jonathan.lemon@gmail.com \ --cc=kafai@fb.com \ --cc=kpsingh@kernel.org \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=magnus.karlsson@intel.com \ --cc=netdev@vger.kernel.org \ --cc=songliubraving@fb.com \ --cc=tonylu@linux.alibaba.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=xuanzhuo@linux.alibaba.com \ --cc=yhs@fb.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.