All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH 6/7] qla2xxx: Enable NVME CONF (BIT_7) when enabling SLER
@ 2021-01-05  3:30 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-01-05  3:30 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 5982 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201223090422.16500-7-njavali@marvell.com>
References: <20201223090422.16500-7-njavali@marvell.com>
TO: Nilesh Javali <njavali@marvell.com>
TO: martin.petersen(a)oracle.com
CC: linux-scsi(a)vger.kernel.org
CC: GR-QLogic-Storage-Upstream(a)marvell.com

Hi Nilesh,

I love your patch! Perhaps something to improve:

[auto build test WARNING on be1b500212541a70006887bae558ff834d7365d0]

url:    https://github.com/0day-ci/linux/commits/Nilesh-Javali/qla2xxx-driver-enhancements/20201223-171449
base:    be1b500212541a70006887bae558ff834d7365d0
:::::: branch date: 13 days ago
:::::: commit date: 13 days ago
config: ia64-randconfig-s031-20210105 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-208-g46a52ca4-dirty
        # https://github.com/0day-ci/linux/commit/7eb936fb557f516350ac36eaf306bab881ca6508
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nilesh-Javali/qla2xxx-driver-enhancements/20201223-171449
        git checkout 7eb936fb557f516350ac36eaf306bab881ca6508
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
   drivers/scsi/qla2xxx/qla_iocb.c:2382:48: sparse: sparse: invalid assignment: |=
>> drivers/scsi/qla2xxx/qla_iocb.c:2382:48: sparse:    left side has type restricted __le32
>> drivers/scsi/qla2xxx/qla_iocb.c:2382:48: sparse:    right side has type int
   drivers/scsi/qla2xxx/qla_iocb.c: note: in included file (through arch/ia64/include/asm/io.h, include/linux/io.h, include/linux/irq.h, ...):
   include/asm-generic/io.h:259:16: sparse: sparse: cast to restricted __le16
   include/asm-generic/io.h:259:16: sparse: sparse: cast to restricted __le16
   include/asm-generic/io.h:267:16: sparse: sparse: cast to restricted __le32
   include/asm-generic/io.h:267:16: sparse: sparse: cast to restricted __le32
   include/asm-generic/io.h:267:16: sparse: sparse: cast to restricted __le32
   include/asm-generic/io.h:259:16: sparse: sparse: cast to restricted __le16
   include/asm-generic/io.h:267:16: sparse: sparse: cast to restricted __le32
   include/asm-generic/io.h:267:16: sparse: sparse: cast to restricted __le32
   include/asm-generic/io.h:267:16: sparse: sparse: cast to restricted __le32
   include/asm-generic/io.h:267:16: sparse: sparse: cast to restricted __le32
   include/asm-generic/io.h:267:16: sparse: sparse: cast to restricted __le32
   include/asm-generic/io.h:267:16: sparse: sparse: cast to restricted __le32
   include/asm-generic/io.h:267:16: sparse: sparse: cast to restricted __le32

vim +2382 drivers/scsi/qla2xxx/qla_iocb.c

82de802ad46e238 Quinn Tran      2017-06-13  2367  
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2368  static void
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2369  qla24xx_prli_iocb(srb_t *sp, struct logio_entry_24xx *logio)
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2370  {
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2371  	struct srb_iocb *lio = &sp->u.iocb_cmd;
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2372  
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2373  	logio->entry_type = LOGINOUT_PORT_IOCB_TYPE;
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2374  	logio->control_flags = cpu_to_le16(LCF_COMMAND_PRLI);
03aaa89fe46fecc Darren Trapp    2019-02-15  2375  	if (lio->u.logio.flags & SRB_LOGIN_NVME_PRLI) {
7ffa5b939751b66 Bart Van Assche 2020-05-18  2376  		logio->control_flags |= cpu_to_le16(LCF_NVME_PRLI);
03aaa89fe46fecc Darren Trapp    2019-02-15  2377  		if (sp->vha->flags.nvme_first_burst)
7ffa5b939751b66 Bart Van Assche 2020-05-18  2378  			logio->io_parameter[0] =
7ffa5b939751b66 Bart Van Assche 2020-05-18  2379  				cpu_to_le32(NVME_PRLI_SP_FIRST_BURST);
cf3c54fb49a4eb5 Saurav Kashyap  2020-09-03  2380  		if (sp->vha->flags.nvme2_enabled) {
7eb936fb557f516 Saurav Kashyap  2020-12-23  2381  			/* Set service parameter BIT_7 for NVME CONF support */
7eb936fb557f516 Saurav Kashyap  2020-12-23 @2382  			logio->io_parameter[0] |= NVME_PRLI_SP_CONF;
cf3c54fb49a4eb5 Saurav Kashyap  2020-09-03  2383  			/* Set service parameter BIT_8 for SLER support */
cf3c54fb49a4eb5 Saurav Kashyap  2020-09-03  2384  			logio->io_parameter[0] |=
cf3c54fb49a4eb5 Saurav Kashyap  2020-09-03  2385  				cpu_to_le32(NVME_PRLI_SP_SLER);
cf3c54fb49a4eb5 Saurav Kashyap  2020-09-03  2386  			/* Set service parameter BIT_9 for PI control support */
cf3c54fb49a4eb5 Saurav Kashyap  2020-09-03  2387  			logio->io_parameter[0] |=
cf3c54fb49a4eb5 Saurav Kashyap  2020-09-03  2388  				cpu_to_le32(NVME_PRLI_SP_PI_CTRL);
cf3c54fb49a4eb5 Saurav Kashyap  2020-09-03  2389  		}
03aaa89fe46fecc Darren Trapp    2019-02-15  2390  	}
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2391  
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2392  	logio->nport_handle = cpu_to_le16(sp->fcport->loop_id);
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2393  	logio->port_id[0] = sp->fcport->d_id.b.al_pa;
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2394  	logio->port_id[1] = sp->fcport->d_id.b.area;
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2395  	logio->port_id[2] = sp->fcport->d_id.b.domain;
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2396  	logio->vp_index = sp->vha->vp_idx;
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2397  }
a5d42f4cffa58d0 Duane Grigsby   2017-06-21  2398  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42674 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [PATCH 6/7] qla2xxx: Enable NVME CONF (BIT_7) when enabling SLER
  2020-12-23  9:04 [PATCH 0/7] qla2xxx driver enhancements Nilesh Javali
@ 2020-12-23  9:04 ` Nilesh Javali
  0 siblings, 0 replies; 2+ messages in thread
From: Nilesh Javali @ 2020-12-23  9:04 UTC (permalink / raw)
  To: martin.petersen; +Cc: linux-scsi, GR-QLogic-Storage-Upstream

From: Saurav Kashyap <skashyap@marvell.com>

Enable NVME confirmation bit in PRLI.

Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
 drivers/scsi/qla2xxx/qla_iocb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index e27359b294d3..8b41cbaf8535 100644
--- a/drivers/scsi/qla2xxx/qla_iocb.c
+++ b/drivers/scsi/qla2xxx/qla_iocb.c
@@ -2378,6 +2378,8 @@ qla24xx_prli_iocb(srb_t *sp, struct logio_entry_24xx *logio)
 			logio->io_parameter[0] =
 				cpu_to_le32(NVME_PRLI_SP_FIRST_BURST);
 		if (sp->vha->flags.nvme2_enabled) {
+			/* Set service parameter BIT_7 for NVME CONF support */
+			logio->io_parameter[0] |= NVME_PRLI_SP_CONF;
 			/* Set service parameter BIT_8 for SLER support */
 			logio->io_parameter[0] |=
 				cpu_to_le32(NVME_PRLI_SP_SLER);
-- 
2.19.0.rc0


^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-05  3:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05  3:30 [PATCH 6/7] qla2xxx: Enable NVME CONF (BIT_7) when enabling SLER kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2020-12-23  9:04 [PATCH 0/7] qla2xxx driver enhancements Nilesh Javali
2020-12-23  9:04 ` [PATCH 6/7] qla2xxx: Enable NVME CONF (BIT_7) when enabling SLER Nilesh Javali

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.