* [PATCH 1/1] nvme: remove the unused status argument from nvme_trace_bio_complete
@ 2021-01-05 10:34 Max Gurtovoy
2021-01-05 12:43 ` Minwoo Im
2021-01-06 9:31 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Max Gurtovoy @ 2021-01-05 10:34 UTC (permalink / raw)
To: linux-nvme, sagi, kbusch, hch; +Cc: israelr, Max Gurtovoy, nitzanc, oren
The only used argument in this function is the "req".
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
drivers/nvme/host/core.c | 2 +-
drivers/nvme/host/nvme.h | 6 ++----
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index ce1b61519441..7da1c42bce78 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -331,7 +331,7 @@ static inline void nvme_end_req(struct request *req)
req->__sector = nvme_lba_to_sect(req->q->queuedata,
le64_to_cpu(nvme_req(req)->result.u64));
- nvme_trace_bio_complete(req, status);
+ nvme_trace_bio_complete(req);
blk_mq_end_request(req, status);
}
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index 7e49f61f81df..8bd7d8dd906c 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -675,8 +675,7 @@ static inline void nvme_mpath_check_last_path(struct nvme_ns *ns)
kblockd_schedule_work(&head->requeue_work);
}
-static inline void nvme_trace_bio_complete(struct request *req,
- blk_status_t status)
+static inline void nvme_trace_bio_complete(struct request *req)
{
struct nvme_ns *ns = req->q->queuedata;
@@ -731,8 +730,7 @@ static inline void nvme_mpath_clear_ctrl_paths(struct nvme_ctrl *ctrl)
static inline void nvme_mpath_check_last_path(struct nvme_ns *ns)
{
}
-static inline void nvme_trace_bio_complete(struct request *req,
- blk_status_t status)
+static inline void nvme_trace_bio_complete(struct request *req)
{
}
static inline int nvme_mpath_init(struct nvme_ctrl *ctrl,
--
2.25.4
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] nvme: remove the unused status argument from nvme_trace_bio_complete
2021-01-05 10:34 [PATCH 1/1] nvme: remove the unused status argument from nvme_trace_bio_complete Max Gurtovoy
@ 2021-01-05 12:43 ` Minwoo Im
2021-01-06 9:31 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Minwoo Im @ 2021-01-05 12:43 UTC (permalink / raw)
To: Max Gurtovoy; +Cc: sagi, israelr, linux-nvme, oren, nitzanc, kbusch, hch
Hello,
Looks good to me.
On 21-01-05 10:34:02, Max Gurtovoy wrote:
> The only used argument in this function is the "req".
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
Thanks,
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] nvme: remove the unused status argument from nvme_trace_bio_complete
2021-01-05 10:34 [PATCH 1/1] nvme: remove the unused status argument from nvme_trace_bio_complete Max Gurtovoy
2021-01-05 12:43 ` Minwoo Im
@ 2021-01-06 9:31 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-01-06 9:31 UTC (permalink / raw)
To: Max Gurtovoy; +Cc: sagi, israelr, linux-nvme, hch, nitzanc, kbusch, oren
Thanks,
applied to nvme-5.11.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-06 9:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05 10:34 [PATCH 1/1] nvme: remove the unused status argument from nvme_trace_bio_complete Max Gurtovoy
2021-01-05 12:43 ` Minwoo Im
2021-01-06 9:31 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.