* [PATCH] i2c: fix platform_get_irq.cocci warnings
@ 2020-12-25 8:40 Tian Tao
2021-01-05 16:35 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2020-12-25 8:40 UTC (permalink / raw)
To: wsa, rrichter, thor.thayer, manivannan.sadhasivam, linus.walleij,
zhengdejin5, hslester96
Cc: linux-i2c
Remove dev_err() messages after platform_get_irq*() failures.
drivers/i2c/busses/i2c-hix5hd2.c:417:2-9: line 417 is redundant
because platform_get_irq() already prints an error
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/i2c/busses/i2c-hix5hd2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-hix5hd2.c b/drivers/i2c/busses/i2c-hix5hd2.c
index ab15b1e..c45f226 100644
--- a/drivers/i2c/busses/i2c-hix5hd2.c
+++ b/drivers/i2c/busses/i2c-hix5hd2.c
@@ -413,10 +413,8 @@ static int hix5hd2_i2c_probe(struct platform_device *pdev)
return PTR_ERR(priv->regs);
irq = platform_get_irq(pdev, 0);
- if (irq <= 0) {
- dev_err(&pdev->dev, "cannot find HS-I2C IRQ\n");
+ if (irq <= 0)
return irq;
- }
priv->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(priv->clk)) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: fix platform_get_irq.cocci warnings
2020-12-25 8:40 [PATCH] i2c: fix platform_get_irq.cocci warnings Tian Tao
@ 2021-01-05 16:35 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2021-01-05 16:35 UTC (permalink / raw)
To: Tian Tao
Cc: rrichter, thor.thayer, manivannan.sadhasivam, linus.walleij,
zhengdejin5, hslester96, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
On Fri, Dec 25, 2020 at 04:40:06PM +0800, Tian Tao wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> drivers/i2c/busses/i2c-hix5hd2.c:417:2-9: line 417 is redundant
> because platform_get_irq() already prints an error
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-05 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-25 8:40 [PATCH] i2c: fix platform_get_irq.cocci warnings Tian Tao
2021-01-05 16:35 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.