From: kernel test robot <lkp@intel.com> To: Andrii Nakryiko <andrii@kernel.org>, bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com, daniel@iogearbox.net Cc: kbuild-all@lists.01.org, andrii@kernel.org, kernel-team@fb.com, Hao Luo <haoluo@google.com> Subject: Re: [PATCH bpf-next 2/4] bpf: support BPF ksym variables in kernel modules Date: Wed, 6 Jan 2021 16:16:31 +0800 [thread overview] Message-ID: <202101061625.D0C0F3ZJ-lkp@intel.com> (raw) In-Reply-To: <20210106064048.2554276-3-andrii@kernel.org> [-- Attachment #1: Type: text/plain, Size: 4604 bytes --] Hi Andrii, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Andrii-Nakryiko/Support-kernel-module-ksym-variables/20210106-144531 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: nds32-defconfig (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/1dde2eabb1a7670d0e764e46dae1ef0a9abf0466 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andrii-Nakryiko/Support-kernel-module-ksym-variables/20210106-144531 git checkout 1dde2eabb1a7670d0e764e46dae1ef0a9abf0466 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): kernel/bpf/core.c:1350:12: warning: no previous prototype for 'bpf_probe_read_kernel' [-Wmissing-prototypes] 1350 | u64 __weak bpf_probe_read_kernel(void *dst, u32 size, const void *unsafe_ptr) | ^~~~~~~~~~~~~~~~~~~~~ In file included from kernel/bpf/core.c:21: kernel/bpf/core.c: In function '___bpf_prog_run': include/linux/filter.h:888:3: warning: cast between incompatible function types from 'u64 (*)(u64, u64, u64, u64, u64)' {aka 'long long unsigned int (*)(long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int)'} to 'u64 (*)(u64, u64, u64, u64, u64, const struct bpf_insn *)' {aka 'long long unsigned int (*)(long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, const struct bpf_insn *)'} [-Wcast-function-type] 888 | ((u64 (*)(u64, u64, u64, u64, u64, const struct bpf_insn *)) \ | ^ kernel/bpf/core.c:1518:13: note: in expansion of macro '__bpf_call_base_args' 1518 | BPF_R0 = (__bpf_call_base_args + insn->imm)(BPF_R1, BPF_R2, | ^~~~~~~~~~~~~~~~~~~~ kernel/bpf/core.c: At top level: kernel/bpf/core.c:1704:6: warning: no previous prototype for 'bpf_patch_call_args' [-Wmissing-prototypes] 1704 | void bpf_patch_call_args(struct bpf_insn *insn, u32 stack_depth) | ^~~~~~~~~~~~~~~~~~~ In file included from kernel/bpf/core.c:21: kernel/bpf/core.c: In function 'bpf_patch_call_args': include/linux/filter.h:888:3: warning: cast between incompatible function types from 'u64 (*)(u64, u64, u64, u64, u64)' {aka 'long long unsigned int (*)(long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int)'} to 'u64 (*)(u64, u64, u64, u64, u64, const struct bpf_insn *)' {aka 'long long unsigned int (*)(long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, const struct bpf_insn *)'} [-Wcast-function-type] 888 | ((u64 (*)(u64, u64, u64, u64, u64, const struct bpf_insn *)) \ | ^ kernel/bpf/core.c:1709:3: note: in expansion of macro '__bpf_call_base_args' 1709 | __bpf_call_base_args; | ^~~~~~~~~~~~~~~~~~~~ kernel/bpf/core.c: At top level: kernel/bpf/core.c:2102:6: warning: no previous prototype for '__bpf_free_used_maps' [-Wmissing-prototypes] 2102 | void __bpf_free_used_maps(struct bpf_prog_aux *aux, | ^~~~~~~~~~~~~~~~~~~~ >> kernel/bpf/core.c:2122:6: warning: no previous prototype for '__bpf_free_used_btfs' [-Wmissing-prototypes] 2122 | void __bpf_free_used_btfs(struct bpf_prog_aux *aux, | ^~~~~~~~~~~~~~~~~~~~ vim +/__bpf_free_used_btfs +2122 kernel/bpf/core.c 2121 > 2122 void __bpf_free_used_btfs(struct bpf_prog_aux *aux, 2123 struct btf_mod_pair *used_btfs, u32 len) 2124 { 2125 #ifdef CONFIG_BPF_SYSCALL 2126 struct btf_mod_pair *btf_mod; 2127 u32 i; 2128 2129 for (i = 0; i < len; i++) { 2130 btf_mod = &used_btfs[i]; 2131 if (btf_mod->module) 2132 module_put(btf_mod->module); 2133 btf_put(btf_mod->btf); 2134 } 2135 #endif 2136 } 2137 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 10786 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH bpf-next 2/4] bpf: support BPF ksym variables in kernel modules Date: Wed, 06 Jan 2021 16:16:31 +0800 [thread overview] Message-ID: <202101061625.D0C0F3ZJ-lkp@intel.com> (raw) In-Reply-To: <20210106064048.2554276-3-andrii@kernel.org> [-- Attachment #1: Type: text/plain, Size: 4686 bytes --] Hi Andrii, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Andrii-Nakryiko/Support-kernel-module-ksym-variables/20210106-144531 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: nds32-defconfig (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/1dde2eabb1a7670d0e764e46dae1ef0a9abf0466 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andrii-Nakryiko/Support-kernel-module-ksym-variables/20210106-144531 git checkout 1dde2eabb1a7670d0e764e46dae1ef0a9abf0466 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): kernel/bpf/core.c:1350:12: warning: no previous prototype for 'bpf_probe_read_kernel' [-Wmissing-prototypes] 1350 | u64 __weak bpf_probe_read_kernel(void *dst, u32 size, const void *unsafe_ptr) | ^~~~~~~~~~~~~~~~~~~~~ In file included from kernel/bpf/core.c:21: kernel/bpf/core.c: In function '___bpf_prog_run': include/linux/filter.h:888:3: warning: cast between incompatible function types from 'u64 (*)(u64, u64, u64, u64, u64)' {aka 'long long unsigned int (*)(long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int)'} to 'u64 (*)(u64, u64, u64, u64, u64, const struct bpf_insn *)' {aka 'long long unsigned int (*)(long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, const struct bpf_insn *)'} [-Wcast-function-type] 888 | ((u64 (*)(u64, u64, u64, u64, u64, const struct bpf_insn *)) \ | ^ kernel/bpf/core.c:1518:13: note: in expansion of macro '__bpf_call_base_args' 1518 | BPF_R0 = (__bpf_call_base_args + insn->imm)(BPF_R1, BPF_R2, | ^~~~~~~~~~~~~~~~~~~~ kernel/bpf/core.c: At top level: kernel/bpf/core.c:1704:6: warning: no previous prototype for 'bpf_patch_call_args' [-Wmissing-prototypes] 1704 | void bpf_patch_call_args(struct bpf_insn *insn, u32 stack_depth) | ^~~~~~~~~~~~~~~~~~~ In file included from kernel/bpf/core.c:21: kernel/bpf/core.c: In function 'bpf_patch_call_args': include/linux/filter.h:888:3: warning: cast between incompatible function types from 'u64 (*)(u64, u64, u64, u64, u64)' {aka 'long long unsigned int (*)(long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int)'} to 'u64 (*)(u64, u64, u64, u64, u64, const struct bpf_insn *)' {aka 'long long unsigned int (*)(long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, long long unsigned int, const struct bpf_insn *)'} [-Wcast-function-type] 888 | ((u64 (*)(u64, u64, u64, u64, u64, const struct bpf_insn *)) \ | ^ kernel/bpf/core.c:1709:3: note: in expansion of macro '__bpf_call_base_args' 1709 | __bpf_call_base_args; | ^~~~~~~~~~~~~~~~~~~~ kernel/bpf/core.c: At top level: kernel/bpf/core.c:2102:6: warning: no previous prototype for '__bpf_free_used_maps' [-Wmissing-prototypes] 2102 | void __bpf_free_used_maps(struct bpf_prog_aux *aux, | ^~~~~~~~~~~~~~~~~~~~ >> kernel/bpf/core.c:2122:6: warning: no previous prototype for '__bpf_free_used_btfs' [-Wmissing-prototypes] 2122 | void __bpf_free_used_btfs(struct bpf_prog_aux *aux, | ^~~~~~~~~~~~~~~~~~~~ vim +/__bpf_free_used_btfs +2122 kernel/bpf/core.c 2121 > 2122 void __bpf_free_used_btfs(struct bpf_prog_aux *aux, 2123 struct btf_mod_pair *used_btfs, u32 len) 2124 { 2125 #ifdef CONFIG_BPF_SYSCALL 2126 struct btf_mod_pair *btf_mod; 2127 u32 i; 2128 2129 for (i = 0; i < len; i++) { 2130 btf_mod = &used_btfs[i]; 2131 if (btf_mod->module) 2132 module_put(btf_mod->module); 2133 btf_put(btf_mod->btf); 2134 } 2135 #endif 2136 } 2137 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 10786 bytes --]
next prev parent reply other threads:[~2021-01-06 8:18 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-06 6:40 [PATCH bpf-next 0/4] Support kernel module ksym variables Andrii Nakryiko 2021-01-06 6:40 ` [PATCH bpf-next 1/4] selftests/bpf: sync RCU before unloading bpf_testmod Andrii Nakryiko 2021-01-06 6:40 ` [PATCH bpf-next 2/4] bpf: support BPF ksym variables in kernel modules Andrii Nakryiko 2021-01-06 8:16 ` kernel test robot [this message] 2021-01-06 8:16 ` kernel test robot 2021-01-06 8:31 ` kernel test robot 2021-01-06 8:31 ` kernel test robot 2021-01-06 6:40 ` [PATCH bpf-next 3/4] libbpf: support kernel module ksym externs Andrii Nakryiko 2021-01-06 6:40 ` [PATCH bpf-next 4/4] selftests/bpf: test " Andrii Nakryiko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202101061625.D0C0F3ZJ-lkp@intel.com \ --to=lkp@intel.com \ --cc=andrii@kernel.org \ --cc=ast@fb.com \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=haoluo@google.com \ --cc=kbuild-all@lists.01.org \ --cc=kernel-team@fb.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.