* [PATCH] media: atomisp: ov2722: remove unnecessary debug print
@ 2021-01-06 18:11 ` Filip Kolev
0 siblings, 0 replies; 2+ messages in thread
From: Filip Kolev @ 2021-01-06 18:11 UTC (permalink / raw)
Cc: Filip Kolev, Mauro Carvalho Chehab, Sakari Ailus,
Greg Kroah-Hartman, linux-media, devel, linux-kernel
checkpatch.pl emits the following warning:
WARNING: Prefer using '"%s...", __func__' to using 'ov2722_remove', this function's name, in a string
+ dev_dbg(&client->dev, "ov2722_remove...\n");
This is just a "trace" call and therefore should be removed entirely;
ftrace should be used instead.
Signed-off-by: Filip Kolev <fil.kolev@gmail.com>
---
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
index eecefcd734d0e..1209492c1826a 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
@@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client)
struct v4l2_subdev *sd = i2c_get_clientdata(client);
struct ov2722_device *dev = to_ov2722_sensor(sd);
- dev_dbg(&client->dev, "ov2722_remove...\n");
-
dev->platform_data->csi_cfg(sd, 0);
v4l2_ctrl_handler_free(&dev->ctrl_handler);
v4l2_device_unregister_subdev(sd);
--
2.30.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] media: atomisp: ov2722: remove unnecessary debug print
@ 2021-01-06 18:11 ` Filip Kolev
0 siblings, 0 replies; 2+ messages in thread
From: Filip Kolev @ 2021-01-06 18:11 UTC (permalink / raw)
Cc: Filip Kolev, devel, Greg Kroah-Hartman, linux-kernel,
Sakari Ailus, Mauro Carvalho Chehab, linux-media
checkpatch.pl emits the following warning:
WARNING: Prefer using '"%s...", __func__' to using 'ov2722_remove', this function's name, in a string
+ dev_dbg(&client->dev, "ov2722_remove...\n");
This is just a "trace" call and therefore should be removed entirely;
ftrace should be used instead.
Signed-off-by: Filip Kolev <fil.kolev@gmail.com>
---
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
index eecefcd734d0e..1209492c1826a 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
@@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client)
struct v4l2_subdev *sd = i2c_get_clientdata(client);
struct ov2722_device *dev = to_ov2722_sensor(sd);
- dev_dbg(&client->dev, "ov2722_remove...\n");
-
dev->platform_data->csi_cfg(sd, 0);
v4l2_ctrl_handler_free(&dev->ctrl_handler);
v4l2_device_unregister_subdev(sd);
--
2.30.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-06 18:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-06 18:11 [PATCH] media: atomisp: ov2722: remove unnecessary debug print Filip Kolev
2021-01-06 18:11 ` Filip Kolev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.