* [Buildroot] [PATCH v2,1/1] package/htop: needs dynamic library
@ 2021-01-07 6:48 Fabrice Fontaine
2021-01-16 22:01 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2021-01-07 6:48 UTC (permalink / raw)
To: buildroot
htop unconditionally uses dlopen since version 3.0.3 and
https://github.com/htop-dev/htop/commit/2a9e8ca07475e61e74d7b6f0afd0a5fd272cb07f
Fixes:
- http://autobuild.buildroot.org/results/2976729b0b95bf822c3095efbcf3f86d6c71874f
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2:
- Drop static workaround for ARC
package/htop/Config.in | 5 +++++
package/htop/htop.mk | 7 -------
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/package/htop/Config.in b/package/htop/Config.in
index 7bb0fe6e07..214a9a1c99 100644
--- a/package/htop/Config.in
+++ b/package/htop/Config.in
@@ -1,9 +1,14 @@
config BR2_PACKAGE_HTOP
bool "htop"
depends on BR2_USE_MMU # fork()
+ depends on !BR2_STATIC_LIBS # dlopen()
select BR2_PACKAGE_NCURSES
help
htop is an interactive text-mode process viewer for Linux.
It aims to be a better top.
https://htop.dev/
+
+comment "htop needs a toolchain w/ dynamic library"
+ depends on BR2_USE_MMU
+ depends on BR2_STATIC_LIBS
diff --git a/package/htop/htop.mk b/package/htop/htop.mk
index bb6185a56d..25d1a9a129 100644
--- a/package/htop/htop.mk
+++ b/package/htop/htop.mk
@@ -18,11 +18,4 @@ else
HTOP_CONF_OPTS += --disable-unicode
endif
-# ARC uses an old uClibc that needs dladdr() for backtrace support,
-# which doesn't work for static only scenario, so as a workaround, we
-# pretend that execinfo.h is not available.
-ifeq ($(BR2_arc)$(BR2_STATIC_LIBS),yy)
-HTOP_CONF_ENV += ac_cv_header_execinfo_h=no
-endif
-
$(eval $(autotools-package))
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH v2,1/1] package/htop: needs dynamic library
2021-01-07 6:48 [Buildroot] [PATCH v2,1/1] package/htop: needs dynamic library Fabrice Fontaine
@ 2021-01-16 22:01 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2021-01-16 22:01 UTC (permalink / raw)
To: buildroot
On Thu, 7 Jan 2021 07:48:55 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> htop unconditionally uses dlopen since version 3.0.3 and
> https://github.com/htop-dev/htop/commit/2a9e8ca07475e61e74d7b6f0afd0a5fd272cb07f
>
> Fixes:
> - http://autobuild.buildroot.org/results/2976729b0b95bf822c3095efbcf3f86d6c71874f
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2:
> - Drop static workaround for ARC
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-16 22:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 6:48 [Buildroot] [PATCH v2,1/1] package/htop: needs dynamic library Fabrice Fontaine
2021-01-16 22:01 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.