All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: LABBE Corentin <clabbe@baylibre.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org,
	Zheng Yongjun <zhengyongjun3@huawei.com>,
	mjpeg-users@lists.sourceforge.net, mchehab@kernel.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH -next] media: zoran: use resource_size
Date: Thu, 7 Jan 2021 13:45:57 +0300	[thread overview]
Message-ID: <20210107104557.GA5083@kadam> (raw)
In-Reply-To: <X/Ybbj6gN2xrhIwP@Red>

On Wed, Jan 06, 2021 at 09:19:58PM +0100, LABBE Corentin wrote:
> Le Wed, Jan 06, 2021 at 05:51:00PM +0300, Dan Carpenter a écrit :
> > On Wed, Jan 06, 2021 at 09:17:02PM +0800, Zheng Yongjun wrote:
> > > Use resource_size rather than a verbose computation on
> > > the end and start fields.
> > > 
> > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> > > ---
> > >  drivers/staging/media/zoran/zoran_driver.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> > > index 808196ea5b81..d60b4c73ea80 100644
> > > --- a/drivers/staging/media/zoran/zoran_driver.c
> > > +++ b/drivers/staging/media/zoran/zoran_driver.c
> > > @@ -1020,7 +1020,7 @@ int zoran_queue_init(struct zoran *zr, struct vb2_queue *vq)
> > >  	vq->buf_struct_size = sizeof(struct zr_buffer);
> > >  	vq->ops = &zr_video_qops;
> > >  	vq->mem_ops = &vb2_dma_contig_memops;
> > > -	vq->gfp_flags = GFP_DMA32,
> > > +	vq->gfp_flags = GFP_DMA32;
> > 
> > The commit doesn't match the patch.  Also this driver is in
> > staging because it's going to be deleted soon so there probably isn't
> > much point doing cleanups.
> > 
> 
> No, the driver just came back in staging since I fixed the videobuf2 conversion.

Ah... Thanks.

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: LABBE Corentin <clabbe@baylibre.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org,
	Zheng Yongjun <zhengyongjun3@huawei.com>,
	mjpeg-users@lists.sourceforge.net, mchehab@kernel.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH -next] media: zoran: use resource_size
Date: Thu, 7 Jan 2021 13:45:57 +0300	[thread overview]
Message-ID: <20210107104557.GA5083@kadam> (raw)
In-Reply-To: <X/Ybbj6gN2xrhIwP@Red>

On Wed, Jan 06, 2021 at 09:19:58PM +0100, LABBE Corentin wrote:
> Le Wed, Jan 06, 2021 at 05:51:00PM +0300, Dan Carpenter a écrit :
> > On Wed, Jan 06, 2021 at 09:17:02PM +0800, Zheng Yongjun wrote:
> > > Use resource_size rather than a verbose computation on
> > > the end and start fields.
> > > 
> > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> > > ---
> > >  drivers/staging/media/zoran/zoran_driver.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> > > index 808196ea5b81..d60b4c73ea80 100644
> > > --- a/drivers/staging/media/zoran/zoran_driver.c
> > > +++ b/drivers/staging/media/zoran/zoran_driver.c
> > > @@ -1020,7 +1020,7 @@ int zoran_queue_init(struct zoran *zr, struct vb2_queue *vq)
> > >  	vq->buf_struct_size = sizeof(struct zr_buffer);
> > >  	vq->ops = &zr_video_qops;
> > >  	vq->mem_ops = &vb2_dma_contig_memops;
> > > -	vq->gfp_flags = GFP_DMA32,
> > > +	vq->gfp_flags = GFP_DMA32;
> > 
> > The commit doesn't match the patch.  Also this driver is in
> > staging because it's going to be deleted soon so there probably isn't
> > much point doing cleanups.
> > 
> 
> No, the driver just came back in staging since I fixed the videobuf2 conversion.

Ah... Thanks.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2021-01-07 10:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 13:17 [PATCH -next] media: zoran: use resource_size Zheng Yongjun
2021-01-06 13:17 ` Zheng Yongjun
2021-01-06 13:30 ` 答复: " zhengyongjun
2021-01-06 13:30   ` zhengyongjun
2021-01-06 14:51 ` Dan Carpenter
2021-01-06 14:51   ` Dan Carpenter
2021-01-06 20:19   ` LABBE Corentin
2021-01-06 20:19     ` LABBE Corentin
2021-01-07 10:45     ` Dan Carpenter [this message]
2021-01-07 10:45       ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210107104557.GA5083@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=clabbe@baylibre.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mjpeg-users@lists.sourceforge.net \
    --cc=zhengyongjun3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.